Index: results/cppcheckError.csv =================================================================== diff -u -r5deb1226f003e7d2e5c628377e31b914468f8ecf -r7e2931d9a468ca3b6e1f2bb88ef0910960dfdb29 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 5deb1226f003e7d2e5c628377e31b914468f8ecf) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 7e2931d9a468ca3b6e1f2bb88ef0910960dfdb29) @@ -3,9 +3,11 @@ dgfirmware/firmware/App/Controllers/ROPump.c,338,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. dgfirmware/firmware/App/Controllers/ROPump.c,339,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. dgfirmware/firmware/App/Controllers/ROPump.c,340,style,unusedVariable,Unused variable: newPWM -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,524,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Modes/ModeFill.c,146,style,redundantAssignment,Variable 'isInletWaterReady' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Modes/ModeFill.c,181,style,redundantAssignment,Variable 'isDialysateProductionGood' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/TemperatureSensors.c,528,style,knownConditionTrueFalse,Condition 'fpgaError==0' is always true +dgfirmware/firmware/App/Controllers/TemperatureSensors.c,525,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,153,style,redundantAssignment,Variable 'isInletWaterReady' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,188,style,redundantAssignment,Variable 'isDialysateProductionGood' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,220,style,redundantAssignment,Variable 'isDialysateConductivityBad' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Services/Interrupts.c,172,style,variableScope,The scope of the variable 'debugStr' can be reduced. dgfirmware/firmware/App/Services/PIControllers.c,76,style,variableScope,The scope of the variable 'controller' can be reduced. dgfirmware/firmware/App/Services/Reservoirs.c,267,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used.