Index: results/cppcheckError.csv =================================================================== diff -u -r7e2931d9a468ca3b6e1f2bb88ef0910960dfdb29 -r3461c140ba07e74863dee1d4c51d0119076fecf8 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 7e2931d9a468ca3b6e1f2bb88ef0910960dfdb29) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 3461c140ba07e74863dee1d4c51d0119076fecf8) @@ -5,12 +5,12 @@ dgfirmware/firmware/App/Controllers/ROPump.c,340,style,unusedVariable,Unused variable: newPWM dgfirmware/firmware/App/Controllers/TemperatureSensors.c,528,style,knownConditionTrueFalse,Condition 'fpgaError==0' is always true dgfirmware/firmware/App/Controllers/TemperatureSensors.c,525,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Modes/ModeFill.c,153,style,redundantAssignment,Variable 'isInletWaterReady' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Modes/ModeFill.c,188,style,redundantAssignment,Variable 'isDialysateProductionGood' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Modes/ModeFill.c,220,style,redundantAssignment,Variable 'isDialysateConductivityBad' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,163,style,redundantAssignment,Variable 'isInletWaterReady' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,199,style,redundantAssignment,Variable 'isDialysateProductionGood' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,231,style,redundantAssignment,Variable 'isDialysateConductivityBad' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Services/Interrupts.c,172,style,variableScope,The scope of the variable 'debugStr' can be reduced. dgfirmware/firmware/App/Services/PIControllers.c,76,style,variableScope,The scope of the variable 'controller' can be reduced. -dgfirmware/firmware/App/Services/Reservoirs.c,267,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Services/Reservoirs.c,269,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1526,style,variableScope,The scope of the variable 'quotient' can be reduced. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1527,style,variableScope,The scope of the variable 'modulus' can be reduced. @@ -19,7 +19,7 @@ dgfirmware/firmware/FWCommon/RTC.c,782,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. dgfirmware/firmware/FWCommon/RTC.c,783,style,variableScope,The scope of the variable 'decimalLow' can be reduced. dgfirmware/firmware/FWCommon/RTC.c,706,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -dgfirmware/firmware/FWCommon/Utilities.c,212,style,variableScope,The scope of the variable 'timeInMS' can be reduced. +dgfirmware/firmware/FWCommon/Utilities.c,216,style,variableScope,The scope of the variable 'timeInMS' can be reduced. dgfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. dgfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. @@ -35,7 +35,7 @@ dgfirmware/firmware/FWCommon/RTC.c,364,style,unusedFunction,The function 'execRTC' is never used. dgfirmware/firmware/FWCommon/Accel.c,665,style,unusedFunction,The function 'getAccelCalibration' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,724,style,unusedFunction,The function 'getBootloaderFlag' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,251,style,unusedFunction,The function 'getCriticalData' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,255,style,unusedFunction,The function 'getCriticalData' is never used. dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,94,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. dgfirmware/firmware/App/Modes/ModeDrain.c,139,style,unusedFunction,The function 'getCurrentDrainState' is never used. dgfirmware/firmware/App/Modes/ModeFault.c,88,style,unusedFunction,The function 'getCurrentFaultState' is never used. @@ -44,7 +44,7 @@ dgfirmware/firmware/App/Modes/ModeInitPOST.c,225,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. dgfirmware/firmware/App/Modes/ModeService.c,88,style,unusedFunction,The function 'getCurrentServiceState' is never used. dgfirmware/firmware/App/Modes/ModeSolo.c,118,style,unusedFunction,The function 'getCurrentSoloState' is never used. -dgfirmware/firmware/App/Modes/ModeStandby.c,232,style,unusedFunction,The function 'getCurrentStandbyState' is never used. +dgfirmware/firmware/App/Modes/ModeStandby.c,234,style,unusedFunction,The function 'getCurrentStandbyState' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getDisinfectionDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,332,style,unusedFunction,The function 'getMfgData' is never used. dgfirmware/firmware/App/Services/PIControllers.c,188,style,unusedFunction,The function 'getPIControllerSignals' is never used. @@ -59,21 +59,21 @@ dgfirmware/firmware/App/Drivers/SafetyShutdown.c,71,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. dgfirmware/firmware/App/Services/Interrupts.c,91,style,unusedFunction,The function 'phantomInterrupt' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,471,style,unusedFunction,The function 'readLogData' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,366,style,unusedFunction,The function 'resetCriticalData' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,370,style,unusedFunction,The function 'resetCriticalData' is never used. dgfirmware/firmware/App/Services/Interrupts.c,113,style,unusedFunction,The function 'rtiNotification' is never used. dgfirmware/firmware/App/Services/Interrupts.c,242,style,unusedFunction,The function 'sciNotification' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,703,style,unusedFunction,The function 'setBootloaderFlag' is never used. dgfirmware/firmware/App/Drivers/CPLD.c,122,style,unusedFunction,The function 'setCPLDLampBlue' is never used. dgfirmware/firmware/App/Drivers/CPLD.c,102,style,unusedFunction,The function 'setCPLDLampGreen' is never used. dgfirmware/firmware/App/Drivers/CPLD.c,142,style,unusedFunction,The function 'setCPLDLampRed' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,326,style,unusedFunction,The function 'setCriticalData' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,330,style,unusedFunction,The function 'setCriticalData' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,570,style,unusedFunction,The function 'setDisinfectionDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,315,style,unusedFunction,The function 'setMfgData' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,400,style,unusedFunction,The function 'setServiceDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,494,style,unusedFunction,The function 'setTreatmentTime' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,532,style,unusedFunction,The function 'setWaterConsumption' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,240,style,unusedFunction,The function 'stopDrainCmd' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,190,style,unusedFunction,The function 'stopFillCmd' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,242,style,unusedFunction,The function 'stopDrainCmd' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,192,style,unusedFunction,The function 'stopFillCmd' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,476,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,566,style,unusedFunction,The function 'testResetReservoirDrainVolumeMlOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,521,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used.