Index: results/cppcheckError.csv =================================================================== diff -u -ra3f345385ae6e09cb29cc079e4e914677c1d0013 -re30951f62cdc9c52f20e9218df947d3860b3c7a7 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision a3f345385ae6e09cb29cc079e4e914677c1d0013) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision e30951f62cdc9c52f20e9218df947d3860b3c7a7) @@ -1,11 +1,9 @@ File, Line No., Severity, Issue, Description -dgfirmware/firmware/App/Controllers/DrainPump.c,170,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,346,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,347,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,348,style,unusedVariable,Unused variable: newPWM -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,534,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/DrainPump.c,174,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/DrainPump.c,206,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/TemperatureSensors.c,540,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Services/Interrupts.c,177,style,variableScope,The scope of the variable 'debugStr' can be reduced. -dgfirmware/firmware/App/Services/PIControllers.c,76,style,variableScope,The scope of the variable 'controller' can be reduced. +dgfirmware/firmware/App/Services/PIControllers.c,78,style,variableScope,The scope of the variable 'controller' can be reduced. dgfirmware/firmware/App/Services/Reservoirs.c,258,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1568,style,variableScope,The scope of the variable 'quotient' can be reduced. @@ -24,11 +22,15 @@ dgfirmware/firmware/App/Services/Interrupts.c,152,style,unusedFunction,The function 'canMessageNotification' is never used. dgfirmware/firmware/App/Services/Interrupts.c,319,style,unusedFunction,The function 'dmaGroupANotification' is never used. dgfirmware/firmware/App/Services/AlarmMgmt.c,72,style,unusedFunction,The function 'execAlarmMgmt' is never used. -dgfirmware/firmware/App/Controllers/DrainPump.c,393,style,unusedFunction,The function 'execDrainPumpTest' is never used. +dgfirmware/firmware/App/Controllers/DrainPump.c,480,style,unusedFunction,The function 'execDrainPumpTest' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,24,style,unusedFunction,The function 'execFans' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,19,style,unusedFunction,The function 'execFansSelfTest' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,756,style,unusedFunction,The function 'execNVDataMgmt' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,632,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,497,style,unusedFunction,The function 'execROPumpTest' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,732,style,unusedFunction,The function 'execROPumpTest' is never used. dgfirmware/firmware/FWCommon/RTC.c,368,style,unusedFunction,The function 'execRTC' is never used. +dgfirmware/firmware/App/Controllers/UVReactors.c,18,style,unusedFunction,The function 'execUVReactorsSelfTest' is never used. +dgfirmware/firmware/App/Controllers/UVReactors.c,23,style,unusedFunction,The function 'execUVReactos' is never used. dgfirmware/firmware/FWCommon/Accel.c,680,style,unusedFunction,The function 'getAccelCalibration' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,743,style,unusedFunction,The function 'getBootloaderFlag' is never used. dgfirmware/firmware/FWCommon/Utilities.c,256,style,unusedFunction,The function 'getCriticalData' is never used. @@ -37,22 +39,24 @@ dgfirmware/firmware/App/Modes/ModeFault.c,92,style,unusedFunction,The function 'getCurrentFaultState' is never used. dgfirmware/firmware/App/Modes/ModeFill.c,184,style,unusedFunction,The function 'getCurrentFillState' is never used. dgfirmware/firmware/App/Modes/ModeFlush.c,96,style,unusedFunction,The function 'getCurrentFlushState' is never used. -dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,97,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,232,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. +dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,248,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,234,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. dgfirmware/firmware/App/Modes/ModeService.c,92,style,unusedFunction,The function 'getCurrentServiceState' is never used. dgfirmware/firmware/App/Modes/ModeSolo.c,123,style,unusedFunction,The function 'getCurrentSoloState' is never used. dgfirmware/firmware/App/Modes/ModeStandby.c,236,style,unusedFunction,The function 'getCurrentStandbyState' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,611,style,unusedFunction,The function 'getDisinfectionDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,336,style,unusedFunction,The function 'getMfgData' is never used. -dgfirmware/firmware/App/Services/PIControllers.c,188,style,unusedFunction,The function 'getPIControllerSignals' is never used. +dgfirmware/firmware/App/Services/PIControllers.c,190,style,unusedFunction,The function 'getPIControllerSignals' is never used. dgfirmware/firmware/FWCommon/RTC.c,427,style,unusedFunction,The function 'getRTCTimestamp' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,433,style,unusedFunction,The function 'getServiceDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,530,style,unusedFunction,The function 'getTreatmentTime' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,569,style,unusedFunction,The function 'getWaterConsumption' is never used. +dgfirmware/firmware/App/Services/SystemCommMessages.c,1106,style,unusedFunction,The function 'handleSetROPumpPWM' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,14,style,unusedFunction,The function 'initFans' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,280,style,unusedFunction,The function 'initNVDataMgmt' is never used. dgfirmware/firmware/App/Services/AlarmMgmt.c,253,style,unusedFunction,The function 'isAlarmActive' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,179,style,unusedFunction,The function 'isPOSTCompleted' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,193,style,unusedFunction,The function 'isPOSTPassed' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,181,style,unusedFunction,The function 'isPOSTCompleted' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,195,style,unusedFunction,The function 'isPOSTPassed' is never used. dgfirmware/firmware/App/Drivers/Comm.c,274,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. dgfirmware/firmware/App/Drivers/SafetyShutdown.c,74,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. dgfirmware/firmware/App/Services/Interrupts.c,93,style,unusedFunction,The function 'phantomInterrupt' is never used. @@ -70,13 +74,19 @@ dgfirmware/firmware/FWCommon/NVDataMgmt.c,407,style,unusedFunction,The function 'setServiceDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,505,style,unusedFunction,The function 'setTreatmentTime' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,545,style,unusedFunction,The function 'setWaterConsumption' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,29,style,unusedFunction,The function 'startFan1' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,36,style,unusedFunction,The function 'startFan2' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,230,style,unusedFunction,The function 'stopDrainCmd' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,41,style,unusedFunction,The function 'stopFan1' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,45,style,unusedFunction,The function 'stopFan2' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,179,style,unusedFunction,The function 'stopFillCmd' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,378,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,472,style,unusedFunction,The function 'testResetReservoirDrainVolumeMlOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,425,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,830,style,unusedFunction,The function 'testResetTargetROPumpFlowRateOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,356,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,449,style,unusedFunction,The function 'testSetReservoirDrainVolumeMlOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,402,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,806,style,unusedFunction,The function 'testSetTargetROPumpFlowRateOverride' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,456,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)