Index: firmware/App/Modes/ModeTreatmentParams.c =================================================================== diff -u -r7b823539be3fde41aa676263188d1af679b2f411 -r1a685471524555a374854c0c9ec8e208e71fe2df --- firmware/App/Modes/ModeTreatmentParams.c (.../ModeTreatmentParams.c) (revision 7b823539be3fde41aa676263188d1af679b2f411) +++ firmware/App/Modes/ModeTreatmentParams.c (.../ModeTreatmentParams.c) (revision 1a685471524555a374854c0c9ec8e208e71fe2df) @@ -8,7 +8,7 @@ * @file ModeTreatmentParams.c * * @author (last) Sean Nash -* @date (last) 10-Sep-2020 +* @date (last) 14-Oct-2020 * * @author (original) Sean Nash * @date (original) 29-May-2020 @@ -102,9 +102,8 @@ /*********************************************************************//** * @brief * The initOpParamsMode function initializes the Operating Parameters Mode module. - * @details - * Inputs : none - * Outputs : Operating Parameters Mode module initialized. + * @details Inputs: none + * @details Outputs: Operating Parameters Mode module initialized. * @return none *************************************************************************/ void initTreatParamsMode( void ) @@ -116,9 +115,8 @@ * @brief * The transitionToOpParamsMode function prepares for transition to operating * parameters mode. - * @details - * Inputs : none - * Outputs : Treatment Parameters mode reset prior to starting + * @details Inputs: none + * @details Outputs: Treatment Parameters mode reset prior to starting * @return none *************************************************************************/ void transitionToTreatParamsMode( void ) @@ -144,9 +142,8 @@ * @brief * The resetAllTreatmentParameters function resets treatment parameters * to default values. - * @details - * Inputs : none - * Outputs : All treatment parameters reset to default values. + * @details Inputs: none + * @details Outputs: All treatment parameters reset to default values. * @return none *************************************************************************/ static void resetAllTreatmentParameters( void ) @@ -183,9 +180,8 @@ * @brief * The signalUserConfirmationOfTreatmentParameters function sets the user * confirmation flag signaling user has confirmed treatment parameters. - * @details - * Inputs : none - * Outputs : treatParamsConfirmed + * @details Inputs: none + * @details Outputs: treatParamsConfirmed * @return TRUE if confirmation accepted, FALSE if not *************************************************************************/ BOOL signalUserConfirmationOfTreatmentParameters( void ) @@ -227,9 +223,8 @@ * @brief * The signalUserCancelTreatment function sets the cancelled treatment * flag signaling the user has cancelled the treatment. - * @details - * Inputs : none - * Outputs : treatmentCancelled + * @details Inputs: none + * @details Outputs: treatmentCancelled * @return TRUE if cancel accepted, FALSE if not *************************************************************************/ BOOL signalUserCancelTreatment( void ) @@ -249,9 +244,8 @@ /*********************************************************************//** * @brief * The execFaultMode function executes the Operating Parameters Mode state machine. - * @details - * Inputs : treatParamsState - * Outputs : treatParamsState + * @details Inputs: treatParamsState + * @details Outputs: treatParamsState * @return current state (sub-mode) *************************************************************************/ U32 execTreatParamsMode( void ) @@ -293,9 +287,8 @@ * @brief * The handleWaitForUI2SendState function handles the wait for UI to send * treatment parameters state of treatment parameters mode. - * @details - * Inputs : - * Outputs : + * @details Inputs: + * @details Outputs: * @return current state (sub-mode) *************************************************************************/ static HD_TREATMENT_PARAMS_MODE_STATE_T handleWaitForUI2SendState( void ) @@ -324,9 +317,8 @@ * @brief * The handleWaitForUI2ConfirmState function handles the wait for UI to send * user confirmation state of treatment parameters mode. - * @details - * Inputs : - * Outputs : + * @details Inputs: + * @details Outputs: * @return current state (sub-mode) *************************************************************************/ static HD_TREATMENT_PARAMS_MODE_STATE_T handleWaitForUI2ConfirmState( void ) @@ -381,9 +373,8 @@ * @brief * The validateAndSetTreatmentParameters function validates received * treatment parameters. - * @details - * Inputs : none - * Outputs : stagedParams[], response sent + * @details Inputs: none + * @details Outputs: stagedParams[], response sent * @param params payload record from treatment parameters message received from UI * @return TRUE if received treatment parameters are valid, FALSE if not *************************************************************************/ @@ -419,9 +410,8 @@ * @brief * The checkTreatmentParamsInRange function checks whether received * treatment parameters are in range. - * @details - * Inputs : stagedParams[] - * Outputs : reasons[] + * @details Inputs: stagedParams[] + * @details Outputs: reasons[] * @param reasons Pointer to array of reject reason codes for each parameter * @return TRUE if treatment parameters are in range, FALSE if not *************************************************************************/ @@ -449,9 +439,8 @@ * @brief * The checkTreatmentParamsDependencies function checks dependencies between * received treatment parameters. - * @details - * Inputs : stagedParams[] - * Outputs : reasons[] + * @details Inputs: stagedParams[] + * @details Outputs: reasons[] * @param reasons Pointer to array of reject reason codes for each parameter * @return TRUE if treatment parameter dependencies are ok, FALSE if not *************************************************************************/ @@ -503,9 +492,8 @@ * @brief * The isTreatmentParamInRange function determines whether a given treatment * parameter is in range. - * @details - * Inputs : treatParamsRanges[] - * Outputs : none + * @details Inputs: treatParamsRanges[] + * @details Outputs: none * @param param ID of parameter to check range for * @param value value of parameter to check range for * @return TRUE if given treatment parameter is in range, FALSE if not @@ -551,9 +539,8 @@ * The extractTreatmentParamsFromPayload function extracts the individual * treatment parameters received from the UI into a staging array where * they will be validated and stay until user confirms them. - * @details - * Inputs : none - * Outputs : stagedParams[] + * @details Inputs: none + * @details Outputs: stagedParams[] * @param payload message payload record containing received treatment parameters * @return none *************************************************************************/ @@ -588,9 +575,8 @@ * @brief * The setTreatmentParameterU32 function sets a given unsigned integer * treatment parameter to a given value. - * @details - * Inputs : treatmentParameters[] - * Outputs : treatmentParameters[] + * @details Inputs: treatmentParameters[] + * @details Outputs: treatmentParameters[] * @param param ID of treatment parameter to set unsigned integer value for * @param value unsigned integer value to assign to given treatment parameter * @return TRUE if set was successful, FALSE if not @@ -619,9 +605,8 @@ * @brief * The setTreatmentParameterS32 function sets a given signed integer treatment * parameter to a given value. - * @details - * Inputs : treatmentParameters[] - * Outputs : treatmentParameters[] + * @details Inputs: treatmentParameters[] + * @details Outputs: treatmentParameters[] * @param param ID of treatment parameter to set signed integer value for * @param value signed integer value to assign to given treatment parameter * @return TRUE if set was successful, FALSE if not @@ -650,9 +635,8 @@ * @brief * The setTreatmentParameterF32 sets a given floating point treatment parameter * to a given value. - * @details - * Inputs : treatmentParameters[] - * Outputs : treatmentParameters[] + * @details Inputs: treatmentParameters[] + * @details Outputs: treatmentParameters[] * @param param ID of treatment parameter to set floating point value for * @param value floating point value to assign to given treatment parameter * @return TRUE if set was successful, FALSE if not @@ -681,15 +665,14 @@ * @brief * The getTreatmentParameterU32 function gets the value of a given unsigned * integer treatment parameter. - * @details - * Inputs : treatmentParameters[] - * Outputs : none + * @details Inputs: treatmentParameters[] + * @details Outputs: none * @param param ID of treatment parameter to get unsigned integer value for * @return value of given unsigned integer treatment parameter *************************************************************************/ U32 getTreatmentParameterU32( TREATMENT_PARAM_T param ) { - U32 result = 0; + U32 result = 1; // validate parameter if ( param <= TREATMENT_PARAM_LAST_UINT ) @@ -710,15 +693,14 @@ * @brief * The getTreatmentParameterS32 function gets the value of a given signed * integer treatment parameter. - * @details - * Inputs : treatmentParameters[] - * Outputs : none + * @details Inputs: treatmentParameters[] + * @details Outputs: none * @param param ID of treatment parameter to get signed integer value for * @return value of given signed integer treatment parameter *************************************************************************/ S32 getTreatmentParameterS32( TREATMENT_PARAM_T param ) { - S32 result = 0; + S32 result = 1; // validate parameter if ( ( param >= TREATMENT_PARAM_FIRST_INT ) && ( param <= TREATMENT_PARAM_LAST_INT ) ) @@ -739,15 +721,14 @@ * @brief * The getTreatmentParameterF32 function gets the value of a given floating point * treatment parameter. - * @details - * Inputs : treatmentParameters[] - * Outputs : none + * @details Inputs: treatmentParameters[] + * @details Outputs: none * @param param ID of treatment parameter to get floating point value for * @return value of given floating point treatment parameter *************************************************************************/ F32 getTreatmentParameterF32( TREATMENT_PARAM_T param ) { - F32 result = 0.0; + F32 result = 1.0; // validate parameter if ( ( param >= TREATMENT_PARAM_FIRST_F32 ) && ( param < NUM_OF_TREATMENT_PARAMS ) ) @@ -774,9 +755,8 @@ * @brief * The testSetTreatmentParameterOverride function overrides the value of a * given treatment parameter. - * @details - * Inputs : none - * Outputs : treatment parameter set to given value + * @details Inputs: none + * @details Outputs: treatment parameter set to given value * @param param ID of treatment parameter to set value of * @param value value to set for given treatment parameter * @return TRUE if override successful, FALSE if not