Index: results/cppcheckError.csv =================================================================== diff -u -r1a685471524555a374854c0c9ec8e208e71fe2df -r6733463d7498c5d81709629fa0952c543da3619d --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 1a685471524555a374854c0c9ec8e208e71fe2df) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 6733463d7498c5d81709629fa0952c543da3619d) @@ -1,85 +1,9 @@ File, Line No., Severity, Issue, Description -<<<<<<< HEAD -hdfirmware/firmware/App/Modes/ModePreTreat.c,82,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModeTreatment.c,742,style,unreadVariable,Variable 'dialysisState' is assigned a value that is never used. -hdfirmware/firmware/App/Services/Interrupts.c,180,style,variableScope,The scope of the variable 'debugStr' can be reduced. -hdfirmware/firmware/App/Services/SystemCommMessages.c,1309,style,unreadVariable,Variable 'result' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1568,style,variableScope,The scope of the variable 'quotient' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1569,style,variableScope,The scope of the variable 'modulus' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1572,style,variableScope,The scope of the variable 'i' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,1221,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/FWCommon/RTC.c,796,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,797,style,variableScope,The scope of the variable 'decimalLow' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,718,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/Utilities.c,246,style,variableScope,The scope of the variable 'timeInMS' can be reduced. -hdfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used. -hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. -hdfirmware/firmware/App/Drivers/InternalADC.c,117,style,unusedFunction,The function 'adcNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,177,style,unusedFunction,The function 'canErrorNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,156,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,645,style,unusedFunction,The function 'cmdDGSampleWater' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,548,style,unusedFunction,The function 'cmdStopDG' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,322,style,unusedFunction,The function 'dmaGroupANotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,369,style,unusedFunction,The function 'edgeNotification' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,356,style,unusedFunction,The function 'execPresOcclTest' is never used. -hdfirmware/firmware/FWCommon/Accel.c,680,style,unusedFunction,The function 'getAccelCalibration' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,1384,style,unusedFunction,The function 'getBloodFlowCalibration' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,399,style,unusedFunction,The function 'getBloodPumpRotorCount' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,743,style,unusedFunction,The function 'getBootloaderFlag' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,489,style,unusedFunction,The function 'getCurrentAlarmStatePriority' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,365,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,308,style,unusedFunction,The function 'getDGPressure' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,349,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,333,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,1330,style,unusedFunction,The function 'getDialInFlowCalibration' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,611,style,unusedFunction,The function 'getDisinfectionDate' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1642,style,unusedFunction,The function 'getFPGAAirTrapLevels' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1131,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1163,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1195,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,336,style,unusedFunction,The function 'getMfgData' is never used. -hdfirmware/firmware/App/Services/PIControllers.c,192,style,unusedFunction,The function 'getPIControllerSignals' is never used. -hdfirmware/firmware/FWCommon/RTC.c,427,style,unusedFunction,The function 'getRTCTimestamp' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,433,style,unusedFunction,The function 'getServiceDate' is never used. -hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,719,style,unusedFunction,The function 'getTreatmentParameterS32' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,530,style,unusedFunction,The function 'getTreatmentTime' is never used. -hdfirmware/firmware/App/Controllers/Valves.c,324,style,unusedFunction,The function 'getValvePosition' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,569,style,unusedFunction,The function 'getWaterConsumption' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,474,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,205,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,219,style,unusedFunction,The function 'isPOSTPassed' is never used. -hdfirmware/firmware/App/Drivers/Comm.c,279,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -hdfirmware/firmware/App/Drivers/SafetyShutdown.c,79,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,242,style,unusedFunction,The function 'isUICommunicating' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,97,style,unusedFunction,The function 'phantomInterrupt' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,481,style,unusedFunction,The function 'readLogData' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,120,style,unusedFunction,The function 'rtiNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,251,style,unusedFunction,The function 'sciNotification' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,721,style,unusedFunction,The function 'setBootloaderFlag' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,424,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,585,style,unusedFunction,The function 'setDisinfectionDate' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,318,style,unusedFunction,The function 'setMfgData' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,118,style,unusedFunction,The function 'setOcclusionThreshold' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,407,style,unusedFunction,The function 'setServiceDate' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,505,style,unusedFunction,The function 'setTreatmentTime' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,545,style,unusedFunction,The function 'setWaterConsumption' is never used. -hdfirmware/firmware/App/Modes/ModePreTreat.c,108,style,unusedFunction,The function 'signalUserBeginningTreatment' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,456,style,unusedFunction,The function 'writeLogData' is never used. -======= -hdfirmware/firmware/App/Controllers/BloodFlow.c,790,style,unreadVariable,Variable 'flowStPt' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,792,style,unreadVariable,Variable 'measRotSpd' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,793,style,unreadVariable,Variable 'measSpd' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,794,style,unreadVariable,Variable 'measMCSpd' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,795,style,unreadVariable,Variable 'measMCCurr' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,796,style,unreadVariable,Variable 'pumpPWMPctDutyCycle' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/Dialysis.c,309,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/Dialysis.c,359,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePostTreat.c,86,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePreTreat.c,80,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModeTreatment.c,741,style,unreadVariable,Variable 'dialysisState' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePostTreat.c,74,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePreTreat.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModeTreatment.c,733,style,unreadVariable,Variable 'dialysisState' is assigned a value that is never used. hdfirmware/firmware/App/Services/Interrupts.c,175,style,variableScope,The scope of the variable 'debugStr' can be reduced. -hdfirmware/firmware/App/Services/SystemCommMessages.c,1312,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/App/Services/SystemCommMessages.c,1306,style,unreadVariable,Variable 'result' is assigned a value that is never used. hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. hdfirmware/firmware/FWCommon/NVDataMgmt.c,1526,style,variableScope,The scope of the variable 'quotient' can be reduced. hdfirmware/firmware/FWCommon/NVDataMgmt.c,1527,style,variableScope,The scope of the variable 'modulus' can be reduced. @@ -88,43 +12,43 @@ hdfirmware/firmware/FWCommon/RTC.c,782,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. hdfirmware/firmware/FWCommon/RTC.c,783,style,variableScope,The scope of the variable 'decimalLow' can be reduced. hdfirmware/firmware/FWCommon/RTC.c,706,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/Utilities.c,212,style,variableScope,The scope of the variable 'timeInMS' can be reduced. +hdfirmware/firmware/FWCommon/Utilities.c,242,style,variableScope,The scope of the variable 'timeInMS' can be reduced. hdfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used. hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. hdfirmware/firmware/App/Drivers/InternalADC.c,115,style,unusedFunction,The function 'adcNotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,172,style,unusedFunction,The function 'canErrorNotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,152,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/FWCommon/PersistentAlarm.c,94,style,unusedFunction,The function 'checkPersistentAlarm' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,616,style,unusedFunction,The function 'cmdDGSampleWater' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,525,style,unusedFunction,The function 'cmdStopDG' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,619,style,unusedFunction,The function 'cmdDGSampleWater' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,528,style,unusedFunction,The function 'cmdStopDG' is never used. hdfirmware/firmware/App/Services/Interrupts.c,315,style,unusedFunction,The function 'dmaGroupANotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,361,style,unusedFunction,The function 'edgeNotification' is never used. hdfirmware/firmware/App/Controllers/AirTrap.c,207,style,unusedFunction,The function 'execAirTrapMonitorPriming' is never used. hdfirmware/firmware/App/Controllers/AirTrap.c,441,style,unusedFunction,The function 'execAirTrapTest' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,371,style,unusedFunction,The function 'execPresOcclTest' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,340,style,unusedFunction,The function 'execPresOcclTest' is never used. hdfirmware/firmware/FWCommon/Accel.c,665,style,unusedFunction,The function 'getAccelCalibration' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,1222,style,unusedFunction,The function 'getBloodFlowCalibration' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,1350,style,unusedFunction,The function 'getBloodFlowCalibration' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,394,style,unusedFunction,The function 'getBloodPumpRotorCount' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,724,style,unusedFunction,The function 'getBootloaderFlag' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,352,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,298,style,unusedFunction,The function 'getDGPressure' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,337,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,322,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,1193,style,unusedFunction,The function 'getDialInFlowCalibration' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,481,style,unusedFunction,The function 'getCurrentAlarmStatePriority' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,355,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,301,style,unusedFunction,The function 'getDGPressure' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,340,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,325,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,1296,style,unusedFunction,The function 'getDialInFlowCalibration' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getDisinfectionDate' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1130,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1162,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1194,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1131,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1163,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1195,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,332,style,unusedFunction,The function 'getMfgData' is never used. hdfirmware/firmware/App/Services/PIControllers.c,192,style,unusedFunction,The function 'getPIControllerSignals' is never used. hdfirmware/firmware/FWCommon/RTC.c,422,style,unusedFunction,The function 'getRTCTimestamp' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,425,style,unusedFunction,The function 'getServiceDate' is never used. -hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,669,style,unusedFunction,The function 'getTreatmentParameterS32' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,701,style,unusedFunction,The function 'getTreatmentParameterS32' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,518,style,unusedFunction,The function 'getTreatmentTime' is never used. hdfirmware/firmware/App/Controllers/Valves.c,343,style,unusedFunction,The function 'getValvePosition' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,555,style,unusedFunction,The function 'getWaterConsumption' is never used. -hdfirmware/firmware/FWCommon/PersistentAlarm.c,60,style,unusedFunction,The function 'initPersistentAlarm' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,460,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,476,style,unusedFunction,The function 'isAlarmRecoverable' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,466,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,495,style,unusedFunction,The function 'isAlarmRecoverable' is never used. hdfirmware/firmware/App/Modes/ModeInitPOST.c,202,style,unusedFunction,The function 'isPOSTCompleted' is never used. hdfirmware/firmware/App/Modes/ModeInitPOST.c,215,style,unusedFunction,The function 'isPOSTPassed' is never used. hdfirmware/firmware/App/Drivers/Comm.c,263,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. @@ -135,14 +59,12 @@ hdfirmware/firmware/App/Services/Interrupts.c,117,style,unusedFunction,The function 'rtiNotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,245,style,unusedFunction,The function 'sciNotification' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,703,style,unusedFunction,The function 'setBootloaderFlag' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,408,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,411,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,570,style,unusedFunction,The function 'setDisinfectionDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,315,style,unusedFunction,The function 'setMfgData' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,147,style,unusedFunction,The function 'setOcclusionThreshold' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,117,style,unusedFunction,The function 'setPressureLimits' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,114,style,unusedFunction,The function 'setOcclusionThreshold' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,400,style,unusedFunction,The function 'setServiceDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,494,style,unusedFunction,The function 'setTreatmentTime' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,532,style,unusedFunction,The function 'setWaterConsumption' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,447,style,unusedFunction,The function 'writeLogData' is never used. ->>>>>>> master ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)