Index: results/cppcheckError.csv =================================================================== diff -u -r609937ae79b4b77a0bd9ac180d38425b0b6922fb -rfe01fd0124c0c43737474781730608d55d0f0bda --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 609937ae79b4b77a0bd9ac180d38425b0b6922fb) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision fe01fd0124c0c43737474781730608d55d0f0bda) @@ -1,44 +1,42 @@ -hdfirmware/firmware/App/Controllers/BloodFlow.c,218,style,unreadVariable,Variable 'tmp' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/RTC.c,1158,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/App/Controllers/RTC.c,229,style,unreadVariable,Variable 'decimalSeconds' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/RTC.c,230,style,unreadVariable,Variable 'decimalMins' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/RTC.c,231,style,unreadVariable,Variable 'decimalHours' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/RTC.c,232,style,unreadVariable,Variable 'decimalDays' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/RTC.c,233,style,unreadVariable,Variable 'decimalMonths' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/RTC.c,234,style,unreadVariable,Variable 'decimalYears' is assigned a value that is never used. +File, Line No., Severity, Issue, Description +hdfirmware/firmware/App/Controllers/RTC.c,1140,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +hdfirmware/firmware/App/Controllers/RTC.c,655,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +hdfirmware/firmware/App/Services/Interrupts.c,100,style,variableScope,The scope of the variable 'debugStr' can be reduced. +hdfirmware/firmware/App/Services/PIControllers.c,67,style,variableScope,The scope of the variable 'controller' can be reduced. hdfirmware/firmware/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,221,style,unusedFunction,The function 'activateAlarm1Data' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,244,style,unusedFunction,The function 'activateAlarm2Data' is never used. -hdfirmware/firmware/App/Drivers/SafetyShutdown.c,54,style,unusedFunction,The function 'activateSafetyShutdown' is never used. -hdfirmware/firmware/App/Drivers/InternalADC.c,113,style,unusedFunction,The function 'adcNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,49,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,264,style,unusedFunction,The function 'clearAlarm' is never used. -hdfirmware/firmware/App/Services/Utilities.c,121,style,unusedFunction,The function 'crc8' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,89,style,unusedFunction,The function 'dmaGroupANotification' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,143,style,unusedFunction,The function 'execAlarmMgmt' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,238,style,unusedFunction,The function 'execBloodFlowController' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,201,style,unusedFunction,The function 'execBloodFlowMonitor' is never used. -hdfirmware/firmware/App/Services/FPGA.c,351,style,unusedFunction,The function 'execFPGAIn' is never used. -hdfirmware/firmware/App/Services/FPGA.c,405,style,unusedFunction,The function 'execFPGAOut' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,114,style,unusedFunction,The function 'execSystemCommRx' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,133,style,unusedFunction,The function 'execSystemCommTx' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,525,style,unusedFunction,The function 'getDataFromRAM' is never used. -hdfirmware/firmware/App/Services/FPGA.c,830,style,unusedFunction,The function 'getFPGAId' is never used. -hdfirmware/firmware/App/Services/FPGA.c,845,style,unusedFunction,The function 'getFPGARev' is never used. -hdfirmware/firmware/App/Services/FPGA.c,860,style,unusedFunction,The function 'getFPGAStatus' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,489,style,unusedFunction,The function 'getRTCRAMState' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,504,style,unusedFunction,The function 'getRTCRAMStatus' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,368,style,unusedFunction,The function 'getRTCTimestamp' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,302,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,178,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,193,style,unusedFunction,The function 'isPOSTPassed' is never used. -hdfirmware/firmware/App/Drivers/Comm.c,176,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,439,style,unusedFunction,The function 'readFromRAM' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,65,style,unusedFunction,The function 'sciNotification' is never used. -hdfirmware/firmware/App/Services/FPGA.c,874,style,unusedFunction,The function 'setFPGAControl' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,225,style,unusedFunction,The function 'setRTCTimestamp' is never used. -hdfirmware/firmware/App/Tasks/TaskGeneral.c,44,style,unusedFunction,The function 'taskGeneral' is never used. -hdfirmware/firmware/App/Tasks/TaskPriority.c,34,style,unusedFunction,The function 'taskPriority' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,254,style,unusedFunction,The function 'activateAlarm1Data' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,277,style,unusedFunction,The function 'activateAlarm2Data' is never used. +hdfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,96,style,unusedFunction,The function 'canErrorNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,75,style,unusedFunction,The function 'canMessageNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,230,style,unusedFunction,The function 'dmaGroupANotification' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,815,style,unusedFunction,The function 'execBloodFlowTest' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,815,style,unusedFunction,The function 'execDialInFlowTest' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,202,style,unusedFunction,The function 'execSystemCommRx' is never used. +hdfirmware/firmware/App/Controllers/RTC.c,518,style,unusedFunction,The function 'getDataFromRAM' is never used. +hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAId' is never used. +hdfirmware/firmware/App/Services/FPGA.c,854,style,unusedFunction,The function 'getFPGARev' is never used. +hdfirmware/firmware/App/Services/FPGA.c,869,style,unusedFunction,The function 'getFPGAStatus' is never used. +hdfirmware/firmware/App/Services/PIControllers.c,167,style,unusedFunction,The function 'getPIControllerSignals' is never used. +hdfirmware/firmware/App/Controllers/RTC.c,482,style,unusedFunction,The function 'getRTCRAMState' is never used. +hdfirmware/firmware/App/Controllers/RTC.c,497,style,unusedFunction,The function 'getRTCRAMStatus' is never used. +hdfirmware/firmware/App/Controllers/RTC.c,371,style,unusedFunction,The function 'getRTCTimestamp' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,335,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,151,style,unusedFunction,The function 'isDGCommunicating' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,170,style,unusedFunction,The function 'isPOSTCompleted' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,185,style,unusedFunction,The function 'isPOSTPassed' is never used. +hdfirmware/firmware/App/Drivers/Comm.c,273,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,170,style,unusedFunction,The function 'isUICommunicating' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used. +hdfirmware/firmware/App/Controllers/RTC.c,436,style,unusedFunction,The function 'readFromRAM' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,183,style,unusedFunction,The function 'setDialInPumpTargetFlowRate' is never used. +hdfirmware/firmware/App/Services/FPGA.c,883,style,unusedFunction,The function 'setFPGAControl' is never used. +hdfirmware/firmware/App/Controllers/RTC.c,233,style,unusedFunction,The function 'setRTCTimestamp' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,246,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,247,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. +hdfirmware/firmware/App/Tasks/TaskGeneral.c,48,style,unusedFunction,The function 'taskGeneral' is never used. +hdfirmware/firmware/App/Tasks/TaskPriority.c,36,style,unusedFunction,The function 'taskPriority' is never used. hdfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,385,style,unusedFunction,The function 'writeToRAM' is never used. +hdfirmware/firmware/App/Controllers/RTC.c,388,style,unusedFunction,The function 'writeToRAM' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)