Index: results/cppcheckError.csv =================================================================== diff -u -rf9890311898663a704692870ffb53d43cea0d20b -rfdac5a7b77b4042f341b16fe5fccf160d0447879 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision f9890311898663a704692870ffb53d43cea0d20b) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision fdac5a7b77b4042f341b16fe5fccf160d0447879) @@ -1,47 +1,66 @@ File, Line No., Severity, Issue, Description -hdfirmware/firmware/App/Services/Interrupts.c,100,style,variableScope,The scope of the variable 'debugStr' can be reduced. -hdfirmware/firmware/App/Services/PIControllers.c,77,style,variableScope,The scope of the variable 'controller' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,1197,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/FWCommon/RTC.c,695,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -hdfirmware/firmware/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,278,style,unusedFunction,The function 'activateAlarm1Data' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,301,style,unusedFunction,The function 'activateAlarm2Data' is never used. +hdfirmware/firmware/App/Modes/ModeOpParams.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePostTreat.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePreTreat.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePrescription.c,82,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModeTreatment.c,144,style,unusedVariable,Unused variable: elapsedTreatmentTimeInSecs +hdfirmware/firmware/App/Services/Interrupts.c,101,style,variableScope,The scope of the variable 'debugStr' can be reduced. +hdfirmware/firmware/App/Services/PIControllers.c,81,style,variableScope,The scope of the variable 'controller' can be reduced. +hdfirmware/firmware/App/Services/SystemCommMessages.c,368,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/FWCommon/FlashDriver/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1582,style,variableScope,The scope of the variable 'quotient' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1583,style,variableScope,The scope of the variable 'modulus' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1586,style,variableScope,The scope of the variable 'i' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,1203,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +hdfirmware/firmware/FWCommon/RTC.c,776,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,777,style,variableScope,The scope of the variable 'decimalLow' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,698,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +hdfirmware/firmware/FWCommon/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. +hdfirmware/firmware/FWCommon/FlashDriver/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. +hdfirmware/firmware/App/Drivers/SafetyShutdown.c,54,style,unusedFunction,The function 'activateSafetyShutdown' is never used. hdfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,96,style,unusedFunction,The function 'canErrorNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,75,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,230,style,unusedFunction,The function 'dmaGroupANotification' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,847,style,unusedFunction,The function 'execBloodFlowTest' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,831,style,unusedFunction,The function 'execDialInFlowTest' is never used. -hdfirmware/firmware/App/Modes/Dialysis.c,60,style,unusedFunction,The function 'execDialysis' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,389,style,unusedFunction,The function 'execPresOcclTest' is never used. -hdfirmware/firmware/App/Modes/TreatmentStop.c,62,style,unusedFunction,The function 'execTreatmentStop' is never used. -hdfirmware/firmware/FWCommon/RTC.c,558,style,unusedFunction,The function 'getDataFromRAM' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,97,style,unusedFunction,The function 'canErrorNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,76,style,unusedFunction,The function 'canMessageNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,228,style,unusedFunction,The function 'dmaGroupANotification' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,879,style,unusedFunction,The function 'execBloodFlowTest' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,863,style,unusedFunction,The function 'execDialInFlowTest' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,376,style,unusedFunction,The function 'execPresOcclTest' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,723,style,unusedFunction,The function 'getBootloaderFlag' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,365,style,unusedFunction,The function 'getCalibrationData' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,593,style,unusedFunction,The function 'getDisinfectionDate' is never used. hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAId' is never used. hdfirmware/firmware/App/Services/FPGA.c,854,style,unusedFunction,The function 'getFPGARev' is never used. hdfirmware/firmware/App/Services/FPGA.c,869,style,unusedFunction,The function 'getFPGAStatus' is never used. -hdfirmware/firmware/App/Services/PIControllers.c,206,style,unusedFunction,The function 'getPIControllerSignals' is never used. -hdfirmware/firmware/FWCommon/RTC.c,522,style,unusedFunction,The function 'getRTCRAMState' is never used. -hdfirmware/firmware/FWCommon/RTC.c,537,style,unusedFunction,The function 'getRTCRAMStatus' is never used. -hdfirmware/firmware/FWCommon/RTC.c,411,style,unusedFunction,The function 'getRTCTimestamp' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,359,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,212,style,unusedFunction,The function 'isDGCommunicating' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,170,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,185,style,unusedFunction,The function 'isPOSTPassed' is never used. -hdfirmware/firmware/App/Drivers/Comm.c,273,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,231,style,unusedFunction,The function 'isUICommunicating' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used. -hdfirmware/firmware/FWCommon/RTC.c,476,style,unusedFunction,The function 'readFromRAM' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,184,style,unusedFunction,The function 'setDialInPumpTargetFlowRate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,320,style,unusedFunction,The function 'getMfgData' is never used. +hdfirmware/firmware/App/Services/PIControllers.c,210,style,unusedFunction,The function 'getPIControllerSignals' is never used. +hdfirmware/firmware/FWCommon/RTC.c,416,style,unusedFunction,The function 'getRTCTimestamp' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,414,style,unusedFunction,The function 'getServiceDate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,511,style,unusedFunction,The function 'getTreatmentTime' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,551,style,unusedFunction,The function 'getWaterConsumption' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,373,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,228,style,unusedFunction,The function 'isDGCommunicating' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,182,style,unusedFunction,The function 'isPOSTCompleted' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,197,style,unusedFunction,The function 'isPOSTPassed' is never used. +hdfirmware/firmware/App/Drivers/Comm.c,289,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,247,style,unusedFunction,The function 'isUICommunicating' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,61,style,unusedFunction,The function 'phantomInterrupt' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,461,style,unusedFunction,The function 'readLogData' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,159,style,unusedFunction,The function 'sciNotification' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,700,style,unusedFunction,The function 'setBootloaderFlag' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,345,style,unusedFunction,The function 'setCalibrationData' is never used. hdfirmware/firmware/App/Services/FPGA.c,883,style,unusedFunction,The function 'setFPGAControl' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,143,style,unusedFunction,The function 'setOcclusionThreshold' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,112,style,unusedFunction,The function 'setPressureLimits' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,247,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,248,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. -hdfirmware/firmware/App/Tasks/TaskGeneral.c,49,style,unusedFunction,The function 'taskGeneral' is never used. -hdfirmware/firmware/App/Tasks/TaskPriority.c,36,style,unusedFunction,The function 'taskPriority' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,302,style,unusedFunction,The function 'setMfgData' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,142,style,unusedFunction,The function 'setOcclusionThreshold' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,111,style,unusedFunction,The function 'setPressureLimits' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,388,style,unusedFunction,The function 'setServiceDate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,485,style,unusedFunction,The function 'setTreatmentTime' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,526,style,unusedFunction,The function 'setWaterConsumption' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,253,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,254,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. +hdfirmware/firmware/App/Controllers/DialOutFlow.c,286,style,unusedFunction,The function 'signalDialOutPumpHardStop' is never used. +hdfirmware/firmware/App/Tasks/TaskGeneral.c,50,style,unusedFunction,The function 'taskGeneral' is never used. +hdfirmware/firmware/App/Tasks/TaskPriority.c,37,style,unusedFunction,The function 'taskPriority' is never used. hdfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used. -hdfirmware/firmware/App/Modes/Dialysis.c,47,style,unusedFunction,The function 'transitionToDialysis' is never used. -hdfirmware/firmware/App/Modes/TreatmentStop.c,48,style,unusedFunction,The function 'transitionToTreatmentStop' is never used. -hdfirmware/firmware/FWCommon/RTC.c,428,style,unusedFunction,The function 'writeToRAM' is never used. +hdfirmware/firmware/App/Modes/Dialysis.c,116,style,unusedFunction,The function 'transitionToDialysis' is never used. +hdfirmware/firmware/App/Modes/TreatmentStop.c,53,style,unusedFunction,The function 'transitionToTreatmentStop' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)