Index: etc/reports/cppcheck/cppcheck.err =================================================================== diff -u -ra245272e6d8eee5c3658245570b6d31bd039af74 -r712f4c8a1b2382919300895b4422b831471044a3 --- etc/reports/cppcheck/cppcheck.err (.../cppcheck.err) (revision a245272e6d8eee5c3658245570b6d31bd039af74) +++ etc/reports/cppcheck/cppcheck.err (.../cppcheck.err) (revision 712f4c8a1b2382919300895b4422b831471044a3) @@ -1,5 +1,5 @@ -05/08/2025 11:05 -Tiffany Mejia +06/10/2025 18:50 +Behrouz NematiPour /home/denali/Public/luis/application/sources/canbus/MessageAcknowModel.h:58:9: performance: When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning '_sequence' a value by passing the value to the constructor in the initialization list. [useInitializationList] _sequence = vSequence ; ^ @@ -93,8 +93,8 @@ When you see this message it is always safe to reduce the variable scope 1 level. [variableScope] static int oH,oM,oS; int cH,cM,cS; ^ -/home/denali/Public/luis/application/sources/canbus/MessageInterpreter.cpp:575:9: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] - LOG_APPED(QString("DG,CheckIn," + QVariant(vData).toStringList().join(','))); break; +/home/denali/Public/luis/application/sources/canbus/MessageInterpreter.cpp:582:9: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] + LOG_APPED(QString("DD,CheckIn," + QVariant(vData).toStringList().join(','))); break; ^ /home/denali/Public/luis/application/sources/cloudsync/CloudSyncController.cpp:303:10: style: The if condition is the same as the previous if condition [duplicateCondition] if ( ! ok ) { error = eError_OutFileExist; args = {{ _location }}; ok = false; goto lErr; } @@ -189,6 +189,9 @@ /home/denali/Public/luis/application/sources/model/confirm/MDuetConfirmHDi.h:78:5: warning: Member variable 'MDuetConfirmHDi::_data' is not initialized in the constructor. [uninitMemberVar] MDuetConfirmHDi () { } ^ +/home/denali/Public/luis/application/sources/model/dg/adjustment/settings/MAdjustDDVersionsResponse.h:97:5: warning: Member variable 'MAdjustVersionsDDResponse::_data' is not initialized in the constructor. [uninitMemberVar] + MAdjustVersionsDDResponse () { } + ^ /home/denali/Public/luis/application/sources/model/dg/adjustment/settings/MAdjustDGCleaningUsageResponse.h:99:5: warning: Member variable 'MAdjustDGCleaningUsageResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustDGCleaningUsageResponse () { } ^ @@ -198,9 +201,6 @@ /home/denali/Public/luis/application/sources/model/dg/adjustment/settings/MAdjustDGServiceDatesResponse.h:74:5: warning: Member variable 'MAdjustServiceDatesDGResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustServiceDatesDGResponse () { } ^ -/home/denali/Public/luis/application/sources/model/dg/adjustment/settings/MAdjustDGVersionsResponse.h:97:5: warning: Member variable 'MAdjustVersionsDGResponse::_data' is not initialized in the constructor. [uninitMemberVar] - MAdjustVersionsDGResponse () { } - ^ /home/denali/Public/luis/application/sources/model/dg/adjustment/settings/MDuetRoWaterDG.h:123:5: warning: Member variable 'MDuetRoWaterModeDGr::_data' is not initialized in the constructor. [uninitMemberVar] MDuetRoWaterModeDGr () { } ^ @@ -273,7 +273,7 @@ /home/denali/Public/luis/application/sources/model/hd/adjustment/pretreatment/MPreTreatmentAdjustInitTreatmentResponse.h:75:5: warning: Member variable 'MAdjustInitTreatmentResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustInitTreatmentResponse () {} ^ -/home/denali/Public/luis/application/sources/model/hd/adjustment/pretreatment/MPreTreatmentAdjustParametersValidationResponse.h:121:5: warning: Member variable 'MAdjustParametersValidationResponse::_data' is not initialized in the constructor. [uninitMemberVar] +/home/denali/Public/luis/application/sources/model/hd/adjustment/pretreatment/MPreTreatmentAdjustParametersValidationResponse.h:127:5: warning: Member variable 'MAdjustParametersValidationResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustParametersValidationResponse () {} ^ /home/denali/Public/luis/application/sources/model/hd/adjustment/pretreatment/MPreTreatmentAdjustPatientConnectionBeginResponse.h:77:5: warning: Member variable 'MAdjustPatientConnectionBeginResponse::_data' is not initialized in the constructor. [uninitMemberVar] @@ -306,8 +306,8 @@ /home/denali/Public/luis/application/sources/model/hd/adjustment/settings/MAdjustHDServiceModeResponse.h:74:5: warning: Member variable 'MAdjustServiceModeResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustServiceModeResponse () { } ^ -/home/denali/Public/luis/application/sources/model/hd/adjustment/settings/MAdjustHDVersionsResponse.h:97:5: warning: Member variable 'MAdjustVersionsHDResponse::_data' is not initialized in the constructor. [uninitMemberVar] - MAdjustVersionsHDResponse () { } +/home/denali/Public/luis/application/sources/model/hd/adjustment/settings/MAdjustTDVersionsResponse.h:97:5: warning: Member variable 'MAdjustVersionsTDResponse::_data' is not initialized in the constructor. [uninitMemberVar] + MAdjustVersionsTDResponse () { } ^ /home/denali/Public/luis/application/sources/model/hd/adjustment/treatment/MTreatmentAdjustBloodDialysateResponse.h:81:5: warning: Member variable 'MAdjustBloodDialysateResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustBloodDialysateResponse () { } @@ -360,27 +360,18 @@ /home/denali/Public/luis/application/sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationStateResponse.h:78:5: warning: Member variable 'MAdjustUltrafiltrationStateResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustUltrafiltrationStateResponse() { } ^ -/home/denali/Public/luis/application/sources/model/hd/alarm/MAlarmActiveList.h:130:5: warning: Member variable 'MAlarmActiveListResponse::_data' is not initialized in the constructor. [uninitMemberVar] +/home/denali/Public/luis/application/sources/model/hd/alarm/MAlarmActiveList.h:127:5: warning: Member variable 'MAlarmActiveListResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAlarmActiveListResponse () { } ^ /home/denali/Public/luis/application/sources/model/hd/alarm/MAlarmCleared.h:72:5: warning: Member variable 'MAlarmCleared::_data' is not initialized in the constructor. [uninitMemberVar] MAlarmCleared () { } ^ -/home/denali/Public/luis/application/sources/model/hd/alarm/MAlarmStatusData.h:86:5: warning: Member variable 'MAlarmStatus::_data' is not initialized in the constructor. [uninitMemberVar] +/home/denali/Public/luis/application/sources/model/hd/alarm/MAlarmStatusData.h:83:5: warning: Member variable 'MAlarmStatus::_data' is not initialized in the constructor. [uninitMemberVar] MAlarmStatus() { } ^ /home/denali/Public/luis/application/sources/model/hd/alarm/MAlarmTriggered.h:99:5: warning: Member variable 'MAlarmTriggered::_xata' is not initialized in the constructor. [uninitMemberVar] MAlarmTriggered () { } ^ -/home/denali/Public/luis/application/sources/model/hd/alarm/MAlarmTriggered.h:65:18: style: The function 'parameters' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] - QVariantList parameters() const; - ^ -/home/denali/Public/luis/application/sources/model/MAbstract.h:139:26: note: Virtual function in base class - virtual QVariantList parameters () const = 0; - ^ -/home/denali/Public/luis/application/sources/model/hd/alarm/MAlarmTriggered.h:65:18: note: Function in derived class - QVariantList parameters() const; - ^ /home/denali/Public/luis/application/sources/model/hd/data/MHDAccelerometerData.h:99:5: warning: Member variable 'MHDAccelerometer::_data' is not initialized in the constructor. [uninitMemberVar] MHDAccelerometer () { } ^ @@ -393,15 +384,33 @@ /home/denali/Public/luis/application/sources/model/hd/data/MHDBloodLeakData.h:83:5: warning: Member variable 'MHDBloodLeakData::_data' is not initialized in the constructor. [uninitMemberVar] MHDBloodLeakData () { } ^ -/home/denali/Public/luis/application/sources/model/hd/data/MHDOperationModeData.h:75:5: warning: Member variable 'MHDOperationMode::_data' is not initialized in the constructor. [uninitMemberVar] - MHDOperationMode () {} - ^ /home/denali/Public/luis/application/sources/model/hd/data/MHDSyringePumpData.h:106:5: warning: Member variable 'MHDSyringePump::_data' is not initialized in the constructor. [uninitMemberVar] MHDSyringePump () { } ^ /home/denali/Public/luis/application/sources/model/hd/data/MHDUsageInfoResponse.h:84:5: warning: Member variable 'MHDUsageInfoResponse::_data' is not initialized in the constructor. [uninitMemberVar] MHDUsageInfoResponse () {} ^ +/home/denali/Public/luis/application/sources/model/hd/data/MTDAirTrapData.h:87:5: warning: Member variable 'MTDAirTrapData::_data' is not initialized in the constructor. [uninitMemberVar] + MTDAirTrapData () { } + ^ +/home/denali/Public/luis/application/sources/model/hd/data/MTDBatteryData.h:76:5: warning: Member variable 'MTDBatteryData::_data' is not initialized in the constructor. [uninitMemberVar] + MTDBatteryData () { } + ^ +/home/denali/Public/luis/application/sources/model/hd/data/MTDBloodPumpData.h:96:5: warning: Member variable 'MTDBloodPumpData::_data' is not initialized in the constructor. [uninitMemberVar] + MTDBloodPumpData () { } + ^ +/home/denali/Public/luis/application/sources/model/hd/data/MTDEjectorData.h:75:5: warning: Member variable 'MTDEjectorData::_data' is not initialized in the constructor. [uninitMemberVar] + MTDEjectorData () { } + ^ +/home/denali/Public/luis/application/sources/model/hd/data/MTDSwitchesData.h:72:5: warning: Member variable 'MTDSwitchesData::_data' is not initialized in the constructor. [uninitMemberVar] + MTDSwitchesData () { } + ^ +/home/denali/Public/luis/application/sources/model/hd/data/MTDTemperatureData.h:73:5: warning: Member variable 'MTDTemperatureData::_data' is not initialized in the constructor. [uninitMemberVar] + MTDTemperatureData () { } + ^ +/home/denali/Public/luis/application/sources/model/hd/data/MTDValvesData.h:84:5: warning: Member variable 'MTDValvesData::_data' is not initialized in the constructor. [uninitMemberVar] + MTDValvesData () { } + ^ /home/denali/Public/luis/application/sources/model/hd/data/MTDVoltageData.h:102:5: warning: Member variable 'MTDVoltageData::_data' is not initialized in the constructor. [uninitMemberVar] MTDVoltageData () { } ^ @@ -486,6 +495,9 @@ /home/denali/Public/luis/application/sources/model/settings/MSettings.cpp:91:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] if ( vKey == keyValue.key() ) return keyValue.val(); ^ +/home/denali/Public/luis/application/sources/model/td/data/MTDOpModeData.h:75:5: warning: Member variable 'MTDOpMode::_data' is not initialized in the constructor. [uninitMemberVar] + MTDOpMode () {} + ^ /home/denali/Public/luis/application/sources/storage/Logger.cpp:233:9: style: Condition 'vUseTempPath' is always false [knownConditionTrueFalse] if (vUseTempPath) { ^ @@ -564,10 +576,10 @@ /home/denali/Public/luis/application/sources/view/hd/adjustment/pretreatment/VPreTreatmentAdjustmentPatientConnectionBegin.cpp:49:0: style: The function 'doBegin' is never used. [unusedFunction] ^ -/home/denali/Public/luis/application/sources/view/VTreatmentCreate.cpp:84:0: style: The function 'doCancel' is never used. [unusedFunction] +/home/denali/Public/luis/application/sources/view/VTreatmentCreate.cpp:86:0: style: The function 'doCancel' is never used. [unusedFunction] ^ -/home/denali/Public/luis/application/sources/view/VTreatmentCreate.cpp:73:0: style: The function 'doConfirm' is never used. [unusedFunction] +/home/denali/Public/luis/application/sources/view/VTreatmentCreate.cpp:75:0: style: The function 'doConfirm' is never used. [unusedFunction] ^ /home/denali/Public/luis/application/sources/view/hd/adjustment/treatment/VTreatmentAdjustmentRecirculate.cpp:83:0: style: The function 'doConfirmDisconnect' is never used. [unusedFunction] @@ -732,10 +744,10 @@ /home/denali/Public/luis/application/sources/utility/qrcodegen.cpp:362:0: style: The function 'getVersion' is never used. [unusedFunction] ^ -/home/denali/Public/luis/application/sources/view/hd/alarm/VAlarmStatus.cpp:183:0: style: The function 'instructionKeys' is never used. [unusedFunction] +/home/denali/Public/luis/application/sources/view/hd/alarm/VAlarmStatus.cpp:182:0: style: The function 'instructionKeys' is never used. [unusedFunction] ^ -/home/denali/Public/luis/application/sources/view/hd/alarm/VAlarmStatus.cpp:184:0: style: The function 'instructionValues' is never used. [unusedFunction] +/home/denali/Public/luis/application/sources/view/hd/alarm/VAlarmStatus.cpp:183:0: style: The function 'instructionValues' is never used. [unusedFunction] ^ /home/denali/Public/luis/application/sources/view/settings/VSettings.cpp:237:0: style: The function 'isPasswordValid' is never used. [unusedFunction]