Michael Garthwaite

4 hrs ago

Michael Garthwaite

More
LEAHI-DD-FIRMWARE-LDT-3343-1
resumed reviewing

2:01 pm

Michael Garthwaite

More
e2681be
changed 1 file
LDT-2004-v2-conductivity-sensors in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-4

LDT-2004: comment updates

- -11
- +9
/firmware/App/Drivers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c

1:35 pm

Michael Garthwaite

More
8a7e671
changed 3 files
LDT-2004-v2-conductivity-sensors in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-4

LDT-2004: cal data and read functionality.

- -35
- +357
/firmware/App/Drivers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -1
- +1
/firmware/App/Drivers/ConductivitySensors.h
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.h
- -1
- +1
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

11:54 am

Michael Garthwaite

More
LEAHI-DIALIN-LDT-2004-1
resumed reviewing

8:47 am

Michael Garthwaite

More
82b841c
changed 8 files
LDT-2004-v2-conductivity-sensors in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-4

LDT-2004: data structures and public functions

- -3
- +0
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -754
- +266
/firmware/App/Drivers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -29
- +79
/firmware/App/Drivers/ConductivitySensors.h
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.h
- -1
- +1
/firmware/App/Monitors/Conductivity.h
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.h
- -1
- +1
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c
- -49
- +720
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -91
- +43
/firmware/App/Services/FpgaDD.h
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.h
- -4
- +4
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

11:37 am

Michael Garthwaite

More
3190cb9
changed 2 files
LDT-2004-drybicarb---dd, LDT-2030-blood-leak-refactor---dd and 5 more in dd-firmware

Merge branch 'LDT-2004-dialysate-composition-dd' into staging

- -1
- +1
/firmware/App/Monitors/Conductivity.h
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.h
- -1
- +1
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c

11:37 am

Michael Garthwaite

10:40 am

Michael Garthwaite

More
586ff9f
changed 2 files
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 6 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-1

LDT-2004: fixed Release build configuration build errors.

- -1
- +1
/firmware/App/Monitors/Conductivity.h
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.h
- -1
- +1
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c

10:37 am

Michael Garthwaite

More
LEAHI-DD-FIRMWARE-LDT-2004-1
started review

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD

9:21 am

Michael Garthwaite

More
0eaecff
changed 0 files
LDT-2004-v2-conductivity-sensors in dd-firmware

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

9:18 am

Michael Garthwaite

More
9b633d6
changed 0 files
LDT-2004-drybicarb---dd, LDT-3343-dd-fw-control-stops-iofp-manual and 3 more in leahi-fwcommon

Merge branch 'LDT-2004-dialysate-composition-dd' into staging

9:17 am

Michael Garthwaite

More
ba082ec
changed 0 files
LDT-2004-drybicarb---dd, LDT-2004-v2-dialysate-composition and 3 more in leahi-common

Merge branch 'LDT-2004-dialysate-composition-dd' into staging

9:16 am

Michael Garthwaite

9:16 am

Michael Garthwaite

More
fa6a9e2
changed 1 file
LDT-2004-drybicarb---dd, LDT-2004-v2-conductivity-sensors and 6 more in dd-firmware

Merge branch 'LDT-2004-dialysate-composition-dd' into staging

- -0
- +2
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

2:43 pm

Michael Garthwaite

More
LEAHI-DD-FIRMWARE-LDT-3218-1
finished reviewing

11:55 am

Michael Garthwaite

More
96df0d0
changed 0 files
LDT-2004-v2-conductivity-sensors in dd-firmware

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

11:16 am

Michael Garthwaite

More
253b312
changed 1 file
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 7 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-1

LDT-2004: put back the if def for normal conductivity sensor overrides as they can not be found when the teensy buld switch is enabled.

- -0
- +2
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

10:16 am

Michael Garthwaite

More
007d3a3
changed 0 files
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 4 more in leahi-fwcommon

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

10:15 am

Michael Garthwaite

More
7e10a77
changed 0 files
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 4 more in leahi-common

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

10:15 am

Michael Garthwaite

More
6fbb935
changed 0 files
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 4 more in leahi-common

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

10:15 am

Michael Garthwaite

More
e93982d
changed 2 files
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 7 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-1

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

- -6
- +3
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -16
- +18
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

10:38 am

Michael Garthwaite

More
LEAHI-DD-FIRMWARE-LDT-3160-1
finished reviewing

2:32 pm

Michael Garthwaite

More
4062a59
changed 1 file
LDT-2004-v2-conductivity-sensors in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-4

LDT-2004: first update to DD fpga to be in sync with beta 2.0 FPGA and hardware.

- -1890
- +438
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

1:19 pm

Michael Garthwaite

More
427d252
changed 0 files
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 4 more in leahi-fwcommon

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

1:19 pm

Michael Garthwaite

More
aa94df5
changed 0 files
LDT-2004-v2-conductivity-sensors in dd-firmware

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

1:03 pm

Michael Garthwaite

fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

1:01 pm

Michael Garthwaite

More
c804832
changed 1 file
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 7 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-1

LDT-2004: fixed dialysate temperature to use filtered values. Removed teensy ifdef as it is no longer applicable in gen dialysate.

- -5
- +1
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

1:00 pm

Michael Garthwaite

More
a7587fa
changed 1 file
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 7 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-1

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

10:34 am

Michael Garthwaite

More
f40a7a7
changed 3 files
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 7 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-1

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

- -8
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -4
- +53
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c
- -2
- +5
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

10:33 am

Michael Garthwaite

More
6076cee
changed 1 file
LDT-2004-dialysate-composition-dd, LDT-2004-drybicarb---dd and 7 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-1

LDT-2004: code review updates.

- -3
- +1
/firmware/App/Drivers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c

Michael Garthwaite

About

eval(decodeURIComponent('%64%6F%63%75%6D%65%6E%74%2E%77%72%69%74%65%28%22%6D%67%61%72%74%68%77%61%69%74%65%40%64%69%61%6C%69%74%79%2E%63%6F%6D%22%29')); var scriptElem = document.getElementById('to-removed') scriptElem.parentNode.removeChild(scriptElem);

Reviews

48 active reviews

Line History

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Committer Mappings

Michael Garthwaite is mapped to 38 committers over 17 repositories