Michael Garthwaite

1:53 pm

Michael Garthwaite

More
LEAHI-DIALIN-LDT-1886-2
finished reviewing

1:04 pm

Michael Garthwaite

More
f5a0411
changed 1 file
develop in dd-firmware

Merge branch 'LDT-2977-iofp-update' into develop

- -9
- +74
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c

1:03 pm

Michael Garthwaite

More
9f79bc2
changed 1 file
LDT-2977-iofp-update, develop in dd-firmware LEAHI-DD-FIRMWARE-LDT-2977-1

LDT-2977: proof of concept for changing initial guess on flow control based on valve configuration.

- -5
- +12
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c

11:27 am

Michael Garthwaite

This is for alpha

11:26 am

Michael Garthwaite

11:00 am

Michael Garthwaite

increasing it to 50 would cause instability in our testing. 25 seems to keep it stable at the moment

10:59 am

Michael Garthwaite

fixed. thanks!

10:59 am

Michael Garthwaite

More
44dbba5
changed 14 files
LDT-2116-iofp-evaluate-closing-p39 in ro-firmware LEAHI-RO-FIRMWARE-LDT-2116-1

Merge branch 'staging' into LDT-2116-iofp-evaluate-closing-p39

- -5
- +5
/firmware/App/Controllers/PermeateTank.c
- History
- Source
- Diff
/firmware/App/Controllers/PermeateTank.c
- -4
- +4
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -5
- +5
/firmware/App/Drivers/FluidPump.c
- History
- Source
- Diff
/firmware/App/Drivers/FluidPump.c
- -3
- +3
/firmware/App/Modes/FPModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/FPModeStandby.c
- -4
- +4
/firmware/App/Modes/FlushConcentrate.c
- History
- Source
- Diff
/firmware/App/Modes/FlushConcentrate.c
- -3
- +3
/firmware/App/Modes/FlushFilter.c
- History
- Source
- Diff
/firmware/App/Modes/FlushFilter.c
- -4
- +4
/firmware/App/Modes/FlushPermeate.c
- History
- Source
- Diff
/firmware/App/Modes/FlushPermeate.c
- -4
- +4
/firmware/App/Modes/ModeGenPermeate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenPermeate.c
- -4
- +4
/firmware/App/Modes/ModePreGenPermeate.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreGenPermeate.c
- -3
- +3
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c
- -3
- +3
/firmware/App/Monitors/Conductivity.h
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.h
- -5
- +5
/firmware/App/Monitors/WaterQualityMonitor.c
- History
- Source
- Diff
/firmware/App/.../WaterQualityMonitor.c
- -3
- +3
/firmware/App/Monitors/WaterQualityMonitor.h
- History
- Source
- Diff
/firmware/App/.../WaterQualityMonitor.h
- -5
- +5
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

10:58 am

Michael Garthwaite

More
bea0e00
changed 1 file
LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: code review comments

- -5
- +5
/firmware/App/Monitors/Conductivity.h
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.h

10:56 am

Michael Garthwaite

added. thanks!

10:55 am

Michael Garthwaite

fixed. thanks!

10:55 am

Michael Garthwaite

fixed. thanks!

10:55 am

Michael Garthwaite

fixed. thanks!

10:54 am

Michael Garthwaite

fixed. thanks!

10:54 am

Michael Garthwaite

fixed. thanks!

10:54 am

Michael Garthwaite

fixed. thanks!

10:53 am

Michael Garthwaite

fixed. thanks!

10:53 am

Michael Garthwaite

More
3c0eedb
changed 1 file
LDT-2004 in teensy-board TEENSY-BOARD-LDT-2004-6

LDT-2004: fixed code review comments

- -896
- +896
/AD5941_interface09302025/ad5941_library_extension.cpp
- History
- Source
- Diff
/AD5941_interface09302025/ad5941_library_extension.cpp

10:26 am

Michael Garthwaite

More
0880553
changed 0 files
LDT-1473-ultrafiltration---dd-2, LDT-2801-add-4-wire-rinse-pump-commands-staging and 5 more in dd-firmware

Merge branch 'LDT-1773-dd-valve-pwm-beta' into staging

10:26 am

Michael Garthwaite

More
e062121
changed 0 files
LDT-1473-ultrafiltration---dd-2, LDT-1773-dd-valve-pwm-beta and 6 more in dd-firmware

Merge branch 'staging' into LDT-1773-dd-valve-pwm-beta

10:19 am

Michael Garthwaite

10:18 am

Michael Garthwaite

10:14 am

Michael Garthwaite

More
1fd5163
changed 0 files
LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware

Merge branch 'LDT-1773-iofp-valve-pwm' into staging

10:14 am

Michael Garthwaite

9:22 am

Michael Garthwaite

More
39db733
changed 2 files
LDT-1773-dd-valve-pwm in dd-firmware

LDT-1773: code review comments

- -1
- +0
/firmware/App/Services/FpgaDD.h
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.h
- -1
- +1
/firmware/source/sys_main.c
- History
- Source
- Diff
/firmware/source/sys_main.c

9:17 am

Michael Garthwaite

More
a85769a
changed 2 files
LDT-1773-dd-valve-pwm in dd-firmware

Merge branch 'staging_alpha' into LDT-1773-dd-valve-pwm

- -10
- +63
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -0
- +2
/firmware/App/Services/FpgaDD.h
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.h

9:15 am

Michael Garthwaite

fixed. thanks!

9:15 am

Michael Garthwaite

fixed. thanks!

9:15 am

Michael Garthwaite

More
c717bed
changed 0 files
LDT-1473-ultrafiltration---dd-2, LDT-1773-dd-valve-pwm-beta and 6 more in dd-firmware

Merge branch 'staging' into LDT-1773-dd-valve-pwm-beta

9:15 am

Michael Garthwaite

More
4c220e5
changed 1 file
LDT-1473-ultrafiltration---dd-2, LDT-1773-dd-valve-pwm-beta and 6 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-1773-1

LDT-1773: code review comments

- -3
- +0
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c

Michael Garthwaite

About

eval(decodeURIComponent('%64%6F%63%75%6D%65%6E%74%2E%77%72%69%74%65%28%22%6D%67%61%72%74%68%77%61%69%74%65%40%64%69%61%6C%69%74%79%2E%63%6F%6D%22%29')); var scriptElem = document.getElementById('to-removed') scriptElem.parentNode.removeChild(scriptElem);

Reviews

47 active reviews

Line History

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Committer Mappings

Michael Garthwaite is mapped to 19 committers over 17 repositories