Raghu Kallala

11:22 am

Raghu Kallala

Something like this ( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

Something like this
( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

10:54 am

Raghu Kallala

More
eeac01d
changed 2 files
develop in dd-firmware

resolved merge conflicts

- -1
- +1
/firmware/App/Controllers/DialysatePumps.h
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.h
- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

10:49 am

Raghu Kallala

More
9e0cf2d
changed 0 files
develop in leahi-fwcommon

Resolved merge conflicts

10:48 am

Raghu Kallala

More
f5c5050
changed 0 files
develop in leahi-fwcommon

Resolved merge conflicts

10:47 am

Raghu Kallala

More
efadb72
changed 0 files
develop in leahi-common

Merge branch 'develop' of bitbucket.org:diality-cloud/leahi-common into develop

10:47 am

Raghu Kallala

More
d3e727d
changed 2 files
develop in dd-firmware

Resolved merge conflict

- -1
- +1
/firmware/App/Controllers/PermeateTank.c
- History
- Source
- Diff
/firmware/App/Controllers/PermeateTank.c
- -3
- +3
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

10:40 am

Raghu Kallala

More
f4a8565
changed 34 files
develop in dd-firmware

Merged latest staging into develop

- -3
- +3
/firmware/App/Controllers/DialysatePumps.h
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.h
- -21
- +67
/firmware/App/Controllers/PermeateTank.c
- History
- Source
- Diff
/firmware/App/Controllers/PermeateTank.c
- -28
- +59
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -2
- +2
/firmware/App/Controllers/SpentChamberFill.h
- History
- Source
- Diff
/firmware/App/.../SpentChamberFill.h
- -1
- +4
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -3
- +3
/firmware/App/Drivers/FluidPump.c
- History
- Source
- Diff
/firmware/App/Drivers/FluidPump.c
- -2
- +2
/firmware/App/Drivers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -4
- +5
/firmware/App/Modes/FPModes/FPModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/FPModes/FPModeFault.c
- -2
- +4
/firmware/App/Modes/FPModes/FPModeStandby.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPModeStandby.c
- -14
- +30
/firmware/App/Modes/FPModes/FPOperationModes.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.c
- -24
- +36
/firmware/App/Modes/FPModes/FlushConcentrate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FlushConcentrate.c
- -21
- +19
/firmware/App/Modes/FPModes/FlushFilter.c
- History
- Source
- Diff
/firmware/App/Modes/FPModes/FlushFilter.c
- -12
- +39
/firmware/App/Modes/FPModes/FlushPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FlushPermeate.c
- -54
- +177
/firmware/App/Modes/FPModes/ModeGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.c
- -3
- +7
/firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
- History
- Source
- Diff
/firmware/App/.../ModeGenPermeateDefeatured.c
… 19 more files in changeset.

10:40 am

Raghu Kallala

More
2e753e0
changed 1 file
develop in leahi-fwcommon

Merged latest staging into develop

- -7
- +7
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c

10:32 am

Raghu Kallala

More
7a3f60f
changed 3 files
develop in leahi-common

Merged latest staging into develop

- -11
- +14
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -3
- +6
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
- -1
- +1
/TDDefs.h
- History
- Source
- Diff
/TDDefs.h

9:17 am

Raghu Kallala

More
9b06daf
changed 1 file
LDT-2185-io-fp-water-treatment-and-degas in dd-firmware LEAHI-DD-FIRMWARE-LDT-2185-1

Merge branch 'LDT-2185-io-fp-water-treatment-and-degas' of bitbucket.org:diality-cloud/dd-firmware into LDT-2185-io-fp-water-treatment-and-degas

- -0
- +2
/firmware/App/Modes/FPModes/ModeGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.c

9:16 am

Raghu Kallala

More
61b54ff
changed 2 files
LDT-2185-io-fp-water-treatment-and-degas in dd-firmware LEAHI-DD-FIRMWARE-LDT-2185-1

LDT-2185 moved tank full and fill timeout to Gen Permeate

- -66
- +3
/firmware/App/Controllers/PermeateTank.c
- History
- Source
- Diff
/firmware/App/Controllers/PermeateTank.c
- -0
- +66
/firmware/App/Modes/FPModes/ModeGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.c

8:23 am

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-2185-1
commented on review

Add a 1 second persistence on this alarm

7:26 am

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-2185-1
commented on review

Handle transition here after changing the flush logic transitionToGenPermeateDefeaturedMode(); requestGenWaterDefStart();

Handle transition here after changing the flush logic

transitionToGenPermeateDefeaturedMode();
requestGenWaterDefStart();

7:24 am

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-2185-1
commented on review

Need to remove this handler

7:22 am

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-2185-1
commented on review

Add blank line before return statement

7:21 am

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-2185-1
commented on review

Remove handlePreGenPDefInletWaterState

7:20 am

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-2185-1
commented on review

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

7:19 am

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-2185-1
commented on review

Call this in both Pre Gen: Verify Water and Gen Permeate

7:17 am

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-2185-1
commented on review

Greater than or equal to for low limit pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG Also give space before and after parentheses.

Greater than or equal to for low limit
pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG

Also give space before and after parentheses.

7:15 am

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-2185-1
commented on review

Put quadratic and linear terms in parentheses.

11:40 am

Raghu Kallala

More
b9084c5
changed 2 files
LDT-2185-io-fp-water-treatment-and-degas in dd-firmware LEAHI-DD-FIRMWARE-LDT-2185-1

Fixed indentation

- -5
- +5
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -1
- +0
/firmware/App/Modes/FPModes/FlushConcentrate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FlushConcentrate.c

11:25 am

Raghu Kallala

11:12 am

Raghu Kallala

More
39405d7
changed 20 files
LDT-1773-dd-valve-pwm-beta, LDT-2004-drybicarb---dd and 6 more in dd-firmware

Resolved merge conflicts

- -19
- +65
/firmware/App/Controllers/PermeateTank.c
- History
- Source
- Diff
/firmware/App/Controllers/PermeateTank.c
- -26
- +57
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -1
- +1
/firmware/App/Drivers/FluidPump.c
- History
- Source
- Diff
/firmware/App/Drivers/FluidPump.c
- -2
- +3
/firmware/App/Modes/FPModes/FPModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/FPModes/FPModeFault.c
- -0
- +2
/firmware/App/Modes/FPModes/FPModeStandby.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPModeStandby.c
- -4
- +4
/firmware/App/Modes/FPModes/FPOperationModes.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.c
- -23
- +35
/firmware/App/Modes/FPModes/FlushConcentrate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FlushConcentrate.c
- -19
- +17
/firmware/App/Modes/FPModes/FlushFilter.c
- History
- Source
- Diff
/firmware/App/Modes/FPModes/FlushFilter.c
- -10
- +37
/firmware/App/Modes/FPModes/FlushPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FlushPermeate.c
- -53
- +176
/firmware/App/Modes/FPModes/ModeGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.c
- -1
- +5
/firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
- History
- Source
- Diff
/firmware/App/.../ModeGenPermeateDefeatured.c
- -7
- +23
/firmware/App/Modes/FPModes/ModePreGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../ModePreGenPermeate.c
- -1
- +1
/firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
- History
- Source
- Diff
/firmware/.../ModePreGenPermeateDefeatured.c
- -0
- +3
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -2
- +202
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c
… 5 more files in changeset.

10:59 am

Raghu Kallala

More
c9b6850
changed 2 files
LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor, LDT-2004-drybicarb---dd and 4 more in leahi-common

LDT-2936 merge into staging

- -9
- +12
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -0
- +3
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

10:59 am

Raghu Kallala

More
eb50b6a
changed 1 file
LDT-2185-io-fp-water-treatment-and-degas, LDT-2801-add-4-wire-rinse-pump-commands-staging and 2 more in leahi-fwcommon

LDT-2936 merge into staging

- -5
- +5
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c

10:32 am

Raghu Kallala

More
aaaefc1
changed 1 file
LDT-1773-dd-valve-pwm-beta, LDT-2004-drybicarb---dd and 7 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2936-1

LDT-2936 fixed macro naming

- -1
- +1
/firmware/App/Controllers/PermeateTank.c
- History
- Source
- Diff
/firmware/App/Controllers/PermeateTank.c

10:30 am

Raghu Kallala

More
50aecc9
changed 1 file
LDT-1773-dd-valve-pwm-beta, LDT-2004-drybicarb---dd and 7 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2936-1

LDT-2936 fixed macro naming

- -3
- +3
/firmware/App/Controllers/PermeateTank.c
- History
- Source
- Diff
/firmware/App/Controllers/PermeateTank.c

10:29 am

Raghu Kallala

Resolved

10:29 am

Raghu Kallala

More
f73c82e
changed 1 file
LDT-1773-dd-valve-pwm-beta, LDT-2004-drybicarb---dd and 7 more in dd-firmware LEAHI-DD-FIRMWARE-LDT-2936-1

LDT-2936 fixed the macro comments

- -1
- +1
/firmware/App/Modes/FPModes/FlushPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FlushPermeate.c

10:03 am

Raghu Kallala

Fixed the ordering

Raghu Kallala

About

eval(decodeURIComponent('%64%6F%63%75%6D%65%6E%74%2E%77%72%69%74%65%28%22%72%6B%61%6C%6C%61%6C%61%40%64%69%61%6C%69%74%79%2E%63%6F%6D%22%29')); var scriptElem = document.getElementById('to-removed') scriptElem.parentNode.removeChild(scriptElem);

Reviews

15 active reviews

Line History

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Committer Mappings

Raghu Kallala is mapped to 9 committers over 5 repositories