Raghu Kallala

Removed

Removed

Removed

Removed

Updated

Updated

Fixed

Fixed

Something like this ( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

Something like this
( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

Add a 1 second persistence on this alarm

Add a 1 second persistence on this alarm

Handle transition here after changing the flush logic transitionToGenPermeateDefeaturedMode(); requestGenWaterDefStart();

Handle transition here after changing the flush logic

transitionToGenPermeateDefeaturedMode();
requestGenWaterDefStart();

Need to remove this handler

Need to remove this handler

Add blank line before return statement

Add blank line before return statement

Remove handlePreGenPDefInletWaterState

Remove handlePreGenPDefInletWaterState

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

Call this in both Pre Gen: Verify Water and Gen Permeate

Call this in both Pre Gen: Verify Water and Gen Permeate

Greater than or equal to for low limit pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG Also give space before and after parentheses.

Greater than or equal to for low limit
pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG

Also give space before and after parentheses.

Put quadratic and linear terms in parentheses.

Put quadratic and linear terms in parentheses.

Resolved

Resolved

Fixed the ordering

Fixed the ordering

Handled in FPOperationModes and respective states of PreGen have it.

Handled in FPOperationModes and respective states of PreGen have it.

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

Fixed. Thanks

Fixed. Thanks

Fixed.

Fixed.

Fixed.

Fixed.

Fixed. thanks

Fixed. thanks

Resolved.

Resolved.

Resolved. Thanks

Resolved. Thanks

We might need to provide a possibility to override the persistence time on alarm. To be clarified.

We might need to provide a possibility to override the persistence time on alarm. To be clarified.

Published in the respective modules

Published in the respective modules

Done in individual units publish functions.

Done in individual units publish functions.

As everything is of size 32 bits, skipped it

As everything is of size 32 bits, skipped it