Sean Nash

About
  • First commit 24 September 2019
  • Latest commit 09 December 2025
Last Week All Time
Commits: 0 4,041

Reviews

34 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sean Nash is mapped to 17 committers over 12 repositories
Username snash is mapped to:
Friday 19 Dec
10:41 am

Sean Nash

9:58 am

Sean Nash

9:12 am

Sean Nash

9:08 am

Sean Nash

Thursday 18 Dec
4:55 pm

Sean Nash

4:55 pm

Sean Nash

4:54 pm

Sean Nash

4:54 pm

Sean Nash

3:22 pm

Sean Nash

Can we remove this code?

Can we remove this code?

3:22 pm

Sean Nash

Can we remove this code?

Can we remove this code?

3:21 pm

Sean Nash

FPFilterFlushDefeatured.

FPFilterFlushDefeatured.

3:19 pm

Sean Nash

Don't include an Alarms detail if there are no alarms.

Don't include an Alarms detail if there are no alarms.

3:15 pm

Sean Nash

3:11 pm

Sean Nash

3:11 pm

Sean Nash

That suggests that our coefficient(s) are too aggressive (in situations where it looks unstable). Not directly due to max step size, so we shouldn't reduce it for this reason. I believe 25 will neg...

That suggests that our coefficient(s) are too aggressive (in situations where it looks unstable). Not directly due to max step size, so we shouldn't reduce it for this reason. I believe 25 will negatively impact our responsiveness in situations where our error is larger than 25 mL/min.
So instability could be due to:
1) coefficient(s) are too strong or
2) may need more than one set of coefficients (e.g. coefficients need to change according to Qd or state or ... because the relationship between output and feedback changes)

2:54 pm

Sean Nash

These don't need to be initialized to zero.

These don't need to be initialized to zero.

2:50 pm

Sean Nash

Is this code for alpha or beta? getCurrentOperationMode() will only return DD modes in beta.

Is this code for alpha or beta? getCurrentOperationMode() will only return DD modes in beta.

2:46 pm

Sean Nash

roRRAvg is an input.

roRRAvg is an input.

2:36 pm

Sean Nash

roRejectionRatioTankFill is an input.

roRejectionRatioTankFill is an input.

2:36 pm

Sean Nash

roRejectionRatio is an input.

roRejectionRatio is an input.

2:36 pm

Sean Nash

roRRTankFillAvg is an input.

roRRTankFillAvg is an input.

2:35 pm

Sean Nash

Update inputs/outputs.

Update inputs/outputs.

2:35 pm

Sean Nash

Add message for Reject Ratio data.

Add message for Reject Ratio data.

2:32 pm

Sean Nash

Update inputs/outputs.

Update inputs/outputs.

2:32 pm

Sean Nash

Update inputs/outputs.

Update inputs/outputs.

2:32 pm

Sean Nash

Update inputs/outputs.

Update inputs/outputs.

2:30 pm

Sean Nash

We have an alarm in this function. Should note it in function header.

We have an alarm in this function. Should note it in function header.

Tuesday 16 Dec
2:17 pm

Sean Nash

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

2:15 pm

Sean Nash

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

2:13 pm

Sean Nash

Declarations should be at top of scope.

Declarations should be at top of scope.