Vinayakam Mani

Please add the valve validations in the valves.c

Please add the valve validations in the valves.c

Please add D99 temp average.

Please add D99 temp average.

Implement the filter logics using these variables.

Implement the filter logics using these variables.

50

50

Please add up bicarb chamber level based on the D63 and D98 level sensor combinations?

Please add up bicarb chamber level based on the D63 and D98 level sensor combinations?

D98?

D98?

These are redundant information from level and pressure module, we may remove them.

These are redundant information from level and pressure module, we may remove them.

Bicarb Chamber Low level sensor

Bicarb Chamber Low level sensor

fresh dialysate temperature?

fresh dialysate temperature?

freshDialysatePressurePostUltrafilter (instead of TMP)?

freshDialysatePressurePostUltrafilter (instead of TMP)?

Please remove it.

Please remove it.

RTDReadCnt -> Should be defined here?

RTDReadCnt -> Should be defined here?

Please remove RTDReadCnt, per HDD.

Please remove RTDReadCnt, per HDD.

remove extra blank line

remove extra blank line

LDT-1473 UF changes

LDT-1473 Enable trimmer heater

    • -0
    • +8
    /firmware/App/Modes/ModeGenDialysate.c
    • -11
    • +17
    /firmware/App/Monitors/Temperature.c
BiCarb related state machines will be called in pre-gen, gen dialysate and post-gen modes. currently its kept here, so any modes can set a flag to initiate the required operations.

BiCarb related state machines will be called in pre-gen, gen dialysate and post-gen modes. currently its kept here, so any modes can set a flag to initiate the required operations.

Done.

Done.

Done.

Done.

Updated.

Updated.

Done.

Done.

Done.

Done.

Done.

Done.

We will move towards 200 RPM being the minimum speed with updated Maxon controller. So, there is no need to maintain two different minimum RPM going forward.

We will move towards 200 RPM being the minimum speed with updated Maxon controller. So, there is no need to maintain two different minimum RPM going forward.

Done.

Done.

Done.

Done.

LDT-2004 code review comments

    • -119
    • +120
    /firmware/App/Controllers/Valves.c
    • -0
    • +15
    /firmware/App/Modes/ModeGenDialysate.c
No reference of conductivity here. it should be a level sensor.

No reference of conductivity here. it should be a level sensor.

like D63 level sensor, please add D98 level sensor throughout the units. Keep naming as D98_LEVEL ( instead of D98_COND)

like D63 level sensor, please add D98 level sensor throughout the units. Keep naming as D98_LEVEL ( instead of D98_COND)

END_POS_FIELD_19?

END_POS_FIELD_19?