Zoltan Miskolci

I see it as a list, don't know why it is named enum or what the original purpose of it was. It was never updated, so I added the update part at least, so it will at least reflect the current states...

I see it as a list, don't know why it is named enum or what the original purpose of it was.
It was never updated, so I added the update part at least, so it will at least reflect the current states instead of always stating zeros.

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

We agreed to change back the enums into the static variation. Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic o...

We agreed to change back the enums into the static variation.
Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.

test config fix

    • -1
    • +2
    /leahi_dialin/common/test_config_defs.py
test config fix

    • -1
    • +2
    /leahi_dialin/common/test_config_defs.py
Merge branch 'LDT-3350-add_from_str' into develop

    • -0
    • +2
    /leahi_dialin/common/test_config_defs.py
- Removed ignore and _str_list from base class, added empty _str_list to all childs to not throw an error when from_str is called on them

    • -0
    • +1
    /leahi_dialin/common/alarm_priorities.py
    • -0
    • +2
    /leahi_dialin/common/test_config_defs.py
    • -0
    • +1
    /leahi_dialin/dd/modules/blood_leak.py
Removed ignore from dialinenum

removed duplicate enum

Merge branch 'LDT-2787-fp_dd_proxy_commands' into develop

Fixed msg id for override pwm

    • -1
    • +1
    /leahi_dialin/fp/modules/boost_pump.py
Merge branch 'LDT-3350-add_from_str' into develop

- updated if to fix build

Merge branch 'LDT-2787-fp_dd_proxy_commands' into develop

- Updated test configs

    • -7
    • +6
    /leahi_dialin/common/test_config_defs.py
Merge branch 'LDT-3350-add_from_str' into develop

Merge branch 'LDT-2994-iofp-valve-data-is-inaccurate' into develop

Merge branch 'LDT-2787-fp_dd_proxy_commands' into develop

    • -2
    • +28
    /leahi_dialin/dd/modules/conductivity_sensors.py
    • -4
    • +0
    /leahi_dialin/dd/modules/gen_dialysate.py
    • -1
    • +2
    /leahi_dialin/fp/filtration_purification.py
- Added fp go to commands

    • -7
    • +27
    /leahi_dialin/fp/proxies/dd_proxy.py
- Matching alarm publish name with variable name

- Updated test config names - Removed invalid publish from gen_dialysate

    • -2
    • +2
    /leahi_dialin/common/test_config_defs.py
    • -4
    • +0
    /leahi_dialin/dd/modules/gen_dialysate.py
When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

removed commented out line

removed commented out line

removed

It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.