dgfirmware

Clone Tools

Stats

Commits this week: 5
Total Committers: 17
Last Commit: 08 Jun
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Nov 2022
3:02 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14237 Correct multipe changes to return status based upon whether or not there is a pending alarm.

Options
    • -65
    • +82
    /firmware/App/Modes/ModeHeatDisinfect.c
2:13 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

wbracken  (deleted user)

Removed

Removed

2:07 pm

wbracken  (deleted user)

Removed

Removed

2:06 pm

wbracken  (deleted user)

This else has been removed

This else has been removed

2:05 pm

wbracken  (deleted user)

Removed

Removed

2:04 pm

wbracken  (deleted user)

Removed

Removed

2:04 pm

wbracken  (deleted user)

Removed

Removed

2:03 pm

wbracken  (deleted user)

Removed

Removed

2:03 pm

wbracken  (deleted user)

Removed

Removed

2:02 pm

wbracken  (deleted user)

Removed. Intended to remove all along.

Removed. Intended to remove all along.

1:59 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14237 Removed conditional code and references to isThisLastDrain.

Options
    • -302
    • +24
    /firmware/App/Modes/ModeHeatDisinfect.c
1:44 pm

Sean Nash

Remove references to this flag.

Remove references to this flag.

1:41 pm

Dara Navaei

This function will still override if there any alarms. Are we going to change the order of status report?

This function will still override if there any alarms. Are we going to change the order of status report?

1:40 pm

Sean Nash

Remove the TRUE case. Just need the else now.

Remove the TRUE case. Just need the else now.

1:40 pm

Sean Nash

Remove TRUE case. Just need the else now.

Remove TRUE case. Just need the else now.

1:39 pm

Sean Nash

Remove this flag.

Remove this flag.

1:38 pm

Sean Nash

Let's remove this code.

Let's remove this code.

1:37 pm

Sean Nash

Can we remove this code?

Can we remove this code?

1:37 pm

Sean Nash

Can we just remove this code?

Can we just remove this code?

1:37 pm

Dara Navaei

This flag also should be removed.

This flag also should be removed.

1:37 pm

Sean Nash

Can we just remove these?

Can we just remove these?

1:26 pm

Dara Navaei

DG-DEN-14237_Remove Heat Disinfect Rinse States
DG-DEN-14237_Remove Heat Disinfect Rinse States
10:56 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14237 changes to getHeatDisinfectStatus.

Options
    • -4
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.c
10:37 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:32 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:29 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:03 am

Dara Navaei

DEN-14175 addressed the code review comments and replaced the V3 enable software configuration flag with the hardware configuration flag from FGPA. Updated the trimmer heater's ramp state to check the use previous duty cycle flag instead of estimating the duty cycle.

Options
    • -4
    • +5
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -5
    • +6
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/Fans.c
    • -7
    • +30
    /firmware/App/Controllers/Heaters.c
    • -0
    • +2
    /firmware/App/Controllers/Heaters.h
    • -9
    • +7
    /firmware/App/Controllers/Pressures.c
    • -1
    • +2
    /firmware/App/Controllers/ROPump.c
    • -9
    • +5
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +2
    /firmware/App/Controllers/Thermistors.c
    • -9
    • +71
    /firmware/App/Controllers/Valves.c
    • -1
    • +3
    /firmware/App/Controllers/Valves.h
    • -3
    • +4
    /firmware/App/Modes/ModeFill.c
    • -0
    • +1
    /firmware/App/Modes/ModeFill.h
    • -2
    • +2
    /firmware/App/Services/FPGA.c
    • -1
    • +2
    /firmware/App/Services/Reservoirs.c
    • -6
    • +7
    /firmware/App/Services/SystemCommMessages.c
9:57 am

Dara Navaei

This is done to get an average of the fill temperature as well as the last fill temperature prior to tranistioning to Gen Idle. These values are used for the next estimation and are different from ...

This is done to get an average of the fill temperature as well as the last fill temperature prior to tranistioning to Gen Idle. These values are used for the next estimation and are different from the heaters driver.

9:55 am

Dara Navaei

Done.

Done.