Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4002: added dd switches module

  1. … 5 more files in changeset.
references to Denali has been removed

references to Denali has been removed

Shouldn't we use Leahi instead of Denali?

Shouldn't we use Leahi instead of Denali?

- Updated Event enum - Updated Datatypes enum - Added some debugging print to abstract class - Removed some init import to remove cyclic dependencies - Updated alarms

  1. … 13 more files in changeset.
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
- Handler and import refactoring of DD module

  1. … 45 more files in changeset.
Merge branch staging into LDT-3984-dd-sw-d46-reads-0-with-and-with

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEVEL_OFFSET?

LEVEL_OFFSET?

LDT-3984 fix for conductivie level sensors d46, d63,d98

  1. … 3 more files in changeset.
Merge branch LDT-3984-dd-sw-d46-reads-0-with-and-with into develop

  1. … 1 more file in changeset.
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LDT-3984 aligning D46 with DD firmware

  1. … 1 more file in changeset.
LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
missed from previous commit

Typo, response

Typo, response

Typo, response

Typo, response

Fix the header

Fix the header