td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 29
Total Committers: 17
Last Commit: 08 Jun
Commits this week: 29

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 08 Jun
5:12 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Options
    • -7
    • +160
    ./Services/FpgaTD.c
    • -0
    • +12
    ./Services/FpgaTD.h
4:44 pm

Vendor - TEL - Vijay Pamula

LDT-4329: Addressed review comments

Options
    • -13
    • +18
    ./Services/TxParams.c
4:13 pm

Vendor - TEL - Vijay Pamula

LDT-4027: Addressed review comments for pre-treatment recirculate state

Options
    • -6
    • +6
    ./Modes/ModePreTreat.c
    • -22
    • +15
    ./Modes/StatePreTxRecirculate.c
3:32 pm

Sean Nash

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

3:31 pm

Vendor - TEL - Jashwant Gantyada

LDT-4009 made changes to the DD payload msg and code changes for isolated uf

Options
    • -1
    • +1
    ./Modes/ModePreTreat.c
    • -39
    • +23
    ./Modes/ModeTreatment.c
    • -1
    • +1
    ./Modes/StateTxDialysis.c
    • -2
    • +6
    ./Modes/StateTxIsolatedUF.c
    • -19
    • +74
    ./Services/DDInterface.c
    • -23
    • +36
    ./Services/DDInterface.h
3:27 pm

Sean Nash

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

3:08 pm

Sean Nash

These should be moved down to an "else" in the if statement below (payload length check).

These should be moved down to an "else" in the if statement below (payload length check).

3:04 pm

Sean Nash

It doesn't look like these memsets are necessary. Consider removing them.

It doesn't look like these memsets are necessary. Consider removing them.

3:03 pm

Sean Nash

Remove blank line.

Remove blank line.

3:02 pm

Sean Nash

Can you move this down with the other vitals functions?

Can you move this down with the other vitals functions?

2:52 pm

Vendor - TEL - Vijay Pamula

LDT-4329: Updated Vitals Adjustment Implementation

Options
    • -0
    • +1
    ./Services/Messaging.c
    • -0
    • +211
    ./Services/TxParams.c
    • -0
    • +22
    ./Services/TxParams.h
2:33 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4149_Pinch Valves - FW Implementation - 1/1:
LEAHI-TD-FIRMWARE-LDT-4149_Pinch Valves - FW Implementation - 1/1:
2:17 pm

Vendor - TEL - Varshini Nagabooshanam

Fixes

Options
    • -1
    • +1
    ./Controllers/AirTrap.c
    • -1
    • +1
    ./Drivers/BPDriver.c
11:20 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
Friday 05 Jun
4:14 pm

Sean Nash

Just use 0x0 and 0xFFFFFFFF

Just use 0x0 and 0xFFFFFFFF

4:13 pm

Sean Nash

NUM_OF_BATTERY_REGISTERS - 1

NUM_OF_BATTERY_REGISTERS - 1

4:13 pm

Sean Nash

Put 2 items at end of the list here: BATTERY_END_OF_LIST_TIME_TO_PUBLISH NUM_OF_BATTERY_REGISTERS

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

4:10 pm

Sean Nash

Put this one back to NUM_OF_BATTERY_DEVICES.

Put this one back to NUM_OF_BATTERY_DEVICES.

4:08 pm

Sean Nash

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

4:04 pm

Sean Nash

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

1:42 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
1:41 pm

Vendor - TEL - Varshini Nagabooshanam

Fixes

Options
    • -1
    • +1
    ./Controllers/AirPump.c
    • -1
    • +1
    ./Controllers/AirPump.h
1:36 pm

Sean Nash

1:35 pm

Vendor - TEL - Varshini Nagabooshanam

Fixes

Options
    • -1
    • +1
    ./Controllers/AirPump.c
    • -1
    • +1
    ./Controllers/AirPump.h
1:23 pm

Vendor - TEL - Arpita Srivastava

Please add Alarm ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Please add Alarm
ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

1:19 pm

Vendor - TEL - Arpita Srivastava

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

1:16 pm

Vendor - TEL - Arpita Srivastava

Please add currentPreTreatmentState to inputs.

Please add currentPreTreatmentState to inputs.

1:07 pm

Vendor - TEL - Arpita Srivastava

currentPreTxRecircState looks like an input.

currentPreTxRecircState looks like an input.

12:58 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Options
    • -1
    • +1
    ./Controllers/BPModule.c
12:18 pm

Sean Nash

LDT-4033: Allow for BP module command reset between actual commands.

Options
    • -1
    • +8
    ./Services/FpgaTD.c