Fisheye on testsuites/tst_HDBloodFlowData

testsuites (master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 05 Jan 2026 15:12:17 -0800

Dara Navaei committed a3c7851 on branch master in testsuites

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /README.md

(-1, +1)

| History

| Source

| Diff

· /cr_objectives.sh

(-1, +1)

| History

| Source

| Diff

· /shared/scripts/configuration/application_init.py

(-1, +1)

| History

| Source

| Diff

· /shared/scripts/configuration/config.py

(-1, +1)

| History

| Source

| Diff

· /shared/scripts/configuration/strings.py

(-1, +1)

| History

| Source

| Diff

· /shared/scripts/configuration/utility.py

(-1, +1)

| History

| Source

| Diff

· /shared/scripts/names.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/accelerometer/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/alarms/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/bloodPrime/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/createtreatment/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/heparin/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/inlinebloodpressures/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/recirculate/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/rinseback/loader.py

(-1, +1)

| History

| Source

| Diff

… 98 more files in changeset.

testsuites (master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 16 Dec 2025 17:00:48 -0800

Dara Navaei committed 316fd2f on branch master in testsuites

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /README.md

(-0, +15)

| History

| Source

| Diff

· /cr_objectives.sh

(-0, +15)

| History

| Source

| Diff

· /shared/scripts/configuration/application_init.py

(-3, +6)

| History

| Source

| Diff

· /shared/scripts/configuration/config.py

(-3, +5)

| History

| Source

| Diff

· /shared/scripts/configuration/strings.py

(-3, +6)

| History

| Source

| Diff

· /shared/scripts/configuration/utility.py

(-5, +7)

| History

| Source

| Diff

· /shared/scripts/names.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/accelerometer/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/alarms/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/bloodPrime/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/createtreatment/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/heparin/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/inlinebloodpressures/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/recirculate/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/rinseback/loader.py

(-0, +15)

| History

| Source

| Diff

… 98 more files in changeset.

TESTSUITES-DEN-16533-1: closed by Behrouz NematiPour

Behrouz NematiPour — Wed, 21 Feb 2024 17:43:06 -0800

Behrouz NematiPour Closed TESTSUITES-DEN-16533-1

TESTSUITES-DEN-16533-1: reviewers finished

Wed, 21 Feb 2024 12:36:27 -0800

Behrouz NematiPour finished reviewing TESTSUITES-DEN-16533-1

DEN-16533-UI-VD-S109 - Integration Update 2

TESTSUITES-DEN-16533-1: reviewers finished

Thu, 07 Dec 2023 11:51:40 -0800

msuleiman (deleted user) finished reviewing TESTSUITES-DEN-16533-1

DEN-16533-UI-VD-S109 - Integration Update 2

TESTSUITES-DEN-16533-1: reviewers finished

Mon, 04 Dec 2023 10:47:46 -0800

jtaylor (deleted user) finished reviewing TESTSUITES-DEN-16533-1

DEN-16533-UI-VD-S109 - Integration Update 2

testsuites (DEN-17260-ui-dn-release-21): DEN-16465: Fixed - TestSuites : Integration testing update...

Fri, 01 Dec 2023 15:09:25 -0800

Vy committed 40314c6 on branch DEN-16533-UI-VD-S109_integration_update_2, DEN-17206-UI-BN-Release20 and 14 more in testsuites

DEN-16465: Fixed - TestSuites : Integration testing update

Updated tests to add coverage and not have build errors

· /shared/scripts/configuration/application_init.py

(-0, +1)

| History

| Source

| Diff

· /shared/scripts/configuration/config.py

(-0, +5)

| History

| Source

| Diff

· /shared/scripts/configuration/strings.py

(-4, +4)

| History

| Source

| Diff

· /shared/scripts/configuration/utility.py

(-9, +40)

| History

| Source

| Diff

· /shared/scripts/names.py

(-4, +9)

| History

| Source

| Diff

· /suite.conf

(-1, +1)

| History

| Source

| Diff

· /tst_AlarmCleared/test.py

(-8, +11)

| History

| Source

| Diff

· /tst_AlarmStatusData/test.py

(-41, +64)

| History

| Source

| Diff

· /tst_AlarmTriggered/test.py

(-16, +19)

| History

| Source

| Diff

· /tst_CANBusFaultCount/test.py

(-9, +17)

| History

| Source

| Diff

· /tst_ConfirmPrimingBegin/test.py

(-2, +6)

| History

| Source

| Diff

· /tst_CreateTreatment/test.py

(-8, +23)

| History

| Source

| Diff

· /tst_DGDrainPumpData/test.py

(-8, +15)

| History

| Source

| Diff

· /tst_DGHeatersData/test.py

(-7, +16)

| History

| Source

| Diff

· /tst_DGLoadCellReadingsData/test.py

(-9, +16)

| History

| Source

| Diff

… 26 more files in changeset.

TESTSUITES-DEN-16533-1: reviewers joined DEN-16533-UI-VD-S109 - Integration Update 2

Fri, 03 Nov 2023 11:30:24 -0700

jtaylor (deleted user) joined TESTSUITES-DEN-16533-1

DEN-16533-UI-VD-S109 - Integration Update 2

TESTSUITES-DEN-16533-1: started by Dara Navaei

Dara Navaei — Fri, 03 Nov 2023 09:12:09 -0700

Dara Navaei started review TESTSUITES-DEN-16533-1

testsuites (master_old): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 04 Jan 2023 16:48:38 -0800

Dara Navaei committed d451f4c on branch master_old in testsuites

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /shared/scripts/names.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/alarms/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/createtreatment/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/heparin/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/inlinebloodpressures/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/salinebolus/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/treatmentranges/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/treatmentstates/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/plugins/ultrafiltration/loader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/run.py

(-1, +1)

| History

| Source

| Diff

· /simulator/run.sh

(-1, +1)

| History

| Source

| Diff

· /simulator/simulator/dynamicloader.py

(-1, +1)

| History

| Source

| Diff

· /simulator/simulator/loader.py

(-1, +1)

| History

| Source

| Diff

· /tools/check_setup.sh

(-1, +1)

| History

| Source

| Diff

· /tools/create_dialin_link.sh

(-1, +1)

| History

| Source

| Diff

… 51 more files in changeset.

testsuites (master_old): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 May 2022 09:27:16 -0700

Dara Navaei committed 25829e5 on branch master_old in testsuites

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /shared/scripts/names.py

(-10, +13)

| History

| Source

| Diff

· /simulator/plugins/alarms/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/createtreatment/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/heparin/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/inlinebloodpressures/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/salinebolus/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/treatmentranges/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/treatmentstates/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/plugins/ultrafiltration/loader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/run.py

(-0, +15)

| History

| Source

| Diff

· /simulator/run.sh

(-0, +15)

| History

| Source

| Diff

· /simulator/simulator/dynamicloader.py

(-0, +15)

| History

| Source

| Diff

· /simulator/simulator/loader.py

(-0, +15)

| History

| Source

| Diff

· /tools/check_setup.sh

(-0, +15)

| History

| Source

| Diff

· /tools/create_dialin_link.sh

(-9, +8)

| History

| Source

| Diff

… 51 more files in changeset.

testsuites (master_old): DEN-7041: Fixed failing tests. Renamed HDSimulator to hd_sim

Mon, 22 Feb 2021 14:47:46 -0800

Peter Lucia committed cea6eac on branch master_old in testsuites

DEN-7041: Fixed failing tests. Renamed HDSimulator to hd_sim

· /requirements.txt

(-1, +0)

| History

| Source

| Diff

· /simulator/run.py

(-1, +1)

| History

| Source

| Diff

· /simulator/simulator/loader.py

(-3, +3)

| History

| Source

| Diff

· /tst_AlarmStatusData/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_AlarmTriggered/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_CANBusFaultCount/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_DGDrainPumpData/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_DGHeatersData/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_DGLoadCellReadingsData/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_DGOperationMode/test.py

(-6, +6)

| History

| Source

| Diff

· /tst_DGPressureData/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_DGROPumpData/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_DGReservoirData/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_DGTemperaturesData/test.py

(-5, +5)

| History

| Source

| Diff

· /tst_DGValvesStatesData/test.py

(-5, +5)

| History

| Source

| Diff

… 21 more files in changeset.

testsuites (master_old): DEN-7041: Fixed tests that were failing

Wed, 17 Feb 2021 18:07:48 -0800

Peter Lucia committed 4becb22 on branch master_old in testsuites

DEN-7041: Fixed tests that were failing

· /tst_AlarmStatusData/test.py	(-17, +1)	\| History	\| Source	\| Diff
· /tst_ConfirmPrimingBegin/test.py	(-4, +1)	\| History	\| Source	\| Diff
· /tst_HDBloodFlowData/test.py	(-16, +8)	\| History	\| Source	\| Diff
· /tst_TreatmentHeparineData/test.py	(-3, +3)	\| History	\| Source	\| Diff

UI-DEN-5638-1: closed by plucia

plucia — Mon, 15 Feb 2021 13:28:57 -0800

plucia (deleted user) Closed UI-DEN-5638-1

UI-DEN-5638-1: reviewers finished

Mon, 15 Feb 2021 13:27:43 -0800

Behrouz NematiPour finished reviewing UI-DEN-5638-1

UI-DEN-5638_Squish Migration

UI-DEN-5638-1: comment by Behrouz NematiPour "Still don't feel comfortable with this solution..."

Behrouz NematiPour — Mon, 15 Feb 2021 10:22:33 -0800

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-5638-1

Still don't feel comfortable with this solution and haven't been convinced that it should be the way to get around the SquishQt issue of finding the object within the given timeout.
On the other hand, don't have a better idea to stop the test from failing randomly.
So would be better to keep it for now.

testsuites (master_old): DEN-6349: Addressed code review comments

Mon, 01 Feb 2021 13:49:02 -0800

Peter Lucia committed a7b9888 on branch master_old in testsuites

DEN-6349: Addressed code review comments

· /tst_HDBloodFlowData/test.py

(-7, +18)

| History

| Source

| Diff

UI-DEN-5638-1: comment by Behrouz NematiPour "RESOLVED"

Behrouz NematiPour — Wed, 27 Jan 2021 10:10:02 -0800

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-5638-1

RESOLVED

UI-DEN-5638-1: comment by Behrouz NematiPour "Please change to TreatmentStates RESOLVED"

Behrouz NematiPour — Wed, 27 Jan 2021 10:05:21 -0800

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-5638-1

Please change to TreatmentStates
RESOLVED

UI-DEN-5638-1: comment by plucia "Nothing has changed about the usage of the Squi..."

plucia — Tue, 26 Jan 2021 13:49:00 -0800

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-5638-1

Nothing has changed about the usage of the SquishQt API, other than the fact that the dictionary passed to waitForObjectExists previously wasn't really testing anything.
Removing utils.dict_update it will break the test case.

UI-DEN-5638-1: comment by plucia "I will discuss with Peman and get back to you."

plucia — Tue, 26 Jan 2021 14:54:21 -0800

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-5638-1

I will discuss with Peman and get back to you.

UI-DEN-5638-1: comment by Behrouz NematiPour "I believe we discussed enough. And it was disc..."

Behrouz NematiPour — Tue, 26 Jan 2021 14:06:22 -0800

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-5638-1

I believe we discussed enough.
And it was discussed verbally before to not to do it.

Nothing has changed about the usage of the SquishQt API. We pass a dictionary to waitForObjectExists prior to this change and after.
Removing it will break the test case.

If nothing has changed so why your test would break.
Please change it to the recommended ways in SquishQt examples.

UI-DEN-5638-1: comment by Behrouz NematiPour "The way it was used is in SquishQt examples, bu..."

Behrouz NematiPour — Tue, 26 Jan 2021 13:35:48 -0800

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-5638-1

The way it was used is in SquishQt examples, but I can't find any example that SquishQt is being used the way you used it.
Please change it to the recommended ways in SquishQt examples.

UI-DEN-5638-1: comment by plucia "I think you've misunderstood. The bug is not pa..."

plucia — Tue, 26 Jan 2021 13:16:36 -0800

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-5638-1

I think you've misunderstood. The bug is not part of the SquishQt API. It is a problem with the way the SquishQt API is being used.

UI-DEN-5638-1: comment by Behrouz NematiPour "If there is a bug in SquishQt please report to ..."

Behrouz NematiPour — Tue, 26 Jan 2021 13:00:10 -0800

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-5638-1

If there is a bug in SquishQt please report to Froglogic and give feedback and please don't try to fix it by yourself.
In case they fix the bug (if there is a bug) and they fix it, and the fix is not compatible with your fix, then we have self-generated bugs.
Please remove these and let Froglogic know you found a bug and let them help us.

UI-DEN-5638-1: comment by Behrouz NematiPour "RESOLVED"

Behrouz NematiPour — Tue, 26 Jan 2021 12:59:04 -0800

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-5638-1

RESOLVED

UI-DEN-5638-1: comment by plucia "We are in agreement that each test should be se..."

plucia — Tue, 26 Jan 2021 11:11:26 -0800

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-5638-1

We are in agreement that each test should be self contained.
To ensure each test is self-contained, each test needs to have a separate instance of HDSimulator.
The design of dialin is not the focus of this review...

UI-DEN-5638-1: comment by plucia "Tx_States violates the CapWords convention for ..."

plucia — Tue, 26 Jan 2021 11:21:56 -0800

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-5638-1

Tx_States violates the CapWords convention for classes as per our coding standard, as no underscores should be present between words in a class name.
TreatmentStates is clearer than TxStates. Tx could easily be confused with transmit...

UI-DEN-5638-1: comment by plucia "I agree. To ensure I don't miss additional inst..."

plucia — Tue, 26 Jan 2021 11:08:26 -0800

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-5638-1

I agree. To ensure I don't miss additional instances of HDSimulator I'll make this change on the latest testsuites branch I'm working on.

UI-DEN-5638-1: comment by Behrouz NematiPour "I don't mean to limit the HDSimulator to static..."

Behrouz NematiPour — Tue, 26 Jan 2021 10:58:31 -0800

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-5638-1

I don't mean to limit the HDSimulator to static functions, it can have static and normal methods.

1 - The test scripts are run in a consecutive manner, not in parallel. Each test should be self contained.

I agree in this case but the general implementation and design of HDSimulator lead to that misuse of the class.