Fisheye on hdfirmware/firmware/App

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150 addressed a code review comment

Dara Navaei — Fri, 11 Nov 2022 15:04:13 -0800

Dara Navaei committed 563f11f on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150 addressed a code review comment

· /firmware/App/Modes/ModePreTreat.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150 reversed the previous code changes. Calling resetBloodPumpRotorCount and resetDialInPumpRotorCount

Dara Navaei — Fri, 11 Nov 2022 14:36:54 -0800

Dara Navaei committed 5beae1a on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150 reversed the previous code changes. Calling resetBloodPumpRotorCount and resetDialInPumpRotorCount

· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-3, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-3, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150 addressed a code review comment by making resetSignalFlags and resetAlarmSignalFlags functions to be called in...

Dara Navaei — Fri, 11 Nov 2022 14:19:18 -0800

Dara Navaei committed 19e1a49 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150 addressed a code review comment by making resetSignalFlags and resetAlarmSignalFlags functions to be called in pretreatment

· /firmware/App/Modes/ModePreTreat.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-35, +30)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-0, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150 removed a blank line

Dara Navaei — Fri, 11 Nov 2022 14:00:12 -0800

Dara Navaei committed 5256375 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150 removed a blank line

· /firmware/App/Modes/ModeTreatment.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150 merged staging

Dara Navaei — Fri, 11 Nov 2022 13:51:11 -0800

Dara Navaei committed d7b7938 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150 merged staging

· /firmware/App/Controllers/DGInterface.c	(-28, +131)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.h	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-30, +226)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-4, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-5, +21)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-32, +211)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-8, +28)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150: Update DialInFlow.c

Thu, 10 Nov 2022 17:46:09 -0800

Dong Nguyen committed 6049f1b on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150: Update DialInFlow.c

· /firmware/App/Controllers/DialInFlow.c

(-0, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Thu, 10 Nov 2022 10:42:07 -0800

Dara Navaei committed 65dc376 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 10 Nov 2022 10:42:00 -0800

Dara Navaei committed aa7b1f5 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/PresOccl.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/SyringePump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Temperatures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModePostTreat.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreTreat.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/PreTreatmentRecirc.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Prime.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Rinseback.c

(-2, +2)

| History

| Source

| Diff

… 6 more files in changeset.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 addressed a code review comment

Dara Navaei — Thu, 10 Nov 2022 10:27:12 -0800

Dara Navaei committed 54ef95c on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 addressed a code review comment

· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-1, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150: Update DialInFLow.c

Wed, 09 Nov 2022 14:18:33 -0800

Dong Nguyen committed 90be435 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150: Update DialInFLow.c

· /firmware/App/Controllers/DialInFlow.c

(-6, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 addressed the code review comments. Updated the reservoir switch command in pre treatment and added the getHWC...

Dara Navaei — Wed, 09 Nov 2022 13:25:12 -0800

Dara Navaei committed a9368b2 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 addressed the code review comments. Updated the reservoir switch command in pre treatment and added the getHWConfig function in FPGA

· /firmware/App/Modes/ModePreTreat.c	(-2, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-6, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-1, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5

Dara Navaei — Wed, 09 Nov 2022 12:56:56 -0800

Dara Navaei committed fae0fd5 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Merge branch 'staging' into DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5

· /firmware/App/Controllers/SyringePump.c	(-4, +126)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-7, +17)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 removed a blank line

Dara Navaei — Wed, 09 Nov 2022 12:56:39 -0800

Dara Navaei committed ccdc42e on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 removed a blank line

· /firmware/App/Controllers/PresOccl.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Tue, 08 Nov 2022 14:22:25 -0800

Dara Navaei committed 0b6cb1c on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 08 Nov 2022 14:22:18 -0800

Dara Navaei committed e482c96 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/SyringePump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into staging

Tue, 08 Nov 2022 14:19:29 -0800

Darren Cox committed 66c6285 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into staging

· /firmware/App/Controllers/SyringePump.c	(-2, +124)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-5, +15)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14170 Code review comment update for if/else condition.

Tue, 08 Nov 2022 11:59:56 -0800

Darren Cox committed a5ed2e6 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-14170 Code review comment update for if/else condition.

· /firmware/App/Controllers/SyringePump.c

(-14, +14)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150: Update DialInFlow.c

Tue, 08 Nov 2022 09:24:50 -0800

Dong Nguyen committed d3e3b81 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150: Update DialInFlow.c

· /firmware/App/Controllers/DialInFlow.c

(-3, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14170 Remove check for Syringe in Preload request. Preload function does this test and sets alarm properly.

Mon, 07 Nov 2022 18:25:08 -0800

Darren Cox committed abd31ef on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-14170 Remove check for Syringe in Preload request. Preload function does this test and sets alarm properly.

· /firmware/App/Controllers/SyringePump.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150: Update DialInFlow.c

Mon, 07 Nov 2022 14:33:51 -0800

Dong Nguyen committed 1d3672e on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150: Update DialInFlow.c

· /firmware/App/Controllers/DialInFlow.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150: Update DialInFlow.c

Mon, 07 Nov 2022 13:51:49 -0800

Dong Nguyen committed b289f9d on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150: Update DialInFlow.c

· /firmware/App/Controllers/DialInFlow.c

(-15, +18)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 merged staging and resolved the conflicts

Dara Navaei — Mon, 07 Nov 2022 10:52:41 -0800

Dara Navaei committed 427b37a on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 merged staging and resolved the conflicts

· /firmware/App/Controllers/DGInterface.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-3, +14)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-48, +155)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-76, +217)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150: Update DialInFlow.c

Mon, 07 Nov 2022 10:52:04 -0800

Dong Nguyen committed abbb584 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150: Update DialInFlow.c

· /firmware/App/Controllers/DialInFlow.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 addressed the code review comments

Dara Navaei — Mon, 07 Nov 2022 10:34:26 -0800

Dara Navaei committed 2b81130 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 addressed the code review comments

· /firmware/App/Modes/ModePreTreat.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-2, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150: Update DialInFlow.c

Mon, 07 Nov 2022 09:48:03 -0800

Dong Nguyen committed c77771a on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150: Update DialInFlow.c

· /firmware/App/Controllers/DialInFlow.c

(-2, +5)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150: Update DialInFlow.c

Fri, 04 Nov 2022 15:48:58 -0700

Dong Nguyen committed 5a03bc5 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150: Update DialInFlow.c

· /firmware/App/Controllers/DialInFlow.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14170 Updated for code review comments.

Fri, 04 Nov 2022 15:27:59 -0700

Darren Cox committed c5bb512 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-14170 Updated for code review comments.

· /firmware/App/Controllers/SyringePump.c	(-22, +24)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14150: Address code review comments

Fri, 04 Nov 2022 15:21:16 -0700

Dong Nguyen committed b71aca7 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 304 more in hdfirmware

DEN-14150: Address code review comments

· /firmware/App/Controllers/DialInFlow.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Battery.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 replaced the V3 flag with FPGA hardware check and added the default the fixed valves PWM count in FPGA

Dara Navaei — Thu, 03 Nov 2022 16:00:14 -0700

Dara Navaei committed d9b4581 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 replaced the V3 flag with FPGA hardware check and added the default the fixed valves PWM count in FPGA

· /firmware/App/Controllers/Valves.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +9)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14170 Fix TODO with new fault.

Thu, 03 Nov 2022 13:39:23 -0700

Darren Cox committed 6cec0f4 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-14170 Fix TODO with new fault.

· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff