Fisheye on dgfirmware/

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

Fri, 31 Mar 2023 15:55:50 -0700

Bill Bracken committed 0393f47 on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

· /firmware/App/Controllers/Heaters.c

(-23, +28)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 31 Mar 2023 15:27:15 -0700

Dara Navaei committed bfd3fdf on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 31 Mar 2023 15:27:07 -0700

Dara Navaei committed a779231 on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge remote-tracking branch 'origin/DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen' into s...

Fri, 31 Mar 2023 15:24:32 -0700

James Walter Taylor committed dfd91f7 on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

Merge remote-tracking branch 'origin/DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen' into staging

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14646 Correction per code review comments

Fri, 31 Mar 2023 13:39:24 -0700

Bill Bracken committed c7471bc on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

DEN-14646 Correction per code review comments

· /firmware/App/Controllers/ConductivitySensors.c

(-3, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 31 Mar 2023 12:49:52 -0700

Dara Navaei committed 7b3ff8a on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 31 Mar 2023 12:49:43 -0700

Dara Navaei committed d00e9fb on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'DEN-14788-DIAL-222-heater-duty-cycles' into staging

Michael Garthwaite — Fri, 31 Mar 2023 12:48:27 -0700

Michael Garthwaite committed b7f07ab on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

Merge branch 'DEN-14788-DIAL-222-heater-duty-cycles' into staging

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen...

Fri, 31 Mar 2023 12:30:35 -0700

James Walter Taylor committed e053a89 on branch master, DEN-14316-chemical-disinfect and 140 more in dgfirmware

DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Update for code review.

· /firmware/App/Services/SystemComm.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DIAL-222: changed set heater duty cycle to consider overriden values on reset.

Michael Garthwaite — Fri, 31 Mar 2023 09:44:35 -0700

Michael Garthwaite committed de150a6 on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

DIAL-222: changed set heater duty cycle to consider overriden values on reset.

· /firmware/App/Controllers/Heaters.c

(-19, +27)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen...

Fri, 31 Mar 2023 08:59:51 -0700

James Walter Taylor committed 7513288 on branch master, DEN-14316-chemical-disinfect and 140 more in dgfirmware

HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Closing code review comments.

· /firmware/App/Services/SystemComm.c

(-9, +7)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen...

Thu, 30 Mar 2023 17:56:56 -0700

James Walter Taylor committed 5245b97 on branch master, DEN-14316-chemical-disinfect and 140 more in dgfirmware

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Updates to hold off processing retries until after INIT, and after communication with HD started.

· /firmware/App/Services/SystemComm.c

(-7, +20)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14646 Changes per code review

Thu, 30 Mar 2023 14:36:22 -0700

Bill Bracken committed 9488cd5 on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

DEN-14646 Changes per code review

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

Thu, 30 Mar 2023 13:42:32 -0700

Bill Bracken committed f448119 on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

· /firmware/App/Controllers/ConductivitySensors.c

(-4, +26)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14646 Update per code review

Thu, 30 Mar 2023 13:35:16 -0700

Bill Bracken committed 9485204 on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

DEN-14646 Update per code review

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DIAL-222: removed heater check for reset override command.

Michael Garthwaite — Thu, 30 Mar 2023 08:46:56 -0700

Michael Garthwaite committed efeadc3 on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

DIAL-222: removed heater check for reset override command.

· /firmware/App/Controllers/Heaters.c

(-4, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen...

Thu, 30 Mar 2023 08:19:16 -0700

James Walter Taylor committed f58fb87 on branch master, DEN-14316-chemical-disinfect and 140 more in dgfirmware

DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Added a space.

· /firmware/App/Services/SystemComm.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen...

Wed, 29 Mar 2023 16:10:05 -0700

James Walter Taylor committed e4b1961 on branch master, DEN-14316-chemical-disinfect and 140 more in dgfirmware

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Increased MSG ACK timeouts. Delayed expecting ACKs until HD turns on and is sending messages.

· /firmware/App/Services/SystemComm.c

(-19, +22)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 29 Mar 2023 08:39:20 -0700

Dara Navaei committed 7b22214 on branch master, DEN-14316-chemical-disinfect and 140 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 29 Mar 2023 08:39:09 -0700

Dara Navaei committed 5652568 on branch master, DEN-14316-chemical-disinfect and 140 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN14646 - Valves variable renamed.

Tue, 28 Mar 2023 17:28:35 -0700

Bill Bracken committed 0740e78 on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

DEN14646 - Valves variable renamed.

· /firmware/App/Controllers/Valves.c

(-6, +6)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

Tue, 28 Mar 2023 17:27:30 -0700

Bill Bracken committed 47ac2ff on branch master, DEN-14316-chemical-disinfect and 139 more in dgfirmware

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

· /firmware/App/Controllers/ConductivitySensors.c	(-7, +15)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15014 addressed the code review comment

Dara Navaei — Tue, 28 Mar 2023 17:07:07 -0700

Dara Navaei committed e93755d on branch master, DEN-14316-chemical-disinfect and 141 more in dgfirmware

DEN-15014 addressed the code review comment

· /firmware/App/Services/SystemCommMessages.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15014 addressed the code review comment

Dara Navaei — Tue, 28 Mar 2023 16:59:29 -0700

Dara Navaei committed 56b4de1 on branch master, DEN-14316-chemical-disinfect and 141 more in dgfirmware

DEN-15014 addressed the code review comment

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15014 updated the fill mode by removing the enable RO only mode variable from the init function to not be set to FAL...

Dara Navaei — Tue, 28 Mar 2023 16:57:22 -0700

Dara Navaei committed 2cc8162 on branch master, DEN-14316-chemical-disinfect and 141 more in dgfirmware

DEN-15014 updated the fill mode by removing the enable RO only mode variable from the init function to not be set to FALSE every time

· /firmware/App/Modes/ModeFill.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15014 addressed the code review comments

Dara Navaei — Tue, 28 Mar 2023 16:48:39 -0700

Dara Navaei committed 96dd3e3 on branch master, DEN-14316-chemical-disinfect and 141 more in dgfirmware

DEN-15014 addressed the code review comments

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-7, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-9, +7)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15014 added code to support RO only mode

Dara Navaei — Mon, 27 Mar 2023 11:29:42 -0700

Dara Navaei committed b0f9003 on branch master, DEN-14316-chemical-disinfect and 141 more in dgfirmware

DEN-15014 added code to support RO only mode

· /firmware/App/Controllers/ConductivitySensors.c	(-3, +25)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +32)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +106)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +13)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 23 Mar 2023 09:18:48 -0700

Dara Navaei committed 3ee403f on branch master, DEN-14316-chemical-disinfect and 141 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 23 Mar 2023 09:18:39 -0700

Dara Navaei committed 60e80a2 on branch master, DEN-14316-chemical-disinfect and 141 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'DEN-14817-concentrate-pump-triggers-alarm-187-188-after-pump-parking' into staging

Michael Garthwaite — Thu, 23 Mar 2023 09:16:27 -0700

Michael Garthwaite committed bf4d359 on branch master, DEN-14316-chemical-disinfect and 141 more in dgfirmware

Merge branch 'DEN-14817-concentrate-pump-triggers-alarm-187-188-after-pump-parking' into staging