Fisheye on dgfirmware/firmware/App/Services/AlarmMgmtSWFaults.h

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 11 Jan 2023 14:13:50 -0800

Dara Navaei committed b8f2985 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 170 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/CPLD.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

… 9 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

Dara Navaei — Wed, 11 Jan 2023 10:32:47 -0800

Dara Navaei committed 5c430c3 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 171 more in dgfirmware

Merge branch 'staging' into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-2, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/CPLD.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

… 9 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 03 Jan 2023 10:10:54 -0800

Dara Navaei committed 6499ea2 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 174 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 84 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14497, DIAL-222 updated the drain pump's control to control the pump to flow in heat disinfect. Added a command to b...

Dara Navaei — Fri, 30 Dec 2022 19:37:56 -0800

Dara Navaei committed 4b9ae4e on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 171 more in dgfirmware

DEN-14497, DIAL-222 updated the drain pump's control to control the pump to flow in heat disinfect. Added a command to be able to override the heaters duty cycle and reset it. Made the set RO pump to an open loop with a duty cycle a punlic function

· /firmware/App/Controllers/DrainPump.c	(-83, +101)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.h	(-4, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-18, +86)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-25, +37)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/CPLD.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-22, +14)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +37)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merged staging

Dara Navaei — Wed, 21 Dec 2022 14:30:37 -0800

Dara Navaei committed eceb190 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more in dgfirmware

Merged staging

· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-67, +186)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1302, +856)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-0, +1073)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-10, +69)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-4, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-4, +63)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +11)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-8, +13)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-5, +25)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-36, +288)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +21)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Dec 2022 13:40:14 -0800

Dara Navaei committed 3d977e0 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316 merged staging

Dara Navaei — Wed, 21 Dec 2022 13:24:07 -0800

Dara Navaei committed d32847d on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more in dgfirmware

DEN-14316 merged staging

· /firmware/App/Modes/ModeStandby.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-2, +14)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-5, +21)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-46, +262)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +20)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Changes for code review

Tue, 20 Dec 2022 11:01:54 -0800

Steve Jarpe committed 3f19c30 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more in dgfirmware

DEN-14316-chemical-disinfect. Changes for code review

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-35, +40)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-25, +24)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h	(-1, +17)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14307 initial commit of the heat disinfect active cool mode

Dara Navaei — Sun, 18 Dec 2022 12:46:52 -0800

Dara Navaei committed 73c6b6f on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more in dgfirmware

DEN-14307 initial commit of the heat disinfect active cool mode

· /firmware/App/Modes/ModeHeatDisinfect.c	(-12, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-0, +316)	\| History	\| Source
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.h	(-0, +40)	\| History	\| Source
· /firmware/App/Modes/OperationModes.c	(-12, +22)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14307 updated the cleaning modes per the SRS changes

Dara Navaei — Fri, 16 Dec 2022 11:16:52 -0800

Dara Navaei committed 9426334 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more in dgfirmware

DEN-14307 updated the cleaning modes per the SRS changes

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-23, +36)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-12, +40)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-33, +43)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-5, +37)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-67, +59)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +29)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-65, +108)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 21 Nov 2022 16:51:35 -0800

Dara Navaei committed 5e8f96e on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 179 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14197: Addressed code review comments.

Michael Garthwaite — Mon, 21 Nov 2022 14:19:55 -0800

Michael Garthwaite committed dfc26c6 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 180 more in dgfirmware

DEN-14197: Addressed code review comments.

· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-5, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14307 work in progress updated heat disinfect

Dara Navaei — Sat, 19 Nov 2022 22:11:41 -0800

Dara Navaei committed 224f096 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more in dgfirmware

DEN-14307 work in progress updated heat disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-39, +44)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14197: implemented RO pump profile switching. Implemented Flow to PWM function RO pump with profiles as a parameter....

Michael Garthwaite — Tue, 08 Nov 2022 11:04:56 -0800

Michael Garthwaite committed 29a9a5d on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 180 more in dgfirmware

DEN-14197: implemented RO pump profile switching. Implemented Flow to PWM function RO pump with profiles as a parameter. Created a SW fault for PI profiles out of range.

· /firmware/App/Controllers/ROPump.c	(-38, +87)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-0, +14)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-11, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-5, +7)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 18 Oct 2022 18:05:20 -0700

Dara Navaei committed 0c296ce on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Switches.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

… 25 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13834 addressed the code review comments

Dara Navaei — Wed, 12 Oct 2022 13:06:33 -0700

Dara Navaei committed 696e732 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more in dgfirmware

DEN-13834 addressed the code review comments

· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Fans.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-11, +17)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.h	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-17, +21)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-4, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Voltages.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-8, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13834 added more self test alarms. Added FPGA functions to get the drain pump current feedbakc, speed feedback, and ...

Dara Navaei — Sat, 08 Oct 2022 14:17:38 -0700

Dara Navaei committed d8dbfa7 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more in dgfirmware

DEN-13834 added more self test alarms. Added FPGA functions to get the drain pump current feedbakc, speed feedback, and direction

· /firmware/App/Controllers/Heaters.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +14)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-33, +27)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-0, +39)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-0, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13834 addressed the code review comments and incorporated the PiSquare changes and addressed the reported VectorCAST...

Dara Navaei — Wed, 28 Sep 2022 20:55:53 -0700

Dara Navaei committed e6c4c61 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more in dgfirmware

DEN-13834 addressed the code review comments and incorporated the PiSquare changes and addressed the reported VectorCAST issues

· /firmware/App/Controllers/Heaters.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-12, +12)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Switches.c	(-10, +20)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-20, +14)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-0, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13834 merged staging

Dara Navaei — Tue, 27 Sep 2022 21:08:56 -0700

Dara Navaei committed 2e21405 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more in dgfirmware

DEN-13834 merged staging

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-55, +62)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-7, +7)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-16, +25)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.c

(-1, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-2, +2)

| History

| Source

| Diff

… 16 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 22 Sep 2022 16:48:10 -0700

Dara Navaei committed 256d5cb on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 188 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysateFlow.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.h

(-1, +1)

| History

| Source

| Diff

… 38 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13460 merged staging and resolved merge conflicts

Dara Navaei — Wed, 21 Sep 2022 18:17:44 -0700

Dara Navaei committed d5f2ac4 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 189 more in dgfirmware

DEN-13460 merged staging and resolved merge conflicts

· /firmware/App/Controllers/Heaters.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-38, +45)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.h	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-5, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +30)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +30)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +14)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +121)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +17)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13460 addressed the code review comments

Dara Navaei — Wed, 21 Sep 2022 17:58:34 -0700

Dara Navaei committed 4d637d5 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 189 more in dgfirmware

DEN-13460 addressed the code review comments

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-14, +22)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Voltages.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/CPLD.c	(-1, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13834 updated the getValveState function to return the state of the valve in enum. Updated the treatment blocking da...

Dara Navaei — Wed, 14 Sep 2022 20:36:37 -0700

Dara Navaei committed cb4d35c on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more in dgfirmware

DEN-13834 updated the getValveState function to return the state of the valve in enum. Updated the treatment blocking data to be written to NV data. Updated the FlowSensors driver and renamed the dialysate flow messages to flow sensors messages

· /firmware/App/Controllers/FlowSensors.c	(-16, +15)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-7, +14)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-13, +48)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-28, +27)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-25, +57)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-31, +59)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-74, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-27, +21)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-5, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-25, +60)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-6, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 07 Sep 2022 17:39:05 -0700

Dara Navaei committed 3b70632 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 190 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Heaters.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13834 removed and addressed some of the TODOs in the code base and renamed the heaters' voltage enums for better cla...

Dara Navaei — Mon, 05 Sep 2022 14:43:03 -0700

Dara Navaei committed 4e11c80 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more in dgfirmware

DEN-13834 removed and addressed some of the TODOs in the code base and renamed the heaters' voltage enums for better clarification. Updated the DG RO volume generated calculations

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-5, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-2, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-27, +26)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-11, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-4, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-6, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.h

(-30, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/Thermistors.c

(-1, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.c

(-38, +36)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.h

(-21, +21)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-1, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-3, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeService.c

(-1, +1)

| History

| Source

| Diff

… 5 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13460 updated the FPGA persistent alarm functions

Dara Navaei — Sun, 28 Aug 2022 18:49:41 -0700

Dara Navaei committed 33d262a on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 189 more in dgfirmware

DEN-13460 updated the FPGA persistent alarm functions

· /firmware/App/Controllers/DrainPump.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-25, +24)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-96, +23)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-13460 updated the concentrate pump speed check and the increased the heaters on with no flow to 10 seconds

Dara Navaei — Fri, 12 Aug 2022 12:59:10 -0700

Dara Navaei committed 8fc97ad on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 191 more in dgfirmware

DEN-13460 updated the concentrate pump speed check and the increased the heaters on with no flow to 10 seconds

· /firmware/App/Controllers/ConcentratePumps.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-10, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-6, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merge branch 'staging' into DEN-13427-sw_dev-sprint-75_mg

Michael Garthwaite — Mon, 08 Aug 2022 10:05:42 -0700

Michael Garthwaite committed 849d55b on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 193 more in dgfirmware

Merge branch 'staging' into DEN-13427-sw_dev-sprint-75_mg

· /firmware/App/Controllers/LoadCell.c	(-20, +49)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-22, +73)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +32)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 04 Aug 2022 16:32:32 -0700

Dara Navaei committed a89d6b0 on branch DEN-12974-miscellaneous-flush-issues_bb, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 194 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysateFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.h

(-1, +1)

| History

| Source

| Diff

… 22 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-12931 addressed the code review comments

Dara Navaei — Wed, 03 Aug 2022 17:24:50 -0700

Dara Navaei committed f1cb4be on branch DEN-12931-dg_hd_dev-hd_dg_dvt-update, DEN-12974-miscellaneous-flush-issues_bb and 195 more in dgfirmware

DEN-12931 addressed the code review comments

· /firmware/App/Controllers/ConcentratePumps.c	(-5, +20)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-13, +43)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-23, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-7, +7)	\| History	\| Source	\| Diff