RESOLVED

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Done.

Per our call, you have agreed to leave it above in this location. No change in location

We clarify this thread with a call.

This is no longer applicable due to the changes from our conversation.

I made the changes based on the call we had.

not clear what it means.

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

where do you use this ctor?

I remember and and can we use reconnect as a Paired State.

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

when do we know if that is paired, I think the ticket wants that one, right?

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

move these two in the same location it was, to keep the order.

make them one-liner in front of the if/else and align.

make it
bool isPaired();

please use the shorter constructor provided.
the error needs to be initialized as well, then it becomes the simple one.