Fisheye on dgfirmware/

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15246 addressed a code review script

Dara Navaei — Thu, 11 May 2023 21:31:25 -0700

Dara Navaei committed 98059a6 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

DEN-15246 addressed a code review script

· /firmware/App/Services/AlarmMgmtSWFaults.h

(-16, +16)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15246 addressed a code review comment

Dara Navaei — Thu, 11 May 2023 17:33:36 -0700

Dara Navaei committed e5ad762 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

DEN-15246 addressed a code review comment

· /firmware/App/Services/AlarmMgmtSWFaults.h

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15246 updated the bicarb RO flow from 400 mL/min to 800 mL/min

Dara Navaei — Thu, 11 May 2023 14:38:47 -0700

Dara Navaei committed 8c24d29 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

DEN-15246 updated the bicarb RO flow from 400 mL/min to 800 mL/min

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15246 merged staging

Dara Navaei — Thu, 11 May 2023 14:19:29 -0700

Dara Navaei committed f248e95 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

DEN-15246 merged staging

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-7, +8)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15246 addressed the code review comments

Dara Navaei — Thu, 11 May 2023 14:14:23 -0700

Dara Navaei committed bc85a63 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

DEN-15246 addressed the code review comments

· /firmware/App/Controllers/ConductivitySensors.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' of ssh://dvm-linux02:7999/dg/dgfirmware into staging

Dara Navaei — Fri, 05 May 2023 16:10:21 -0700

Dara Navaei committed 36e7c28 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

Merge branch 'staging' of ssh://dvm-linux02:7999/dg/dgfirmware into staging

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 04 May 2023 17:45:50 -0700

Dara Navaei committed 70f13cf on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 04 May 2023 17:45:40 -0700

Dara Navaei committed 5315092 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merged DEN-15265

Dara Navaei — Thu, 04 May 2023 17:44:13 -0700

Dara Navaei committed 716041c on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

Merged DEN-15265

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15265 addressed a code review comment

Dara Navaei — Thu, 04 May 2023 17:38:47 -0700

Dara Navaei committed f2a05f7 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 122 more in dgfirmware

DEN-15265 addressed a code review comment

· /firmware/App/Modes/ModeGenIdle.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15265 addressed a code review comment

Dara Navaei — Thu, 04 May 2023 17:36:05 -0700

Dara Navaei committed 39aada7 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 122 more in dgfirmware

DEN-15265 addressed a code review comment

· /firmware/App/Modes/ModeGenIdle.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15265, DEN-15236 changed the chemical disinfect monitor to check the dialysate cap not to be closed in during the di...

Dara Navaei — Thu, 04 May 2023 17:05:08 -0700

Dara Navaei committed e258c40 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 122 more in dgfirmware

DEN-15265, DEN-15236 changed the chemical disinfect monitor to check the dialysate cap not to be closed in during the disinfect since the PAA acid is connected to it.

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15265, DEN-15246 changed the heat disinfect's primary target temperature to 60 C prior to filling with water for the...

Dara Navaei — Thu, 04 May 2023 14:36:06 -0700

Dara Navaei committed a33ab8f on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 122 more in dgfirmware

DEN-15265, DEN-15246 changed the heat disinfect's primary target temperature to 60 C prior to filling with water for the actual heat disinfct. Updated the code to properly exit the bad fill state of the gen idle mode once the bad sequence is finished

· /firmware/App/Modes/ModeGenIdle.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15246 removed TestSupport.h from Fans.h

Dara Navaei — Wed, 03 May 2023 13:13:17 -0700

Dara Navaei committed fe131ec on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

DEN-15246 removed TestSupport.h from Fans.h

· /firmware/App/Controllers/Fans.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15246 added more code to support different conductivity sensors calibration tables

Dara Navaei — Wed, 03 May 2023 12:47:22 -0700

Dara Navaei committed fd89ed3 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more in dgfirmware

DEN-15246 added more code to support different conductivity sensors calibration tables

· /firmware/App/Controllers/ConductivitySensors.c	(-27, +70)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Fans.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-0, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15246 changed the bad fill end of state

Dara Navaei — Tue, 02 May 2023 11:01:45 -0700

Dara Navaei committed e77916f on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 122 more in dgfirmware

DEN-15246 changed the bad fill end of state

· /firmware/App/Modes/ModeGenIdle.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 27 Apr 2023 11:39:00 -0700

Dara Navaei committed f246eb6 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 123 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 27 Apr 2023 11:38:51 -0700

Dara Navaei committed 67da3f0 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 123 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merged DEN-15231

Dara Navaei — Thu, 27 Apr 2023 11:36:31 -0700

Dara Navaei committed 087758b on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 123 more in dgfirmware

Merged DEN-15231

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15231 changed the target flow in the mode drain to 300 mL/min and the drain pump's target RPM to 2200

Dara Navaei — Thu, 27 Apr 2023 10:29:27 -0700

Dara Navaei committed 8d3b7ec on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 124 more in dgfirmware

DEN-15231 changed the target flow in the mode drain to 300 mL/min and the drain pump's target RPM to 2200

· /firmware/App/Modes/ModeDrain.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 26 Apr 2023 15:58:33 -0700

Dara Navaei committed f858633 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 124 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 26 Apr 2023 15:58:18 -0700

Dara Navaei committed c7ea396 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 124 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merged DEN-15199

Dara Navaei — Wed, 26 Apr 2023 15:56:37 -0700

Dara Navaei committed f40fbcf on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 124 more in dgfirmware

Merged DEN-15199

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15150 increased the inlet water high temperature limit to 45 C

Dara Navaei — Wed, 26 Apr 2023 14:17:32 -0700

Dara Navaei committed 6f1e859 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 125 more in dgfirmware

DEN-15150 increased the inlet water high temperature limit to 45 C

· /firmware/App/Controllers/TemperatureSensors.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15199 addressed the code review comment

Dara Navaei — Wed, 26 Apr 2023 09:13:40 -0700

Dara Navaei committed 4d53c13 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 125 more in dgfirmware

DEN-15199 addressed the code review comment

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15199 addressed the code review comments

Dara Navaei — Wed, 26 Apr 2023 08:55:04 -0700

Dara Navaei committed c09da04 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 125 more in dgfirmware

DEN-15199 addressed the code review comments

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +7)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-15199-fw_dn_sprint_95

Dara Navaei — Wed, 26 Apr 2023 08:25:12 -0700

Dara Navaei committed 8f240a9 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 125 more in dgfirmware

Merge branch 'staging' into DEN-15199-fw_dn_sprint_95

· /firmware/App/Controllers/DrainPump.c

(-5, +6)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15199 added to code to check for dialin check in

Dara Navaei — Wed, 26 Apr 2023 08:22:57 -0700

Dara Navaei committed def0601 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 125 more in dgfirmware

DEN-15199 added to code to check for dialin check in

· /firmware/App/Controllers/DrainPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +18)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +80)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +10)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15199 addressed the code review comments

Dara Navaei — Mon, 24 Apr 2023 09:15:02 -0700

Dara Navaei committed 1256c2a on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 125 more in dgfirmware

DEN-15199 addressed the code review comments

· /firmware/App/Modes/ModeFill.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15199 renamed the test configuration code

Dara Navaei — Fri, 21 Apr 2023 09:47:41 -0700

Dara Navaei committed d9c2c8e on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 125 more in dgfirmware

DEN-15199 renamed the test configuration code

· /firmware/App/Modes/ModeFill.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-7, +14)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-1, +1)	\| History	\| Source	\| Diff