Thanks for reminding me the situation with the comment.
that is right in View classes we need to.
maybe later we can move these checks all in the settings controller, from this view.

RESOLVED.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Changed

Added.

Added.

Changed based on how GuiView handles the connection from a created-in-QML object.

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

• the API is just emitting the signal
• and is not responsible for the usage.
• any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)

Please move to ApplicationController class.

please check, lists are not empty.
can be checked by private member variable:

isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();

add an empty line before and after

please align
SIGNAL(did
SLOT( on

please do not use else.
make it like the others on top.
Look at lines 79 - 83.
And insert it in between lines 89,90
with two empty line on top and bottom of the if block

if ( ! codition ) {
  err = ;
  LOG_ ;
  return err;
}

thanks