Fisheye on dgfirmware/firmware/App/Controllers

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Code review changes

Fri, 08 Sep 2023 13:29:52 -0700

Bill Bracken committed 48731d3 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Code review changes

· /firmware/App/Controllers/Pressures.c

(-3, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Code review changes

Fri, 08 Sep 2023 13:27:09 -0700

Bill Bracken committed 1c2d10b on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Code review changes

· /firmware/App/Controllers/Pressures.c

(-5, +8)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Remove unnecessary code per recent change.

Fri, 08 Sep 2023 11:50:44 -0700

Bill Bracken committed 2123291 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Remove unnecessary code per recent change.

· /firmware/App/Controllers/Pressures.c

(-4, +0)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Change alarm 152 limits

Fri, 08 Sep 2023 11:45:56 -0700

Bill Bracken committed 15615b5 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Change alarm 152 limits

· /firmware/App/Controllers/Pressures.c

(-5, +13)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Surender changes.

Fri, 08 Sep 2023 11:33:27 -0700

Bill Bracken committed 1561d34 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Surender changes.

· /firmware/App/Controllers/Pressures.c

(-2, +7)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Update per code review comments

Fri, 01 Sep 2023 13:35:08 -0700

Bill Bracken committed 2fcf9be on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Update per code review comments

· /firmware/App/Controllers/ROPump.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Requirements changes

Thu, 31 Aug 2023 23:23:43 -0700

Bill Bracken committed 758a99a on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Requirements changes

· /firmware/App/Controllers/ROPump.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Change to alarm limits and persistence values

Thu, 31 Aug 2023 14:38:15 -0700

Bill Bracken committed 5a76689 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Change to alarm limits and persistence values

· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Move max pwm check to execROPumpMonitor

Wed, 30 Aug 2023 10:08:05 -0700

Bill Bracken committed b37ec50 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Move max pwm check to execROPumpMonitor

· /firmware/App/Controllers/ROPump.c

(-6, +5)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

Fri, 25 Aug 2023 17:23:56 -0700

Bill Bracken committed 4a57af4 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

· /firmware/App/Controllers/ROPump.c

(-1, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Address code review comments

Fri, 25 Aug 2023 16:59:31 -0700

Bill Bracken committed b9ffb58 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Address code review comments

· /firmware/App/Controllers/ROPump.c

(-3, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 24 Aug 2023 12:58:01 -0700

Dara Navaei committed 48e631c on branch master, DEN-14706-can-messge-not-acked-fix and 74 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Voltages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Voltages.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-16091 changed the trimmer heater's persistent alarm from 10 seconds to 12 seconds

Dara Navaei — Thu, 24 Aug 2023 10:20:16 -0700

Dara Navaei committed cfc93e9 on branch master, DEN-14706-can-messge-not-acked-fix and 74 more in dgfirmware

DEN-16091 changed the trimmer heater's persistent alarm from 10 seconds to 12 seconds

· /firmware/App/Controllers/Heaters.c

(-3, +4)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-16308 updated the DG watchdog and safety shutdown POSTs

Dara Navaei — Thu, 24 Aug 2023 09:50:55 -0700

Dara Navaei committed 31f5b77 on branch master, DEN-14706-can-messge-not-acked-fix and 74 more in dgfirmware

DEN-16308 updated the DG watchdog and safety shutdown POSTs

· /firmware/App/Controllers/Voltages.c	(-0, +16)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Voltages.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-7, +7)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Change persistence to 12 seconds

Wed, 23 Aug 2023 10:59:22 -0700

Bill Bracken committed 2632acc on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Change persistence to 12 seconds

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Change #define name

Mon, 21 Aug 2023 14:31:08 -0700

Bill Bracken committed e26d6d6 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Change #define name

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Correct #define name

Fri, 18 Aug 2023 13:59:06 -0700

Bill Bracken committed 719751a on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Correct #define name

· /firmware/App/Controllers/ROPump.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13973 Rename alarm

Fri, 18 Aug 2023 13:53:50 -0700

Bill Bracken committed 784b7a2 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-13973 Rename alarm

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Add RO Pump max PWM alarm

Fri, 18 Aug 2023 13:31:01 -0700

Bill Bracken committed e57a786 on branch master, DEN-15791-dg-software-design-description and 64 more in dgfirmware

DEN-15973 Add RO Pump max PWM alarm

· /firmware/App/Controllers/ROPump.c

(-0, +11)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 17:32:53 -0700

Dara Navaei committed d0536d7 on branch master, DEN-14706-can-messge-not-acked-fix and 79 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15974 removed the clearance time of the persistence alarms of the concentrate pumps

Dara Navaei — Wed, 16 Aug 2023 13:27:46 -0700

Dara Navaei committed af18131 on branch master, DEN-14706-can-messge-not-acked-fix and 80 more in dgfirmware

DEN-15974 removed the clearance time of the persistence alarms of the concentrate pumps

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 11 Aug 2023 17:11:55 -0700

Dara Navaei committed 1cdf34a on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 83 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16212 fixed the concentrate pumps speed alarm

Dara Navaei — Fri, 11 Aug 2023 16:53:00 -0700

Dara Navaei committed 988ec87 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 84 more in dgfirmware

DEN-16212 fixed the concentrate pumps speed alarm

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 09 Aug 2023 17:36:10 -0700

Dara Navaei committed 8ebab81 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 86 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed...

Dara Navaei — Wed, 09 Aug 2023 16:44:24 -0700

Dara Navaei committed 56b1e41 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 87 more in dgfirmware

DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed is called

· /firmware/App/Controllers/ConcentratePumps.c	(-8, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 08 Aug 2023 13:38:26 -0700

Dara Navaei committed 5fc30ce on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 87 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DIAL-273: updated documentation.

Michael Garthwaite — Mon, 07 Aug 2023 10:15:55 -0700

Michael Garthwaite committed 4e25839 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 88 more in dgfirmware

DIAL-273: updated documentation.

· /firmware/App/Controllers/FlowSensors.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DIAL-273: updated flow sensor override to handle raw values.

Michael Garthwaite — Thu, 03 Aug 2023 11:22:23 -0700

Michael Garthwaite committed 89d02f3 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 88 more in dgfirmware

DIAL-273: updated flow sensor override to handle raw values.

· /firmware/App/Controllers/FlowSensors.c	(-5, +21)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +11)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 28 Jul 2023 15:04:28 -0700

Dara Navaei committed 75868c8 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 93 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Switches.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15614 removed the extra space

Dara Navaei — Fri, 28 Jul 2023 10:09:29 -0700

Dara Navaei committed 79b201d on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 93 more in dgfirmware

DEN-15614 removed the extra space

· /firmware/App/Controllers/Switches.c

(-2, +2)

| History

| Source

| Diff