Fisheye on dgfirmware/firmware/App

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16212 fixed the concentrate pumps speed alarm

Dara Navaei — Fri, 11 Aug 2023 16:53:00 -0700

Dara Navaei committed 988ec87 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 83 more in dgfirmware

DEN-16212 fixed the concentrate pumps speed alarm

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 10 Aug 2023 08:36:49 -0700

Dara Navaei committed c2619f4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 84 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 10 Aug 2023 08:36:36 -0700

Dara Navaei committed 1a21988 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 84 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

Michael Garthwaite — Thu, 10 Aug 2023 08:15:41 -0700

Michael Garthwaite committed cfcb924 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

· /firmware/App/Modes/ModeFill.c	(-22, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 09 Aug 2023 17:36:18 -0700

Dara Navaei committed 72127a3 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 09 Aug 2023 17:36:10 -0700

Dara Navaei committed 8ebab81 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed...

Dara Navaei — Wed, 09 Aug 2023 16:44:24 -0700

Dara Navaei committed 56b1e41 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more in dgfirmware

DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed is called

· /firmware/App/Controllers/ConcentratePumps.c	(-8, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

Michael Garthwaite — Wed, 09 Aug 2023 16:25:25 -0700

Michael Garthwaite committed 3a2b4f4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

· /firmware/App/Services/SystemCommMessages.c

(-7, +14)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: code review comments.

Michael Garthwaite — Wed, 09 Aug 2023 16:24:54 -0700

Michael Garthwaite committed 515de7f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: code review comments.

· /firmware/App/Modes/ModeDrain.h

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: code review comments.

Michael Garthwaite — Wed, 09 Aug 2023 14:44:44 -0700

Michael Garthwaite committed 8738090 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: code review comments.

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15125 addressed the compiler warnings

Dara Navaei — Wed, 09 Aug 2023 13:33:55 -0700

Dara Navaei committed e7456f2 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more in dgfirmware

DEN-15125 addressed the compiler warnings

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-8, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-19, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: fixed warnings

Michael Garthwaite — Wed, 09 Aug 2023 13:16:17 -0700

Michael Garthwaite committed 46d5a77 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: fixed warnings

· /firmware/App/Modes/ModeDrain.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: fixed compiler error.

Michael Garthwaite — Wed, 09 Aug 2023 13:10:18 -0700

Michael Garthwaite committed 3949d0c on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: fixed compiler error.

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: added drain mode msg_id to publish.

Michael Garthwaite — Wed, 09 Aug 2023 13:09:42 -0700

Michael Garthwaite committed f64f930 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: added drain mode msg_id to publish.

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16125 removed the code in chemical flush that was checking the drain timeout in some of the states

Dara Navaei — Wed, 09 Aug 2023 12:41:00 -0700

Dara Navaei committed 14c3c2a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more in dgfirmware

DEN-16125 removed the code in chemical flush that was checking the drain timeout in some of the states

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-34, +0)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 08 Aug 2023 13:38:34 -0700

Dara Navaei committed cf79840 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 08 Aug 2023 13:38:26 -0700

Dara Navaei committed 5fc30ce on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: code review comments

Michael Garthwaite — Tue, 08 Aug 2023 13:37:50 -0700

Michael Garthwaite committed 8a9d78a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: code review comments

· /firmware/App/Modes/ModeFill.c

(-1, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: implemented drain mode broadcast overrides.

Michael Garthwaite — Tue, 08 Aug 2023 13:16:02 -0700

Michael Garthwaite committed 65e9ace on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: implemented drain mode broadcast overrides.

· /firmware/App/Modes/ModeDrain.c	(-0, +52)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +32)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: fixed drain mode publish not being called. code review comments.

Michael Garthwaite — Tue, 08 Aug 2023 12:54:34 -0700

Michael Garthwaite committed 2b66814 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: fixed drain mode publish not being called. code review comments.

· /firmware/App/Modes/ModeDrain.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.h	(-0, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): code review comments.

Michael Garthwaite — Tue, 08 Aug 2023 11:31:29 -0700

Michael Garthwaite committed bb87f31 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 87 more in dgfirmware

code review comments.

· /firmware/App/Modes/OperationModes.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: code review comments

Michael Garthwaite — Tue, 08 Aug 2023 10:27:23 -0700

Michael Garthwaite committed 7c3b624 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: code review comments

· /firmware/App/Modes/ModeDrain.c

(-9, +6)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: implemented bad fill signal on fill and drain modes. Implemented drain mode broadcast

Michael Garthwaite — Mon, 07 Aug 2023 16:13:09 -0700

Michael Garthwaite committed 7295613 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: implemented bad fill signal on fill and drain modes. Implemented drain mode broadcast

· /firmware/App/Modes/ModeDrain.c	(-2, +36)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.h	(-1, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-0, +13)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15570: fixed operation status event to be sent after updating currentMode.

Michael Garthwaite — Mon, 07 Aug 2023 14:20:53 -0700

Michael Garthwaite committed 7f93e26 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 87 more in dgfirmware

DEN-15570: fixed operation status event to be sent after updating currentMode.

· /firmware/App/Modes/OperationModes.c

(-2, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DIAL-273: updated documentation.

Michael Garthwaite — Mon, 07 Aug 2023 10:15:55 -0700

Michael Garthwaite committed 4e25839 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 87 more in dgfirmware

DIAL-273: updated documentation.

· /firmware/App/Controllers/FlowSensors.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 03 Aug 2023 15:15:15 -0700

Dara Navaei committed 5092eca on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 87 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DIAL-273: fixed array payload decoding.

Michael Garthwaite — Thu, 03 Aug 2023 11:27:52 -0700

Michael Garthwaite committed 4364274 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 87 more in dgfirmware

DIAL-273: fixed array payload decoding.

· /firmware/App/Services/SystemCommMessages.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DIAL-273: updated flow sensor override to handle raw values.

Michael Garthwaite — Thu, 03 Aug 2023 11:22:23 -0700

Michael Garthwaite committed 89d02f3 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 87 more in dgfirmware

DIAL-273: updated flow sensor override to handle raw values.

· /firmware/App/Controllers/FlowSensors.c	(-5, +21)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +11)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 02 Aug 2023 16:41:45 -0700

Dara Navaei committed 658940a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 87 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 02 Aug 2023 16:41:37 -0700

Dara Navaei committed 52f076a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 87 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +1)

| History

| Source

| Diff