Fisheye on application/sources/gui/qml/components/ImageText.qml https://devapps.diality.us/changelog/~br%3DDEN-16657-UI-BN-S116-LogUpload-Compression/application/sources/gui/qml/components/ImageText.qml Recent activity in "application" under directory /sources/gui/qml/components/ImageText.qml UI-DEN-7820-1: closed by Behrouz NematiPour Thu, 29 Apr 2021 09:44:53 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7820-1 https://devapps.diality.us/cru/UI-DEN-7820-1 Behrouz NematiPour Closed UI-DEN-7820-1 ]]> UI-DEN-7820-1: reviewers finished Tue, 27 Apr 2021 10:51:03 -0700 https://devapps.diality.us/cru/UI-DEN-7820-1 https://devapps.diality.us/cru/UI-DEN-7820-1 plucia  (deleted user) and pmontazemi  (deleted user) finished reviewing UI-DEN-7820-1 UI-DEN-7820_UI DEV Post Treatment ]]> UI-DEN-7820-1: comment by plucia "RESOLVED" Tue, 27 Apr 2021 10:49:43 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7820-1/#c9635 https://devapps.diality.us/cru/UI-DEN-7820-1/#c9635 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-7820-1

RESOLVED

]]> UI-DEN-7820-1: comment by Behrouz NematiPour "Updated." Mon, 26 Apr 2021 15:52:35 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7820-1/#c9630 https://devapps.diality.us/cru/UI-DEN-7820-1/#c9630 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7820-1

Updated.

]]> UI-DEN-7820-1: comment by plucia "Looks like this needs to be updated" Mon, 26 Apr 2021 11:15:15 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7820-1/#c9629 https://devapps.diality.us/cru/UI-DEN-7820-1/#c9629 plucia  (deleted user) commented on UI-DEN-7820-1

Looks like this needs to be updated

]]> UI-DEN-7820-1: comment by pmontazemi "RESOLVED." Thu, 22 Apr 2021 13:31:12 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-7820-1/#c9566 https://devapps.diality.us/cru/UI-DEN-7820-1/#c9566 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-7820-1

RESOLVED.

]]> UI-DEN-7820-1: comment by Behrouz NematiPour "That is the function signature and doesn't have..." Thu, 22 Apr 2021 12:25:18 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7820-1/#c9565 https://devapps.diality.us/cru/UI-DEN-7820-1/#c9565 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-7820-1

That is the function signature and doesn't have to have any parameter defined if it is not being used and no argument is passing to it.
This way we don't need to use the Q_UNUSED(vData); anymore for parameters not being used.

]]> UI-DEN-7820-1: comment by pmontazemi "Dereferencing which parameter here? (sorry I ha..." Thu, 22 Apr 2021 12:17:54 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-7820-1/#c9564 https://devapps.diality.us/cru/UI-DEN-7820-1/#c9564 pmontazemi  (deleted user) commented on UI-DEN-7820-1

Dereferencing which parameter here? (sorry I have never seen this in the past)

]]> UI-DEN-7820-1: started by Dara Navaei Wed, 21 Apr 2021 23:22:13 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-7820-1 https://devapps.diality.us/cru/UI-DEN-7820-1 Dara Navaei started review UI-DEN-7820-1 ]]> UI-DEN-6631-1: closed by Behrouz NematiPour Tue, 16 Feb 2021 16:23:46 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-6631-1 https://devapps.diality.us/cru/UI-DEN-6631-1 Behrouz NematiPour Closed UI-DEN-6631-1 ]]> UI-DEN-6631-1: reviewers finished Tue, 16 Feb 2021 16:09:41 -0800 https://devapps.diality.us/cru/UI-DEN-6631-1 https://devapps.diality.us/cru/UI-DEN-6631-1 plucia  (deleted user) and pmontazemi  (deleted user) finished reviewing UI-DEN-6631-1 UI-DEN-6631_UI DEV POST Treatment Rinseback ]]> UI-DEN-6631-1: comment by plucia "RESOLVED" Tue, 16 Feb 2021 13:49:16 -0800 plucia https://devapps.diality.us/cru/UI-DEN-6631-1/#c8157 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8157 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-6631-1

RESOLVED

]]> UI-DEN-6631-1: comment by plucia "RESOLVED" Tue, 16 Feb 2021 13:48:51 -0800 plucia https://devapps.diality.us/cru/UI-DEN-6631-1/#c8156 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8156 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-6631-1

RESOLVED

]]> UI-DEN-6631-1: comment by Behrouz NematiPour "Removed." Tue, 16 Feb 2021 13:48:42 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-6631-1/#c8155 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8155 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-6631-1

Removed.

]]> UI-DEN-6631-1: comment by Behrouz NematiPour "Thanks for catching that, Fixed." Tue, 16 Feb 2021 13:48:23 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-6631-1/#c8154 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8154 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-6631-1

Thanks for catching that,
Fixed.

]]> UI-DEN-6631-1: comment by plucia "I think you meant fontsPixelCreateTreatmentTabl..." Tue, 16 Feb 2021 13:42:15 -0800 plucia https://devapps.diality.us/cru/UI-DEN-6631-1/#c8153 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8153 plucia  (deleted user) commented on UI-DEN-6631-1

I think you meant fontsPixelCreateTreatmentTable

]]> UI-DEN-6631-1: comment by plucia "These are currently unused, maybe they can be d..." Mon, 15 Feb 2021 13:19:18 -0800 plucia https://devapps.diality.us/cru/UI-DEN-6631-1/#c8112 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8112 plucia  (deleted user) commented on UI-DEN-6631-1

These are currently unused, maybe they can be deleted?

]]> UI-DEN-6631-1: comment by pmontazemi "RESOLVED." Tue, 16 Feb 2021 13:04:44 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-6631-1/#c8147 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8147 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-6631-1

RESOLVED.

]]> UI-DEN-6631-1: comment by pmontazemi "RESOLVED." Tue, 16 Feb 2021 13:03:39 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-6631-1/#c8146 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8146 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-6631-1

RESOLVED.

]]> UI-DEN-6631-1: comment by pmontazemi "RESOLVED." Tue, 16 Feb 2021 13:03:29 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-6631-1/#c8145 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8145 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-6631-1

RESOLVED.

]]> UI-DEN-6631-1: comment by Behrouz NematiPour "it is a kind of hierarchy commenting that the /..." Tue, 16 Feb 2021 11:22:43 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-6631-1/#c8143 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8143 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-6631-1

it is a kind of hierarchy commenting that the //// is the title and the rest beneath that are like 1.1 and 1.2 so it helps to organize better.

]]> UI-DEN-6631-1: comment by pmontazemi "Only two "/" for comments in QML." Tue, 16 Feb 2021 11:15:51 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-6631-1/#c8139 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8139 pmontazemi  (deleted user) commented on UI-DEN-6631-1

Only two "/" for comments in QML.

]]> UI-DEN-6631-1: comment by pmontazemi "RESOLVED." Tue, 16 Feb 2021 11:13:16 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-6631-1/#c8138 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8138 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-6631-1

RESOLVED.

]]> UI-DEN-6631-1: comment by Behrouz NematiPour "Removed." Mon, 15 Feb 2021 17:18:47 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-6631-1/#c8120 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8120 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-6631-1

Removed.

]]> UI-DEN-6631-1: comment by Behrouz NematiPour "Removed." Mon, 15 Feb 2021 17:18:35 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-6631-1/#c8119 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8119 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-6631-1

Removed.

]]> UI-DEN-6631-1: comment by Behrouz NematiPour "fixed." Mon, 15 Feb 2021 17:18:26 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-6631-1/#c8118 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8118 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-6631-1

fixed.

]]> UI-DEN-6631-1: comment by pmontazemi "Remove perhaps which suggest incertitude in Cla..." Mon, 15 Feb 2021 13:05:14 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-6631-1/#c8110 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8110 pmontazemi  (deleted user) commented on UI-DEN-6631-1

Remove perhaps which suggest incertitude in Class B code.

]]> UI-DEN-6631-1: comment by pmontazemi "it is as formal (instead of it's as informal)" Mon, 15 Feb 2021 13:04:46 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-6631-1/#c8109 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8109 pmontazemi  (deleted user) commented on UI-DEN-6631-1

it is as formal (instead of it's as informal)

]]> UI-DEN-6631-1: comment by pmontazemi "Remove extra lines." Mon, 15 Feb 2021 13:03:49 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-6631-1/#c8108 https://devapps.diality.us/cru/UI-DEN-6631-1/#c8108 pmontazemi  (deleted user) commented on UI-DEN-6631-1

Remove extra lines.

]]> UI-DEN-6631-1: started by Behrouz NematiPour Sat, 13 Feb 2021 17:39:09 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-6631-1 https://devapps.diality.us/cru/UI-DEN-6631-1 Behrouz NematiPour started review UI-DEN-6631-1 ]]>