Fisheye on dgfirmware/firmware/App

dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): DEN-16674 updated the code from staging

Dara Navaei — Fri, 01 Mar 2024 09:27:38 -0800

Dara Navaei committed 61c74b7 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16674-td2-calibration-feature and 11 more in dgfirmware

DEN-16674 updated the code from staging

· /firmware/App/Controllers/ConductivitySensors.c	(-10, +21)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-46, +14)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +68)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-7, +94)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +28)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 addressed the code reivew comment

Dara Navaei — Thu, 29 Feb 2024 13:04:22 -0800

Dara Navaei committed 9663d70 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 addressed the code reivew comment

· /firmware/App/Modes/ModeFill.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 addressed the code review comments

Dara Navaei — Thu, 29 Feb 2024 10:59:06 -0800

Dara Navaei committed 63c6107 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 addressed the code review comments

· /firmware/App/Modes/ModeFill.c

(-30, +33)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 updated the code for mode fill calibration check command

Dara Navaei — Thu, 29 Feb 2024 08:36:29 -0800

Dara Navaei committed 8e62ede on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 updated the code for mode fill calibration check command

· /firmware/App/Modes/ModeFill.c	(-0, +80)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +33)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16683 updated the conductivity sensor temperature compensation calibration enum names

Dara Navaei — Fri, 23 Feb 2024 17:20:19 -0800

Dara Navaei committed a27432b on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16683 updated the conductivity sensor temperature compensation calibration enum names

· /firmware/App/Controllers/ConductivitySensors.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16683 added code to get and apply the conductivity sensors' temperature compensation calibration record

Dara Navaei — Fri, 23 Feb 2024 16:57:05 -0800

Dara Navaei committed 20e605a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16683 added code to get and apply the conductivity sensors' temperature compensation calibration record

· /firmware/App/Controllers/ConductivitySensors.c

(-10, +21)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 changed the speed of the acid concentrate pump. CD2 will be used for acid check in the Mode Fill

Dara Navaei — Fri, 23 Feb 2024 09:33:58 -0800

Dara Navaei committed b41ffef on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16682 changed the speed of the acid concentrate pump. CD2 will be used for acid check in the Mode Fill

· /firmware/App/Modes/ModeFill.c

(-6, +7)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16681 addressed the code review comment

Dara Navaei — Thu, 22 Feb 2024 10:57:31 -0800

Dara Navaei committed 3acd796 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16681 addressed the code review comment

· /firmware/App/Modes/ModeFill.c

(-4, +4)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16681 changed the tolerances of acid and bicarb check in Mdoe Fill

Dara Navaei — Thu, 22 Feb 2024 09:17:18 -0800

Dara Navaei committed 8432595 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16681 changed the tolerances of acid and bicarb check in Mdoe Fill

· /firmware/App/Modes/ModeFill.c

(-2, +4)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-213 added code to only check the drain pump's direction alarm if the feedback RPM is greater than 0

Dara Navaei — Wed, 21 Feb 2024 15:29:40 -0800

Dara Navaei committed d0e7ad1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DENBUG-213 added code to only check the drain pump's direction alarm if the feedback RPM is greater than 0

· /firmware/App/Controllers/DrainPump.c

(-46, +14)

| History

| Source

| Diff

dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 21 Feb 2024 10:35:18 -0800

Dara Navaei committed 6b9fca1 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16674-td2-calibration-feature and 11 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Feb 2024 10:35:00 -0800

Dara Navaei committed e592fa7 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16674-td2-calibration-feature and 11 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): DEN-16666 added new events in Mode Fill

Dara Navaei — Wed, 21 Feb 2024 09:55:52 -0800

Dara Navaei committed 8859b84 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16666-log-passing-results-of-self-test-2 and 12 more in dgfirmware

DEN-16666 added new events in Mode Fill

· /firmware/App/Modes/ModeFill.c

(-2, +7)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 updated the temperature sensors calibration record alarm

Dara Navaei — Sat, 17 Feb 2024 17:04:09 -0800

Dara Navaei committed 0eb6b6c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 updated the temperature sensors calibration record alarm

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 made the UV reactors persistent alarm clearance period to 0 ms

Dara Navaei — Fri, 16 Feb 2024 16:54:16 -0800

Dara Navaei committed 623fd92 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 made the UV reactors persistent alarm clearance period to 0 ms

· /firmware/App/Controllers/UVReactors.c

(-4, +4)

| History

| Source

| Diff

dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 15 Feb 2024 16:11:50 -0800

Dara Navaei committed c84add0 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16666-log-passing-results-of-self-test-2 and 12 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 15 Feb 2024 16:11:32 -0800

Dara Navaei committed 8efe5f0 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16666-log-passing-results-of-self-test-2 and 12 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): DEN-16587 Update to match other branch.

Thu, 15 Feb 2024 16:05:17 -0800

Darren Cox committed 7a58e4a on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml-p1 and 13 more in dgfirmware

DEN-16587 Update to match other branch.

· /firmware/App/Modes/ModeGenIdle.c	(-18, +30)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +24)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 15 Feb 2024 15:47:05 -0800

Dara Navaei committed 34d90dd on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 15 Feb 2024 15:46:48 -0800

Dara Navaei committed 84989e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 added an alarm to check the status of the temperature sensors calibration record in POST

Dara Navaei — Thu, 15 Feb 2024 13:51:49 -0800

Dara Navaei committed b097216 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 added an alarm to check the status of the temperature sensors calibration record in POST

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 updated the temperature sensors calibration function

Dara Navaei — Thu, 15 Feb 2024 13:36:25 -0800

Dara Navaei committed b5eba17 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 updated the temperature sensors calibration function

· /firmware/App/Controllers/TemperatureSensors.c

(-11, +14)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 added code to apply the calibration values to the inline temperature sensors

Dara Navaei — Thu, 15 Feb 2024 13:22:06 -0800

Dara Navaei committed 25e1aca on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 added code to apply the calibration values to the inline temperature sensors

· /firmware/App/Controllers/TemperatureSensors.c

(-0, +64)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

Thu, 15 Feb 2024 12:16:52 -0800

Darren Cox committed 3a007e0 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

· /firmware/App/Modes/ModeGenIdle.c	(-19, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +24)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 14 Feb 2024 16:29:33 -0800

Dara Navaei committed aa4f497 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 fix typo.

Tue, 13 Feb 2024 16:26:29 -0800

Darren Cox committed 4366794 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 fix typo.

· /firmware/App/Modes/ModeGenIdle.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): DEN-16587 Only check for unwanted fill in treatment mode. Pretreat mode does transfers that cause alarm 274.

Tue, 13 Feb 2024 16:24:50 -0800

Darren Cox committed 99378e2 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml-p1 and 13 more in dgfirmware

DEN-16587 Only check for unwanted fill in treatment mode. Pretreat mode does transfers that cause alarm 274.

· /firmware/App/Modes/ModeGenIdle.c

(-2, +5)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Only check for unwanted full in treatment mode. Pretreat has transfers from one reservoir to other.

Tue, 13 Feb 2024 15:04:49 -0800

Darren Cox committed dcb42b5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Only check for unwanted full in treatment mode. Pretreat has transfers from one reservoir to other.

· /firmware/App/Modes/ModeGenIdle.c

(-2, +5)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 09 Feb 2024 13:49:22 -0800

Dara Navaei committed a2f0d71 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 09 Feb 2024 13:49:14 -0800

Dara Navaei committed d00c946 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff