Fisheye on hdfirmware/firmware/App/Modes

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16779 added two breaks per cppcheck warning

Dara Navaei — Wed, 20 Mar 2024 16:47:06 -0700

Dara Navaei committed 67fae75 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16779 added two breaks per cppcheck warning

· /firmware/App/Modes/SelfTests.c

(-0, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 19 Mar 2024 16:48:56 -0700

Dara Navaei committed c3043e7 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 added enable chemical disinfect institutional record range check

Dara Navaei — Tue, 19 Mar 2024 13:36:41 -0700

Dara Navaei committed e9f0b99 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 added enable chemical disinfect institutional record range check

· /firmware/App/Modes/ModeTreatmentParams.c

(-0, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 added another check upon receiving the institutional record to make sure the minimum set is less than maximum ...

Dara Navaei — Tue, 19 Mar 2024 13:27:40 -0700

Dara Navaei committed ba102c1 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 added another check upon receiving the institutional record to make sure the minimum set is less than maximum set value

· /firmware/App/Modes/ModeTreatmentParams.c

(-0, +12)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 addressed the code review comments

Dara Navaei — Tue, 19 Mar 2024 09:30:17 -0700

Dara Navaei committed 410a693 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 addressed the code review comments

· /firmware/App/Modes/ModeStandby.c

(-6, +8)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 fixed a typo

Dara Navaei — Mon, 18 Mar 2024 18:45:46 -0700

Dara Navaei committed ba722a0 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 fixed a typo

· /firmware/App/Modes/ModeStandby.c	(-6, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 added code to check the status of the chemical disinfect enable/disable in institutional record in NV data man...

Dara Navaei — Mon, 18 Mar 2024 15:28:53 -0700

Dara Navaei committed 14be630 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 added code to check the status of the chemical disinfect enable/disable in institutional record in NV data management

· /firmware/App/Modes/ModeStandby.c

(-4, +11)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 14 Mar 2024 14:00:37 -0700

Dara Navaei committed b1097bd on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeTreatment.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16725 converted the calculated UF volume from mL to L prior to checking it against the lower and upper range of the ...

Dara Navaei — Thu, 14 Mar 2024 12:55:15 -0700

Dara Navaei committed d2c7bd1 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16725 converted the calculated UF volume from mL to L prior to checking it against the lower and upper range of the UF volume treatment parameters in the set duration time function in the mode treatment

· /firmware/App/Modes/ModeTreatment.c

(-2, +3)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16728 updated the treatment duration function

Dara Navaei — Thu, 14 Mar 2024 11:27:45 -0700

Dara Navaei committed 1a0f474 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16728 updated the treatment duration function

· /firmware/App/Modes/ModeTreatment.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 14 Mar 2024 10:16:17 -0700

Dara Navaei committed 38a2dea on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16713 changed the code per VectorCAST results

Dara Navaei — Wed, 13 Mar 2024 18:23:45 -0700

Dara Navaei committed 87d315e on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16713 changed the code per VectorCAST results

· /firmware/App/Modes/ModeTreatment.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16725 updated the treament time rejection reason

Dara Navaei — Wed, 13 Mar 2024 15:28:04 -0700

Dara Navaei committed dc200ed on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16725 updated the treament time rejection reason

· /firmware/App/Modes/ModeTreatment.c

(-2, +1)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16728 made a change in the treatment parameters to be able to use the 1-minute treatment time. DEN-16725 made a chan...

Dara Navaei — Wed, 13 Mar 2024 15:18:12 -0700

Dara Navaei committed a357327 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16728 made a change in the treatment parameters to be able to use the 1-minute treatment time. DEN-16725 made a change in the treatment duration function to check the edges of the ultrafiltration volume

· /firmware/App/Modes/ModeTreatment.c	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-2, +4)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16728 added a condition to be able to run the 1-minute test configuration while it is not in the minimum range of th...

Dara Navaei — Wed, 13 Mar 2024 09:07:46 -0700

Dara Navaei committed 93b33e0 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16728 added a condition to be able to run the 1-minute test configuration while it is not in the minimum range of the institutional configurations

· /firmware/App/Modes/ModeTreatment.c

(-2, +5)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16713 continued with running VectorCAST tests and addressed a code review comment

Dara Navaei — Tue, 12 Mar 2024 13:23:37 -0700

Dara Navaei committed 88dd475 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16713 continued with running VectorCAST tests and addressed a code review comment

· /firmware/App/Modes/ModeTreatmentParams.c

(-3, +16)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16713 added more commenst to explain the reason that some parts of code has been masked off from VectorCAST

Dara Navaei — Tue, 12 Mar 2024 08:48:16 -0700

Dara Navaei committed efb29d2 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16713 added more commenst to explain the reason that some parts of code has been masked off from VectorCAST

· /firmware/App/Modes/ModeTreatmentParams.c

(-0, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16713 work in progress, continued with running VectorCAST cases and updated the code

Dara Navaei — Mon, 11 Mar 2024 18:32:10 -0700

Dara Navaei committed 24af8f0 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16713 work in progress, continued with running VectorCAST cases and updated the code

· /firmware/App/Modes/ModeTreatmentParams.c	(-2, +59)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.h	(-0, +4)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 08 Mar 2024 16:16:11 -0800

Dara Navaei committed f5d4fec on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Buttons.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Switches.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 removed the commented out code

Dara Navaei — Fri, 08 Mar 2024 14:41:37 -0800

Dara Navaei committed dda00e2 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 removed the commented out code

· /firmware/App/Modes/ModeTreatmentParams.c

(-61, +0)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 changed the upper and lower range get functions in the treatment parameters

Dara Navaei — Fri, 08 Mar 2024 12:08:05 -0800

Dara Navaei committed 5a6f0b9 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 changed the upper and lower range get functions in the treatment parameters

· /firmware/App/Modes/ModeTreatment.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-6, +167)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 addressed the code review comment

Dara Navaei — Thu, 07 Mar 2024 15:06:36 -0800

Dara Navaei committed 03ca189 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 addressed the code review comment

· /firmware/App/Modes/ModeTreatment.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 addressed the code review comments

Dara Navaei — Thu, 07 Mar 2024 14:44:31 -0800

Dara Navaei committed 28b7042 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 addressed the code review comments

· /firmware/App/Modes/ModeTreatment.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16993 addressed the code review comments

Dara Navaei — Thu, 07 Mar 2024 14:30:38 -0800

Dara Navaei committed dce2b19 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16993 addressed the code review comments

· /firmware/App/Modes/ModeTreatment.c	(-14, +16)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 updated treatment parameters and treament code

Dara Navaei — Thu, 07 Mar 2024 14:00:44 -0800

Dara Navaei committed 2193d35 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 updated treatment parameters and treament code

· /firmware/App/Modes/ModeTreatment.c	(-16, +18)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 updated the institutional records units

Dara Navaei — Thu, 07 Mar 2024 08:29:36 -0800

Dara Navaei committed 13a6fe0 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 updated the institutional records units

· /firmware/App/Modes/ModeTreatmentParams.c

(-6, +6)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 removed the events in the treatment events list that are not mentioned in the PRS

Dara Navaei — Tue, 05 Mar 2024 15:22:45 -0800

Dara Navaei committed 580a23d on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 removed the events in the treatment events list that are not mentioned in the PRS

· /firmware/App/Controllers/Buttons.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Switches.c	(-11, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-5, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +0)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 updated the check of the heaprin stop time to account for the value of the heaprin dispense rate

Dara Navaei — Tue, 05 Mar 2024 11:25:59 -0800

Dara Navaei committed ad76efb on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 updated the check of the heaprin stop time to account for the value of the heaprin dispense rate

· /firmware/App/Modes/ModeTreatmentParams.c

(-5, +11)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 updated the code with the test results from the lab

Dara Navaei — Mon, 04 Mar 2024 16:40:58 -0800

Dara Navaei committed 0aba181 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 updated the code with the test results from the lab

· /firmware/App/Modes/ModeTreatmentParams.c

(-15, +23)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 added code to check the in treatment parameters against the institutional data

Dara Navaei — Sun, 03 Mar 2024 20:43:21 -0800

Dara Navaei committed ad4a8d9 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 added code to check the in treatment parameters against the institutional data

· /firmware/App/Modes/ModeTreatment.c	(-6, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-4, +17)	\| History	\| Source	\| Diff