Fisheye on dgfirmware/firmware/App/Controllers

dgfirmware (release/p1b/staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 31 May 2024 10:04:02 -0700

Dara Navaei committed f581314 on branch DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 18 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DENBUG-254 changed the steps that the baro temperature is calculated

Dara Navaei — Thu, 30 May 2024 14:14:38 -0700

Dara Navaei committed f111f90 on branch DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 19 more in dgfirmware

DENBUG-254 changed the steps that the baro temperature is calculated

· /firmware/App/Controllers/TemperatureSensors.c

(-4, +6)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 12 Apr 2024 16:58:32 -0700

Dara Navaei committed f986cf8 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 21 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DENBUG-232 fixed the tare code in the service mode

Dara Navaei — Fri, 12 Apr 2024 14:45:10 -0700

Dara Navaei committed 8019022 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 22 more in dgfirmware

DENBUG-232 fixed the tare code in the service mode

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DENBUG-232 added code to apply auto cal offset in the loadcells if DG is in service mode

Dara Navaei — Fri, 12 Apr 2024 13:31:27 -0700

Dara Navaei committed 2f58747 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 22 more in dgfirmware

DENBUG-232 added code to apply auto cal offset in the loadcells if DG is in service mode

· /firmware/App/Controllers/LoadCell.c

(-0, +12)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DENBUG-232 added code in the load cells driver to not apply the default tare values once the system is under calibration...

Dara Navaei — Fri, 12 Apr 2024 09:35:48 -0700

Dara Navaei committed 5d164f1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 22 more in dgfirmware

DENBUG-232 added code in the load cells driver to not apply the default tare values once the system is under calibration

· /firmware/App/Controllers/LoadCell.c

(-5, +10)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 11 Apr 2024 18:03:29 -0700

Dara Navaei committed 7d0fd5e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 22 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the load cells code to get the tare values from cal data when available

Dara Navaei — Thu, 11 Apr 2024 13:52:24 -0700

Dara Navaei committed 078bf48 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DENBUG-236 changed the load cells code to get the tare values from cal data when available

· /firmware/App/Controllers/LoadCell.c

(-19, +5)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-232 added code to get the reservoirs empty weight from the calibration records and set the reservoirs tare offset...

Dara Navaei — Thu, 11 Apr 2024 13:30:26 -0700

Dara Navaei committed c2df1e4 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DENBUG-232 added code to get the reservoirs empty weight from the calibration records and set the reservoirs tare offset to 0 upon transitioning to service mode

· /firmware/App/Controllers/LoadCell.c	(-8, +29)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-0, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16782 changed the tare to fabs

Dara Navaei — Tue, 09 Apr 2024 17:33:37 -0700

Dara Navaei committed 6be821d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DEN-16782 changed the tare to fabs

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 added code to set the concentrate pumps park status in progress to TRUE

Dara Navaei — Tue, 09 Apr 2024 16:42:21 -0700

Dara Navaei committed 80b1ef9 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DENBUG-236 added code to set the concentrate pumps park status in progress to TRUE

· /firmware/App/Controllers/ConcentratePumps.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 added code to check the progress of the concentrate pump's park

Dara Navaei — Tue, 09 Apr 2024 13:22:30 -0700

Dara Navaei committed 0dc0ea1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DENBUG-236 added code to check the progress of the concentrate pump's park

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +39)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the code set the reset park alarms to False once the pump started and not to park the concentrate pum...

Dara Navaei — Tue, 09 Apr 2024 09:07:23 -0700

Dara Navaei committed d607909 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DENBUG-236 changed the code set the reset park alarms to False once the pump started and not to park the concentrate pumps if they are already parked

· /firmware/App/Controllers/ConcentratePumps.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 removed the dead code

Dara Navaei — Fri, 05 Apr 2024 17:45:27 -0700

Dara Navaei committed 5957402 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DENBUG-236 removed the dead code

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +0)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the concentrate pumps to park in Gen Idle and also remove the concentrate pumps park alarm

Dara Navaei — Fri, 05 Apr 2024 17:27:31 -0700

Dara Navaei committed c1d5811 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DENBUG-236 changed the concentrate pumps to park in Gen Idle and also remove the concentrate pumps park alarm

· /firmware/App/Controllers/ConcentratePumps.c	(-14, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 05 Apr 2024 16:58:31 -0700

Dara Navaei committed ae9755a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/UVReactors.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-216 added code to clear the UV reactors with no flow and UV reactors health alarms when the UV reactor is off

Dara Navaei — Fri, 05 Apr 2024 15:24:06 -0700

Dara Navaei committed 158bf82 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DENBUG-216 added code to clear the UV reactors with no flow and UV reactors health alarms when the UV reactor is off

· /firmware/App/Controllers/UVReactors.c

(-1, +7)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 05 Apr 2024 10:37:53 -0700

Dara Navaei committed 69a0d10 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16782 updated the code

Dara Navaei — Thu, 04 Apr 2024 09:38:45 -0700

Dara Navaei committed 52298f9 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DEN-16782 updated the code

· /firmware/App/Controllers/LoadCell.c

(-4, +4)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16782 changed the empty reservoir weight

Dara Navaei — Mon, 01 Apr 2024 16:10:24 -0700

Dara Navaei committed c73240b on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DEN-16782 changed the empty reservoir weight

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16782 changed the code to set the tare value in the init of the load cells

Dara Navaei — Mon, 01 Apr 2024 16:07:37 -0700

Dara Navaei committed 204449b on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DEN-16782 changed the code to set the tare value in the init of the load cells

· /firmware/App/Controllers/LoadCell.c

(-5, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 19 Mar 2024 16:15:20 -0700

Dara Navaei committed d820d5e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16769 updated the VectorCAST test case for the drain pump

Dara Navaei — Mon, 18 Mar 2024 10:17:21 -0700

Dara Navaei committed 13e4021 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DEN-16769 updated the VectorCAST test case for the drain pump

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16769 changed the required minimum RPM for the drain pump direction check to 100 RPM

Dara Navaei — Mon, 18 Mar 2024 09:37:00 -0700

Dara Navaei committed 30f7327 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DEN-16769 changed the required minimum RPM for the drain pump direction check to 100 RPM

· /firmware/App/Controllers/DrainPump.c

(-1, +2)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 07 Mar 2024 10:32:48 -0800

Dara Navaei committed ac029c3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-213 added a comment

Dara Navaei — Tue, 05 Mar 2024 08:55:09 -0800

Dara Navaei committed 00c11a5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DENBUG-213 added a comment

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump...

Dara Navaei — Tue, 05 Mar 2024 08:14:46 -0800

Dara Navaei committed 7c5eba5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump driver

· /firmware/App/Controllers/ConductivitySensors.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-0, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 29 Feb 2024 15:04:39 -0800

Dara Navaei committed e3839e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16683 updated the conductivity sensor temperature compensation calibration enum names

Dara Navaei — Fri, 23 Feb 2024 17:20:19 -0800

Dara Navaei committed a27432b on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16683 updated the conductivity sensor temperature compensation calibration enum names

· /firmware/App/Controllers/ConductivitySensors.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16683 added code to get and apply the conductivity sensors' temperature compensation calibration record

Dara Navaei — Fri, 23 Feb 2024 16:57:05 -0800

Dara Navaei committed 20e605a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16683 added code to get and apply the conductivity sensors' temperature compensation calibration record

· /firmware/App/Controllers/ConductivitySensors.c

(-10, +21)

| History

| Source

| Diff