Fisheye on dgfirmware/firmware/App/Modes

dgfirmware (release/p1b/staging): DEN-16970 updated the code and VecotrCAST test cases

Dara Navaei — Thu, 12 Sep 2024 10:41:17 -0700

Dara Navaei committed b60a41d on branch master, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 17 more in dgfirmware

DEN-16970 updated the code and VecotrCAST test cases

· /firmware/App/Modes/ModeROPermeateSample.c

(-9, +5)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DEN-16970 added a check to not set any of the cleaning modes back to cancel water path if any of the cap alarms is activ...

Dara Navaei — Mon, 09 Sep 2024 13:03:04 -0700

Dara Navaei committed fafeb76 on branch master, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 17 more in dgfirmware

DEN-16970 added a check to not set any of the cleaning modes back to cancel water path if any of the cap alarms is active

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-9, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-8, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-5, +9)	\| History	\| Source	\| Diff

dgfirmware (release/p1b/staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 27 Aug 2024 16:34:46 -0700

Dara Navaei committed e6c60e0 on branch master, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 18 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (release/p1b/staging): DEN-16680 updated the VectorCAST test cases

Dara Navaei — Wed, 24 Jul 2024 08:48:54 -0700

Dara Navaei committed 5932535 on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 updated the VectorCAST test cases

· /firmware/App/Modes/ModeHeatDisinfect.c

(-15, +6)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DEN-16680 updated the start/stop heat disinfect code

Dara Navaei — Tue, 23 Jul 2024 11:17:36 -0700

Dara Navaei committed 5ecdab3 on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 updated the start/stop heat disinfect code

· /firmware/App/Modes/ModeStandby.c	(-3, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-14, +3)	\| History	\| Source	\| Diff

dgfirmware (release/p1b/staging): DEN-16680 updated the heat disinfect code

Dara Navaei — Mon, 15 Jul 2024 08:43:36 -0700

Dara Navaei committed f5d8da2 on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 updated the heat disinfect code

· /firmware/App/Modes/ModeHeatDisinfect.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DEN-16680 updated the code

Dara Navaei — Fri, 12 Jul 2024 14:03:17 -0700

Dara Navaei committed ec9448b on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 updated the code

· /firmware/App/Modes/ModeHeatDisinfect.c

(-3, +2)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DEN-16680 updated the heat disinfect mode with the latest changes on the passive active cool heat disinfect

Dara Navaei — Fri, 12 Jul 2024 13:29:42 -0700

Dara Navaei committed ab9597d on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 updated the heat disinfect mode with the latest changes on the passive active cool heat disinfect

· /firmware/App/Modes/ModeHeatDisinfect.c	(-368, +112)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (release/p1b/staging): DEN-16680 fixed a typo

Dara Navaei — Tue, 02 Jul 2024 09:12:24 -0700

Dara Navaei committed a49d0f9 on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 fixed a typo

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DEN-16680 addressed the code review comments

Dara Navaei — Tue, 02 Jul 2024 09:06:06 -0700

Dara Navaei committed 031091f on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 addressed the code review comments

· /firmware/App/Modes/ModeHeatDisinfect.c	(-13, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +0)	\| History	\| Source	\| Diff

dgfirmware (release/p1b/staging): DEN-16680 updated the code

Dara Navaei — Fri, 28 Jun 2024 10:35:10 -0700

Dara Navaei committed 7ece7d3 on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 updated the code

· /firmware/App/Modes/ModeHeatDisinfect.c

(-11, +13)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DEN-16680 added the doxygen comments for the newly developed functions

Dara Navaei — Fri, 28 Jun 2024 09:29:08 -0700

Dara Navaei committed 96d2894 on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 added the doxygen comments for the newly developed functions

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +54)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DEN-16680 added code to support the nocturnal heat disinfect

Dara Navaei — Thu, 27 Jun 2024 16:20:09 -0700

Dara Navaei committed d4e7cd1 on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 added code to support the nocturnal heat disinfect

· /firmware/App/Modes/ModeHeatDisinfect.c	(-52, +307)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +36)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (release/p1b/staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 23 Apr 2024 11:44:30 -0700

Dara Navaei committed a723642 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 21 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DENBUG-236 changed the maximum produce dialysate time in the mode fill to 45 seconds

Dara Navaei — Mon, 22 Apr 2024 15:04:40 -0700

Dara Navaei committed ef95b20 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 22 more in dgfirmware

DENBUG-236 changed the maximum produce dialysate time in the mode fill to 45 seconds

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 11 Apr 2024 18:03:29 -0700

Dara Navaei committed 7d0fd5e on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 23 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-232 added code to get the reservoirs empty weight from the calibration records and set the reservoirs tare offset...

Dara Navaei — Thu, 11 Apr 2024 13:30:26 -0700

Dara Navaei committed c2df1e4 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-232 added code to get the reservoirs empty weight from the calibration records and set the reservoirs tare offset to 0 upon transitioning to service mode

· /firmware/App/Controllers/LoadCell.c	(-8, +29)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-0, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the mode fill produce diaylsate timeouts to run the concentrate pumps at faster speed

Dara Navaei — Wed, 10 Apr 2024 14:43:08 -0700

Dara Navaei committed b2262c1 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 changed the mode fill produce diaylsate timeouts to run the concentrate pumps at faster speed

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 added a blank line

Dara Navaei — Tue, 09 Apr 2024 13:27:35 -0700

Dara Navaei committed f108744 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 added a blank line

· /firmware/App/Modes/ModeFill.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the polarity of the concentrate pumps park progress

Dara Navaei — Tue, 09 Apr 2024 13:26:53 -0700

Dara Navaei committed c6e110b on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 changed the polarity of the concentrate pumps park progress

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 added code to check the progress of the concentrate pump's park

Dara Navaei — Tue, 09 Apr 2024 13:22:30 -0700

Dara Navaei committed 0dc0ea1 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 added code to check the progress of the concentrate pump's park

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +39)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 added code to not transition from the fill modes's start state unless both concentrate pumps are parked

Dara Navaei — Tue, 09 Apr 2024 10:59:34 -0700

Dara Navaei committed dc0a9db on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 added code to not transition from the fill modes's start state unless both concentrate pumps are parked

· /firmware/App/Modes/ModeFill.c

(-31, +33)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 moved the local variables to the top in Gen Idle

Dara Navaei — Tue, 09 Apr 2024 09:14:18 -0700

Dara Navaei committed 95a629a on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 moved the local variables to the top in Gen Idle

· /firmware/App/Modes/ModeGenIdle.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the code set the reset park alarms to False once the pump started and not to park the concentrate pum...

Dara Navaei — Tue, 09 Apr 2024 09:07:23 -0700

Dara Navaei committed d607909 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 changed the code set the reset park alarms to False once the pump started and not to park the concentrate pumps if they are already parked

· /firmware/App/Controllers/ConcentratePumps.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the concentrate pumps to park in Gen Idle and also remove the concentrate pumps park alarm

Dara Navaei — Fri, 05 Apr 2024 17:27:31 -0700

Dara Navaei committed c1d5811 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 changed the concentrate pumps to park in Gen Idle and also remove the concentrate pumps park alarm

· /firmware/App/Controllers/ConcentratePumps.c	(-14, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 05 Apr 2024 10:37:53 -0700

Dara Navaei committed 69a0d10 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-218 changed the macro of alarm 274 to F32 from U32

Dara Navaei — Mon, 01 Apr 2024 15:50:15 -0700

Dara Navaei committed 72ac4f8 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-218 changed the macro of alarm 274 to F32 from U32

· /firmware/App/Modes/ModeGenIdle.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 07 Mar 2024 10:32:48 -0800

Dara Navaei committed ac029c3 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 updated the comments

Dara Navaei — Wed, 06 Mar 2024 14:47:44 -0800

Dara Navaei committed 8d0fc6d on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 25 more in dgfirmware

DEN-16682 updated the comments

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-28, +30)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 changed the fill mode to get the target conductivity values from the bicarb values of the fill conductivities ...

Dara Navaei — Wed, 06 Mar 2024 13:32:02 -0800

Dara Navaei committed 9d47686 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 25 more in dgfirmware

DEN-16682 changed the fill mode to get the target conductivity values from the bicarb values of the fill conductivities in the non-volaitle memory. Updated the VectorCAST test cases

· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +0)	\| History	\| Source	\| Diff