this CR is to old and obsolete.

RESOLVED

Hey Peter,
Thanks for the comments and all the testing .
This function doesn't mean to be used the way you tested it.
But anyway I came up with a better solution.

def partition(vString, vPart, vRightDirection=True):
    return [vString[i: i + vPart] for i in range(0, len(vString), vPart)][::-1 if vRightDirection else 1]

Actually my first thought was not correct on how this portion of the code should work.

def partition_orig(vString, vPart, vRightDirection = True):
    if vRightDirection:
        list = [vString[i - vPart : i] for i in range(len(vString), 0, -vPart)]
    else:
        list = [vString[i : i + vPart] for i in range(0, len(vString), vPart)]
    return list


def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart][::-1] for i in range(0, len(vString), vPart)]

print(partition_orig("TESTING123", 3))
print(partition_2("TESTING123", 3))

                  

Outputs:

['123', 'ING', 'EST', '']
['123', 'ING', 'EST', 'T']

whereas

def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart] for i in range(0, len(vString), vPart)]

outputs

['321', 'GNI', 'TSE', 'T']

I think you're saying you want to do the second one right? I think that would be better too!

Edit: Also I don't think you need the mString because in python immutable types (e.g. string, number, tuple) behave like call by value

I came out with the solution below :

def partition1(vString, vPart, vRightDirection=True):
mString = vString
if vRightDirection:
mString = vString[::-1]
else:
mString = vString
list = [mString[i: i + vPart] for i in range(0, len(mString), vPart)]
return list

if _name_ == "_main_":
vString = "TESTING"
vPart = 3

list = partition1(vString, vPart, True)
print(list)


list = partition1(vString, vPart, False)
print(list)

// ----- Output ----- :
['GNI', 'TSE', 'T']
['TES', 'TIN', 'G']

which is exactly what I want.
I'm gonna push changes if you agree.

Thank you so much Peter.
This is exactly the kind of code review I really like.
I looked at the code you sent and tried to test it.
At a first glance I saw a misbehavior.

your code is partition2.
list = partition2("TESTING", 2, False)
print(list)

list = partition("TESTING", 2, False)
print(list)
// —
The output is different :
['ET', 'TS', 'NI', 'G'] partition2
['TE', 'ST', 'IN', 'G'] partition

so the output is unexpected.

 partition("TESTING123", 3) 

will return

['123', 'ING', 'EST', ''] 

which is missing a character.

Also,

 partition("TESTING123", 12) 

returns

 ['23'] 

which isn't right.

How about:

def partition(vString, vPart, vRightDirection = True):
	if vRightDirection:
		vString = vString[::-1]
	return [vString[i : i + vPart][::-1] for i in range(0, len(vString), vPart)]

- Added new tst_acknow unit test.

· /build/unittest.sh

(-2, +10)

| History

| Source

| Diff

]]> Wed, 15 Jan 2020 18:42:58 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=389e71d8a8715b004a8380e598fc6786bafc303e https://devapps.diality.us/changelog/scripts?cs=389e71d8a8715b004a8380e598fc6786bafc303e Behrouz NematiPour committed 389e71d on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Merge branch 'master' into DEN-1396_LogHandler

· /build/unittest.sh

(-2, +2)

| History

| Source

| Diff

]]> Thu, 09 Jan 2020 12:13:28 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=ed4663d68cc4f70a08f24fc958b25c1c99f3a3de https://devapps.diality.us/changelog/scripts?cs=ed4663d68cc4f70a08f24fc958b25c1c99f3a3de Behrouz NematiPour committed ed4663d on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Changed the address of the shared drive to the newest address

- As part of the modification Dara had done on scripts this script was missing.

· /build/unittest.sh

(-2, +2)

| History

| Source

| Diff

]]> Wed, 08 Jan 2020 23:41:00 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=6d7e40cae3cfbade6fd9e4b2ce9af109d08e8b39 https://devapps.diality.us/changelog/scripts?cs=6d7e40cae3cfbade6fd9e4b2ce9af109d08e8b39 Behrouz NematiPour committed 6d7e40c on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added a unit test project for miscellaneous test which is not covered on feature based unit tests.

· /build/unittest.sh

(-0, +8)

| History

| Source

| Diff

]]> Wed, 08 Jan 2020 03:38:32 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=56545d8ba36e37940d189a7b3097d24e1c7bd84e https://devapps.diality.us/changelog/scripts?cs=56545d8ba36e37940d189a7b3097d24e1c7bd84e Behrouz NematiPour committed 56545d8 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added tst_logging

· /build/unittest.sh

(-5, +19)

| History

| Source

| Diff

]]> Thu, 26 Dec 2019 20:55:01 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=ac81cfae5a04bcfe5f1c5c79520d776411dd0e91 https://devapps.diality.us/changelog/scripts?cs=ac81cfae5a04bcfe5f1c5c79520d776411dd0e91 Behrouz NematiPour committed ac81cfa on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts DEN-1090 : UI Message Handler / Error Handler

- updated the unit test project name

- added a can sender which reads CAN file and send it over the CAN Bus line by line.

· /build/unittest.sh	(-1, +1)	| History	| Source	| Diff
· /setupCAN/canSend.sh	(-0, +13)	| History	| Source

]]> Mon, 25 Nov 2019 00:47:46 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=4221e195297452930cc636e283f8e74b5457e8fe https://devapps.diality.us/changelog/scripts?cs=4221e195297452930cc636e283f8e74b5457e8fe Behrouz NematiPour committed 4221e19 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Added error result for QtTest

· /build/unittest.sh

(-5, +7)

| History

| Source

| Diff

]]> Mon, 25 Nov 2019 00:09:13 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=5d2b6fbcabc3635ae0f269d4e05583991a2da614 https://devapps.diality.us/changelog/scripts?cs=5d2b6fbcabc3635ae0f269d4e05583991a2da614 Behrouz NematiPour committed 5d2b6fb on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Give Squish Coco g++ wrapper the first priority

· /build/unittest.sh

(-2, +2)

| History

| Source

| Diff

]]> Sun, 24 Nov 2019 23:19:44 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=ac7aeb4936fa216fad90627d833ee30e849cc8f7 https://devapps.diality.us/changelog/scripts?cs=ac7aeb4936fa216fad90627d833ee30e849cc8f7 Behrouz NematiPour committed ac7aeb4 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts QtTest run fix

· /build/unittest.sh

(-2, +2)

| History

| Source

| Diff

]]> Sun, 24 Nov 2019 23:08:02 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=7680db04429ee15d00801b33c7b1004ca0c9ddb8 https://devapps.diality.us/changelog/scripts?cs=7680db04429ee15d00801b33c7b1004ca0c9ddb8 Behrouz NematiPour committed 7680db0 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Fixed the QtTest UnitTest out files path

- Also added more logging

· /build/unittest.sh

(-4, +5)

| History

| Source

| Diff

]]> Sun, 24 Nov 2019 21:55:07 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=3c40c9798b5f45667bfa8115a22ae3ff584e6183 https://devapps.diality.us/changelog/scripts?cs=3c40c9798b5f45667bfa8115a22ae3ff584e6183 Behrouz NematiPour committed 3c40c97 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Updated the Unit Test Script for QtTest

- Added the QtTest builds for test

- Added merge results.

- Changed the bin files to be separated and merge-able.

· /build/unittest.sh

(-33, +57)

| History

| Source

| Diff

]]> Thu, 21 Nov 2019 01:02:06 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=5baa9c718398de12ecefa71c51ab238b8ff2676e https://devapps.diality.us/changelog/scripts?cs=5baa9c718398de12ecefa71c51ab238b8ff2676e Behrouz NematiPour committed 5baa9c7 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts unittest.sh edited online with Bitbucket

Revert back the [test]

· /build/unittest.sh

(-1, +1)

| History

| Source

| Diff

]]> Thu, 21 Nov 2019 00:55:30 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=f362c1bd7c4e9c5b1c8f4803ad4f14a688ea1a7c https://devapps.diality.us/changelog/scripts?cs=f362c1bd7c4e9c5b1c8f4803ad4f14a688ea1a7c Behrouz NematiPour committed f362c1b on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts unittest.sh edited online with Bitbucket

Build error for display [Test]

· /build/unittest.sh

(-1, +1)

| History

| Source

| Diff

]]> Wed, 20 Nov 2019 19:09:12 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=043eca0cbceefd573d8d860787fd870939c6ff2a https://devapps.diality.us/changelog/scripts?cs=043eca0cbceefd573d8d860787fd870939c6ff2a Behrouz NematiPour committed 043eca0 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts DEN-704_HomeScreen

- Updated script with the new SquishQt version (Python3) installation folder.

· /build/unittest.sh

(-1, +1)

| History

| Source

| Diff

]]> Wed, 20 Nov 2019 19:03:20 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=1f26cdb21531ae29dc5983533b6d2abf08ed62ff https://devapps.diality.us/changelog/scripts?cs=1f26cdb21531ae29dc5983533b6d2abf08ed62ff Behrouz NematiPour committed 1f26cdb on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts DEN-704_HomeScreen

- Updated the Unit Test Script to be able to easily run for local and server and more customizable.

· /build/unittest.sh

(-5, +14)

| History

| Source

| Diff

]]> Thu, 31 Oct 2019 10:01:22 -0700 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=6da217788fc7b4c08b355217f7d5d8776a376e0f https://devapps.diality.us/changelog/scripts?cs=6da217788fc7b4c08b355217f7d5d8776a376e0f Behrouz NematiPour committed 6da2177 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Adding /DEN_UI to the report folder

- It was getting really messy on the server X: drive with all projects folder mixed up

· /build/build.sh	(-1, +1)	| History	| Source	| Diff
· /build/doxygen.sh	(-1, +1)	| History	| Source	| Diff
· /build/unittest.sh	(-1, +1)	| History	| Source	| Diff

]]> Thu, 24 Oct 2019 15:19:56 -0700 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=0c9bf8600e52daed8aa0bf6985c81e217c4bf79a https://devapps.diality.us/changelog/scripts?cs=0c9bf8600e52daed8aa0bf6985c81e217c4bf79a Behrouz NematiPour committed 0c9bf86 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts DEN-625 : Automation Script and Support

- Be able to bypass Unit Test Error to not to stop build.

· /build/unittest.sh

(-3, +3)

| History

| Source

| Diff

]]>