It has been decided we are not doing it for now.
will be asked to close.

this CR is to old and obsolete.

RESOLVED

Hey Peter,
Thanks for the comments and all the testing .
This function doesn't mean to be used the way you tested it.
But anyway I came up with a better solution.

def partition(vString, vPart, vRightDirection=True):
    return [vString[i: i + vPart] for i in range(0, len(vString), vPart)][::-1 if vRightDirection else 1]

Actually my first thought was not correct on how this portion of the code should work.

def partition_orig(vString, vPart, vRightDirection = True):
    if vRightDirection:
        list = [vString[i - vPart : i] for i in range(len(vString), 0, -vPart)]
    else:
        list = [vString[i : i + vPart] for i in range(0, len(vString), vPart)]
    return list


def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart][::-1] for i in range(0, len(vString), vPart)]

print(partition_orig("TESTING123", 3))
print(partition_2("TESTING123", 3))

                  

Outputs:

['123', 'ING', 'EST', '']
['123', 'ING', 'EST', 'T']

whereas

def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart] for i in range(0, len(vString), vPart)]

outputs

['321', 'GNI', 'TSE', 'T']

I think you're saying you want to do the second one right? I think that would be better too!

Edit: Also I don't think you need the mString because in python immutable types (e.g. string, number, tuple) behave like call by value

I came out with the solution below :

def partition1(vString, vPart, vRightDirection=True):
mString = vString
if vRightDirection:
mString = vString[::-1]
else:
mString = vString
list = [mString[i: i + vPart] for i in range(0, len(mString), vPart)]
return list

if _name_ == "_main_":
vString = "TESTING"
vPart = 3

list = partition1(vString, vPart, True)
print(list)


list = partition1(vString, vPart, False)
print(list)

// ----- Output ----- :
['GNI', 'TSE', 'T']
['TES', 'TIN', 'G']

which is exactly what I want.
I'm gonna push changes if you agree.

Thank you so much Peter.
This is exactly the kind of code review I really like.
I looked at the code you sent and tried to test it.
At a first glance I saw a misbehavior.

your code is partition2.
list = partition2("TESTING", 2, False)
print(list)

list = partition("TESTING", 2, False)
print(list)
// —
The output is different :
['ET', 'TS', 'NI', 'G'] partition2
['TE', 'ST', 'IN', 'G'] partition

so the output is unexpected.

 partition("TESTING123", 3) 

will return

['123', 'ING', 'EST', ''] 

which is missing a character.

Also,

 partition("TESTING123", 12) 

returns

 ['23'] 

which isn't right.

How about:

def partition(vString, vPart, vRightDirection = True):
	if vRightDirection:
		vString = vString[::-1]
	return [vString[i : i + vPart][::-1] for i in range(0, len(vString), vPart)]

- Added new tst_acknow unit test.

· /build/unittest.sh

(-2, +10)

| History

| Source

| Diff

]]> Wed, 15 Jan 2020 18:42:58 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=389e71d8a8715b004a8380e598fc6786bafc303e https://devapps.diality.us/changelog/scripts?cs=389e71d8a8715b004a8380e598fc6786bafc303e Behrouz NematiPour committed 389e71d on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Merge branch 'master' into DEN-1396_LogHandler

· /build/unittest.sh

(-2, +2)

| History

| Source

| Diff

]]> Thu, 09 Jan 2020 12:13:28 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=ed4663d68cc4f70a08f24fc958b25c1c99f3a3de https://devapps.diality.us/changelog/scripts?cs=ed4663d68cc4f70a08f24fc958b25c1c99f3a3de Behrouz NematiPour committed ed4663d on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Changed the address of the shared drive to the newest address

- As part of the modification Dara had done on scripts this script was missing.

· /build/unittest.sh

(-2, +2)

| History

| Source

| Diff

]]> Wed, 08 Jan 2020 23:41:00 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=6d7e40cae3cfbade6fd9e4b2ce9af109d08e8b39 https://devapps.diality.us/changelog/scripts?cs=6d7e40cae3cfbade6fd9e4b2ce9af109d08e8b39 Behrouz NematiPour committed 6d7e40c on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added a unit test project for miscellaneous test which is not covered on feature based unit tests.

· /build/unittest.sh

(-0, +8)

| History

| Source

| Diff

]]> Wed, 08 Jan 2020 03:38:32 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=56545d8ba36e37940d189a7b3097d24e1c7bd84e https://devapps.diality.us/changelog/scripts?cs=56545d8ba36e37940d189a7b3097d24e1c7bd84e Behrouz NematiPour committed 56545d8 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added tst_logging

· /build/unittest.sh

(-5, +19)

| History

| Source

| Diff

]]> Thu, 26 Dec 2019 20:55:01 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/scripts?cs=ac81cfae5a04bcfe5f1c5c79520d776411dd0e91 https://devapps.diality.us/changelog/scripts?cs=ac81cfae5a04bcfe5f1c5c79520d776411dd0e91 Behrouz NematiPour committed ac81cfa on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts DEN-1090 : UI Message Handler / Error Handler

- updated the unit test project name

- added a can sender which reads CAN file and send it over the CAN Bus line by line.

· /build/unittest.sh	(-1, +1)	| History	| Source	| Diff
· /setupCAN/canSend.sh	(-0, +13)	| History	| Source

]]> Sat, 07 Dec 2019 10:52:24 -0800 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=2f0b669c213324d09821c855ada58a3b6e722f37 https://devapps.diality.us/changelog/scripts?cs=2f0b669c213324d09821c855ada58a3b6e722f37 Dara Navaei committed 2f0b669 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Updated the copy address to the shared drive in the script

· /build/doxygen.sh

(-2, +2)

| History

| Source

| Diff

]]> Sat, 07 Dec 2019 09:46:50 -0800 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=ab1ddbd93d8c59249761c86c46f5294c90993496 https://devapps.diality.us/changelog/scripts?cs=ab1ddbd93d8c59249761c86c46f5294c90993496 Dara Navaei committed ab1ddbd on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Updated the shared drvie address in another part of the script

· /build/build.sh

(-1, +1)

| History

| Source

| Diff

]]> Sat, 07 Dec 2019 09:38:41 -0800 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=b5e9c8595e947375d975ed8269f23e757263f032 https://devapps.diality.us/changelog/scripts?cs=b5e9c8595e947375d975ed8269f23e757263f032 Dara Navaei committed b5e9c85 on branch DEN-1396_LogHandler, DEN-14294-UI-BN-S84 and 18 more in scripts Changed the address of the shared drive to the newest address

· /build/build.sh

(-1, +1)

| History

| Source

| Diff

]]>