Fisheye on dgfirmware/

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-17234 addressed the code review comments

Dara Navaei — Thu, 27 Feb 2025 13:19:07 -0800

Dara Navaei committed 77cf960 on branch DEN-17234-alarm_68_fix_in_expedite_pretreatment, DEN-17298-release_22_vc-staging and 6 more in dgfirmware

DEN-17234 addressed the code review comments

· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-6, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-17234 added pretreatment expedite test configuration to DG and implemented in DG fill

Dara Navaei — Wed, 26 Feb 2025 13:29:37 -0800

Dara Navaei committed 4ca9ae0 on branch DEN-17234-alarm_68_fix_in_expedite_pretreatment, DEN-17298-release_22_vc-staging and 6 more in dgfirmware

DEN-17234 added pretreatment expedite test configuration to DG and implemented in DG fill

· /firmware/App/Modes/ModeFill.c	(-0, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-6, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 03 Feb 2025 13:31:04 -0800

Dara Navaei committed 8cdc393 on branch DEN-17234-alarm_68_fix_in_expedite_pretreatment, DEN-17298-release_22_vc-staging and 6 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Merged DEN-17213

Dara Navaei — Mon, 03 Feb 2025 13:28:25 -0800

Dara Navaei committed 921e462 on branch DEN-17234-alarm_68_fix_in_expedite_pretreatment, DEN-17298-release_22_vc-staging and 6 more in dgfirmware

Merged DEN-17213

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-17213 updated the vectorCAST test cases

Dara Navaei — Mon, 03 Feb 2025 10:33:43 -0800

Dara Navaei committed a83258e on branch DEN-17213-release_20_vectorcast-staging, DEN-17234-alarm_68_fix_in_expedite_pretreatment and 7 more in dgfirmware

DEN-17213 updated the vectorCAST test cases

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 30 Jan 2025 17:51:00 -0800

Dara Navaei committed 4414b5b on branch DEN-17213-release_20_vectorcast-staging, DEN-17234-alarm_68_fix_in_expedite_pretreatment and 7 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 29 Jan 2025 18:47:17 -0800

Dara Navaei committed b88f6b6 on branch DEN-17213-release_20_vectorcast-staging, DEN-17234-alarm_68_fix_in_expedite_pretreatment and 7 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 29 Jan 2025 18:46:47 -0800

Dara Navaei committed 721bd71 on branch DEN-17213-release_20_vectorcast-staging, DEN-17234-alarm_68_fix_in_expedite_pretreatment and 7 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Merged DEN-17135

Dara Navaei — Wed, 29 Jan 2025 18:27:03 -0800

Dara Navaei committed 5e82c36 on branch DEN-17213-release_20_vectorcast-staging, DEN-17234-alarm_68_fix_in_expedite_pretreatment and 7 more in dgfirmware

Merged DEN-17135

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-289 added more comments

Dara Navaei — Fri, 17 Jan 2025 10:48:31 -0800

Dara Navaei committed e22fcc0 on branch DEN-17135-concentrate-pump-calibration-staging, DEN-17213-release_20_vectorcast-staging and 8 more in dgfirmware

DENBUG-289 added more comments

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-284 updated the code

Dara Navaei — Thu, 16 Jan 2025 13:35:32 -0800

Dara Navaei committed 73c2464 on branch DEN-17135-concentrate-pump-calibration-staging, DEN-17213-release_20_vectorcast-staging and 8 more in dgfirmware

DENBUG-284 updated the code

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-17135: added code to check the concentrate pumps calibration reocrd live. DEN-17146: fixed the active cool mode

Dara Navaei — Thu, 16 Jan 2025 10:13:57 -0800

Dara Navaei committed 8ae4fbc on branch DEN-17135-concentrate-pump-calibration-staging, DEN-17213-release_20_vectorcast-staging and 8 more in dgfirmware

DEN-17135: added code to check the concentrate pumps calibration reocrd live. DEN-17146: fixed the active cool mode

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-6, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-17135 updated the concentrate pumps calibration

Dara Navaei — Wed, 04 Dec 2024 15:13:12 -0800

Dara Navaei committed 6743b1b on branch DEN-17135-concentrate-pump-calibration-staging, DEN-17213-release_20_vectorcast-staging and 8 more in dgfirmware

DEN-17135 updated the concentrate pumps calibration

· /firmware/App/Controllers/ConcentratePumps.c	(-9, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-0, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-17135 added the calibration record to the acid and bicarb concentrate pumps

Dara Navaei — Wed, 20 Nov 2024 10:50:35 -0800

Dara Navaei committed 336c209 on branch DEN-17135-concentrate-pump-calibration-staging, DEN-17213-release_20_vectorcast-staging and 8 more in dgfirmware

DEN-17135 added the calibration record to the acid and bicarb concentrate pumps

· /firmware/App/Controllers/ConcentratePumps.c

(-4, +11)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 08 Nov 2024 10:05:42 -0800

Dara Navaei committed 4751c94 on branch master, DEN-17135-concentrate-pump-calibration-staging and 9 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 08 Nov 2024 10:05:12 -0800

Dara Navaei committed e0f0e56 on branch master, DEN-17135-concentrate-pump-calibration-staging and 9 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Merged DENBUG-276

Dara Navaei — Fri, 08 Nov 2024 09:49:50 -0800

Dara Navaei committed 8a50ce9 on branch master, DEN-17135-concentrate-pump-calibration-staging and 9 more in dgfirmware

Merged DENBUG-276

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-276, DENBUG-277 changed the location of the command the resets the chemicals used volume form mode fill to standb...

Dara Navaei — Mon, 28 Oct 2024 15:49:18 -0700

Dara Navaei committed 05c60dd on branch master, DEN-17135-concentrate-pump-calibration-staging and 9 more in dgfirmware

DENBUG-276, DENBUG-277 changed the location of the command the resets the chemicals used volume form mode fill to standby to reset the bottles upon transitioning to mode gen idle

· /firmware/App/Modes/ModeFill.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-276 changed the acid and bicarb low volume checks to 500mL

Dara Navaei — Wed, 23 Oct 2024 09:59:57 -0700

Dara Navaei committed a7bc7d6 on branch master, DEN-17135-concentrate-pump-calibration-staging and 9 more in dgfirmware

DENBUG-276 changed the acid and bicarb low volume checks to 500mL

· /firmware/App/Modes/ModeDrain.c

(-10, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-276, DENBUG-277 changed the code in the mode fill to account for the acid and bicarb volume usage

Dara Navaei — Sun, 20 Oct 2024 19:56:59 -0700

Dara Navaei committed 741de51 on branch master, DEN-17135-concentrate-pump-calibration-staging and 9 more in dgfirmware

DENBUG-276, DENBUG-277 changed the code in the mode fill to account for the acid and bicarb volume usage

· /firmware/App/Modes/ModeFill.c

(-2, +15)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 10 Oct 2024 14:02:10 -0700

Dara Navaei committed 972e683 on branch master, DEN-17135-concentrate-pump-calibration-staging and 9 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 12 Sep 2024 13:43:02 -0700

Dara Navaei committed d90cd8c on branch master, DEN-17093-blood-leak-zeroing-in-treatment-p1b-staging and 16 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 12 Sep 2024 13:42:32 -0700

Dara Navaei committed 54abf84 on branch master, DEN-17093-blood-leak-zeroing-in-treatment-p1b-staging and 16 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (release/p1b/staging): Merged DEN-16970

Dara Navaei — Thu, 12 Sep 2024 13:40:07 -0700

Dara Navaei committed d43d5b6 on branch master, DEN-17093-blood-leak-zeroing-in-treatment-p1b-staging and 16 more in dgfirmware

Merged DEN-16970

dgfirmware (release/p1b/staging): DEN-16970 updated the code and VecotrCAST test cases

Dara Navaei — Thu, 12 Sep 2024 10:41:17 -0700

Dara Navaei committed b60a41d on branch master, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 17 more in dgfirmware

DEN-16970 updated the code and VecotrCAST test cases

· /firmware/App/Modes/ModeROPermeateSample.c

(-9, +5)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): DEN-16970 added a check to not set any of the cleaning modes back to cancel water path if any of the cap alarms is activ...

Dara Navaei — Mon, 09 Sep 2024 13:03:04 -0700

Dara Navaei committed fafeb76 on branch master, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 17 more in dgfirmware

DEN-16970 added a check to not set any of the cleaning modes back to cancel water path if any of the cap alarms is active

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-9, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-8, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-5, +9)	\| History	\| Source	\| Diff

dgfirmware (release/p1b/staging): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 27 Aug 2024 16:35:18 -0700

Dara Navaei committed d8e392d on branch master, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 18 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (release/p1b/staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 27 Aug 2024 16:34:46 -0700

Dara Navaei committed e6c60e0 on branch master, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 18 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (release/p1b/staging): Merged DEN-16680

Dara Navaei — Tue, 27 Aug 2024 16:08:37 -0700

Dara Navaei committed 8650e73 on branch master, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 18 more in dgfirmware

Merged DEN-16680

dgfirmware (release/p1b/staging): DEN-16680 updated the VectorCAST test cases

Dara Navaei — Wed, 24 Jul 2024 08:48:54 -0700

Dara Navaei committed 5932535 on branch master, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 19 more in dgfirmware

DEN-16680 updated the VectorCAST test cases

· /firmware/App/Modes/ModeHeatDisinfect.c

(-15, +6)

| History

| Source

| Diff