Fisheye on application/.run.sh.swp https://devapps.diality.us/changelog/~br%3DDEN-2554_CodeStructureReview/application/.run.sh.swp Recent activity in "application" under directory /.run.sh.swp UI-DEN-608-1: closed by Dara Navaei Sat, 07 Dec 2019 11:45:11 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-608-1 https://devapps.diality.us/cru/UI-DEN-608-1 Dara Navaei Closed UI-DEN-608-1 ]]> UI-DEN-608-1: reviewers finished Sat, 07 Dec 2019 11:45:04 -0800 https://devapps.diality.us/cru/UI-DEN-608-1 https://devapps.diality.us/cru/UI-DEN-608-1 Dara Navaei finished reviewing UI-DEN-608-1 DEN-UI-608_CAN Integration on UI ]]> UI-DEN-608-1: reviewers finished Wed, 04 Dec 2019 08:53:25 -0800 https://devapps.diality.us/cru/UI-DEN-608-1 https://devapps.diality.us/cru/UI-DEN-608-1 lbaloa  (deleted user) finished reviewing UI-DEN-608-1 DEN-UI-608_CAN Integration on UI ]]> UI-DEN-608-1: reviewers finished Tue, 03 Dec 2019 15:55:07 -0800 https://devapps.diality.us/cru/UI-DEN-608-1 https://devapps.diality.us/cru/UI-DEN-608-1 pmontazemi  (deleted user) finished reviewing UI-DEN-608-1 DEN-UI-608_CAN Integration on UI ]]> UI-DEN-608-1: comment by pmontazemi "RESOLVED." Tue, 03 Dec 2019 15:55:04 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-608-1/#c431 https://devapps.diality.us/cru/UI-DEN-608-1/#c431 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-608-1

RESOLVED.

]]> UI-DEN-608-1: comment by pmontazemi "RESOLVED." Mon, 28 Oct 2019 16:23:14 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-608-1/#c168 https://devapps.diality.us/cru/UI-DEN-608-1/#c168 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-608-1

RESOLVED.

]]> UI-DEN-608-1: comment by pmontazemi "RESOLVED." Mon, 28 Oct 2019 16:22:53 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-608-1/#c167 https://devapps.diality.us/cru/UI-DEN-608-1/#c167 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-608-1

RESOLVED.

]]> UI-DEN-608-1: comment by Behrouz NematiPour "Regarding to improve it and make it more genera..." Mon, 28 Oct 2019 15:51:24 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-608-1/#c166 https://devapps.diality.us/cru/UI-DEN-608-1/#c166 Behrouz NematiPour commented on UI-DEN-608-1

Regarding to improve it and make it more general added a repeater so we can have from 1 to n (depending on the text size of menu items.)

]]> UI-DEN-608-1: comment by Behrouz NematiPour "It has been updated in the other code review he..." Mon, 28 Oct 2019 15:50:14 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-608-1/#c165 https://devapps.diality.us/cru/UI-DEN-608-1/#c165 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-608-1

It has been updated in the other code review here I just removed the residue.

]]> UI-DEN-608-1: comment by Behrouz NematiPour "For now it's 250000 and coordinated with FW. W..." Mon, 28 Oct 2019 15:48:54 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-608-1/#c164 https://devapps.diality.us/cru/UI-DEN-608-1/#c164 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-608-1

For now it's 250000 and coordinated with FW.
When settings and configuration module implemented this will be set able.

]]> UI-DEN-608-1: comment by pmontazemi "How was this made a more general component with..." Mon, 28 Oct 2019 15:45:00 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-608-1/#c163 https://devapps.diality.us/cru/UI-DEN-608-1/#c163 pmontazemi  (deleted user) commented on UI-DEN-608-1

How was this made a more general component without any code being added?

]]> UI-DEN-608-1: comment by pmontazemi "Have we coordinated with FW Team to make sure t..." Mon, 28 Oct 2019 15:44:06 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-608-1/#c162 https://devapps.diality.us/cru/UI-DEN-608-1/#c162 pmontazemi  (deleted user) commented on UI-DEN-608-1

Have we coordinated with FW Team to make sure this is the fixed CAN Bus bit rate that is planned to be used?

]]> UI-DEN-608-1: reviewers joined DEN-UI-608_CAN Integration on UI Mon, 28 Oct 2019 13:18:59 -0700 https://devapps.diality.us/cru/UI-DEN-608-1 https://devapps.diality.us/cru/UI-DEN-608-1 Dara Navaei joined UI-DEN-608-1 DEN-UI-608_CAN Integration on UI ]]> UI-DEN-608-1: started by Dara Navaei Mon, 28 Oct 2019 13:18:22 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-608-1 https://devapps.diality.us/cru/UI-DEN-608-1 Dara Navaei started review UI-DEN-608-1 ]]>