Fisheye on application/resources/settings/instructions https://devapps.diality.us/changelog/~br%3DDEN-2554_CodeStructureReview/application/resources/settings/instructions Recent activity in "application" under directory /resources/settings/instructions UI-DEN-8308-1: closed by Behrouz NematiPour Fri, 28 May 2021 17:42:15 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1 https://devapps.diality.us/cru/UI-DEN-8308-1 Behrouz NematiPour Closed UI-DEN-8308-1 ]]> UI-DEN-8308-1: reviewers finished Fri, 28 May 2021 17:12:37 -0700 https://devapps.diality.us/cru/UI-DEN-8308-1 https://devapps.diality.us/cru/UI-DEN-8308-1 plucia  (deleted user) finished reviewing UI-DEN-8308-1 UI-DEN-8308_UI DEV Treatment Log ]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Fri, 28 May 2021 17:12:02 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10143 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10143 plucia  (deleted user) replied to plucia  (deleted user) in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "From what I can tell the dg command is separate..." Tue, 25 May 2021 12:27:20 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10115 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10115 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

From what I can tell the dg command is separated from the hd command which is good.
Please let me know when your code is ready to be merged to staging and I will handle it.
Also for the next feature you're working on please branch off of the latest staging.

]]> UI-DEN-8308-1: comment by Behrouz NematiPour "I don't have dg_simulator. It would be a merge..." Tue, 25 May 2021 12:04:35 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10114 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10114 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

I don't have dg_simulator.
It would be a merge task later to merge this code into the staging, I think it's out of the code review scope.

]]> UI-DEN-8308-1: comment by plucia "The dg simulator needs to be used for dg respon..." Tue, 25 May 2021 10:40:27 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10093 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10093 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

The dg simulator needs to be used for dg responses here still

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:45:34 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10107 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10107 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:45:18 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10106 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10106 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:45:07 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10105 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10105 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:44:51 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10104 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10104 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:44:42 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10103 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10103 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:44:34 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10102 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10102 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:44:19 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10101 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10101 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:44:06 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10100 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10100 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:43:56 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10099 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10099 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:43:45 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10098 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10098 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:42:32 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10097 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10097 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:42:11 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10096 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10096 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:41:44 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10095 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10095 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: comment by plucia "RESOLVED" Tue, 25 May 2021 10:41:04 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8308-1/#c10094 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10094 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED

]]> UI-DEN-8308-1: reviewers finished Tue, 25 May 2021 09:26:25 -0700 https://devapps.diality.us/cru/UI-DEN-8308-1 https://devapps.diality.us/cru/UI-DEN-8308-1 pmontazemi  (deleted user) finished reviewing UI-DEN-8308-1 UI-DEN-8308_UI DEV Treatment Log ]]> UI-DEN-8308-1: comment by Behrouz NematiPour "Updated" Mon, 24 May 2021 23:44:55 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10087 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10087 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

Updated

]]> UI-DEN-8308-1: comment by Behrouz NematiPour "Updated" Mon, 24 May 2021 23:44:42 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10086 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10086 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

Updated

]]> UI-DEN-8308-1: comment by Behrouz NematiPour "The original file didn't have the copyright so ..." Mon, 24 May 2021 23:44:29 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10085 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10085 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

The original file didn't have the copyright so couldn't find easily what was the actual dates, just put some dates. Bamboo will later update the copyright with correct information.

]]> UI-DEN-8308-1: comment by Behrouz NematiPour "added" Mon, 24 May 2021 23:43:56 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10084 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10084 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

added

]]> UI-DEN-8308-1: comment by Behrouz NematiPour "The original file didn't have the copyright so ..." Mon, 24 May 2021 23:38:49 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10081 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10081 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

The original file didn't have the copyright so couldn't find easily what was the actual dates, just put some dates. Bamboo will later update the copyright with correct information.

]]> UI-DEN-8308-1: comment by Behrouz NematiPour "The original file didn't have the copyright so ..." Mon, 24 May 2021 23:37:49 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10080 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10080 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

The original file didn't have the copyright so couldn't find easily what was the actual dates, just put some dates. Bamboo will later update the copyright with correct information.

]]> UI-DEN-8308-1: comment by Behrouz NematiPour "The original file didn't have the copyright. la..." Mon, 24 May 2021 23:40:59 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10083 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10083 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

The original file didn't have the copyright. later Bamboo will update with the correct information on top.
I updated the other two comments.

]]> UI-DEN-8308-1: comment by Behrouz NematiPour "The original file didn't have the copyright. la..." Mon, 24 May 2021 23:40:09 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10082 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10082 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

The original file didn't have the copyright. later Bamboo will update with the correct information on top.
I updated the other two comments.

]]> UI-DEN-8308-1: comment by Behrouz NematiPour "It has been updated regarding our conversation." Mon, 24 May 2021 23:36:53 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8308-1/#c10079 https://devapps.diality.us/cru/UI-DEN-8308-1/#c10079 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-8308-1

It has been updated regarding our conversation.

]]>