Fisheye on application/sources/canbus/frameinterface.h

application (bugfix/DEN-16597-UI-BN-S114): DEN-3164 : Code Review 0...

Behrouz NematiPour — Thu, 07 May 2020 03:54:43 -0700

Behrouz NematiPour committed b798668 on branch master, 2020_EOY_DEMO and 262 more in application

DEN-3164 : Code Review 0

- Corrected the copyright comment Doxygen tags.

- Corrected the copyright template Doxygen tags.

- Added check for fall through in switch statements to project.

- Added method comments in tst_messaging, unit test class.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /copyright

(-4, +4)

| History

| Source

| Diff

· /denali.pro

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-3, +3)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageacknowmodel.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageacknowmodel.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-4, +4)

| History

| Source

| Diff

· /sources/gui/guiglobals.cpp

(-4, +4)

| History

| Source

| Diff

… 69 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-2236_UI100%CoverageoftheApplicationSoftware...

Behrouz NematiPour — Tue, 21 Apr 2020 05:14:04 -0700

Behrouz NematiPour committed d3f9160 on branch master, 2020_EOY_DEMO and 266 more in application

DEN-2236_UI100%CoverageoftheApplicationSoftware

level 1

Coverage : 99.594% (1473/1479)

Manual : 15.416% (228/1479)

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /denali.pro

(-4, +60)

| History

| Source

| Diff

· /denali.pro.user

(-375, +694)

| History

| Source

| Diff

· /main.cpp

(-17, +15)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-0, +6)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-6, +26)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-3, +11)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-0, +2)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-0, +2)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-0, +5)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-0, +4)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-0, +3)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-1, +2)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-0, +8)

| History

| Source

| Diff

· /sources/gui/guiglobals.cpp

(-2, +7)

| History

| Source

| Diff

· /sources/gui/guiglobals.h

(-1, +1)

| History

| Source

| Diff

… 24 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-2091 : CAN / Denali Communication Protocol [Modify Design]...

Behrouz NematiPour — Mon, 02 Mar 2020 13:06:37 -0800

Behrouz NematiPour committed bb8f39a on branch master, 2020_EOY_DEMO and 271 more in application

DEN-2091 : CAN / Denali Communication Protocol [Modify Design]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /main.cpp

(-13, +83)

| History

| Source

| Diff

· /scripts/autostart

(-1, +3)

| History

| Source

| Diff

· /scripts/run.sh

(-4, +9)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-1, +52)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-0, +2)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-17, +23)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-1, +13)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-14, +98)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-1, +26)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-2, +10)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-2, +5)

| History

| Source

| Diff

· /sources/gui/guiview.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/guiview.h

(-2, +2)

| History

| Source

| Diff

· /sources/gui/qml/components/ModalDialog.qml

(-1, +0)

| History

| Source

| Diff

· /sources/main.h

(-0, +5)

| History

| Source

| Diff

… 3 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-1714 : Implementation...

Behrouz NematiPour — Tue, 21 Jan 2020 19:03:16 -0800

Behrouz NematiPour committed 805119c on branch master, 2020_EOY_DEMO and 274 more in application

DEN-1714 : Implementation

- Added cppcheck output.

- Added Linux signal handler to quit the application gracefully.

- Added manual coco validation. // coco begin validated:

· /cppcheck.err

(-3, +3)

| History

| Source

| Diff

· /cppcheck.log

(-23, +30)

| History

| Source

| Diff

· /denali.pro

(-0, +13)

| History

| Source

| Diff

· /denali.pro.user

(-274, +368)

| History

| Source

| Diff

· /main.cpp

(-1, +27)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-0, +7)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-0, +7)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-0, +2)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-0, +7)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-0, +2)

| History

| Source

| Diff

· /sources/canbus/messageacknowmodel.cpp

(-0, +8)

| History

| Source

| Diff

· /sources/canbus/messageacknowmodel.h

(-0, +5)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-16, +14)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.h

(-6, +10)

| History

| Source

| Diff

· /sources/gui/guicontroller.cpp

(-1, +26)

| History

| Source

| Diff

… 11 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-1714 : Implementation

Behrouz NematiPour — Thu, 16 Jan 2020 18:31:14 -0800

Behrouz NematiPour committed 8c69137 on branch master, 2020_EOY_DEMO and 274 more in application

DEN-1714 : Implementation

· /denali.pro

(-6, +0)

| History

| Source

| Diff

· /denali.pro.user

(-1, +1)

| History

| Source

| Diff

· /denali.qrc

(-0, +1)

| History

| Source

| Diff

· /main.cpp

(-2, +0)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-2, +5)

| History

| Source

| Diff

· /sources/applicationpost.cpp

(-0, +6)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-14, +17)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-8, +5)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-10, +12)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-2, +2)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-18, +32)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-2, +3)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-16, +19)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.h

(-6, +6)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-7, +12)

| History

| Source

| Diff

… 16 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Merge branch 'master' into DEN-1396_LogHandler

Behrouz NematiPour — Wed, 15 Jan 2020 18:30:58 -0800

Behrouz NematiPour committed c6a0989 on branch master, 2020_EOY_DEMO and 275 more in application

Merge branch 'master' into DEN-1396_LogHandler

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-1, +1)

| History

| Source

| Diff

· /sources/gui/guicontroller.cpp

(-1, +1)

| History

| Source

| Diff

… 22 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-1437 : Implementation...

Behrouz NematiPour — Sat, 11 Jan 2020 19:05:33 -0800

Behrouz NematiPour committed 227f28b on branch master, 2020_EOY_DEMO and 274 more in application

DEN-1437 : Implementation

- Changed 2019-2019 in copyright to 2019-2020.

· /denali.pro.user

(-317, +317)

| History

| Source

| Diff

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-1, +1)

| History

| Source

| Diff

· /sources/applicationpost.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/applicationpost.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-1, +1)

| History

| Source

| Diff

… 45 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Thu, 09 Jan 2020 11:17:31 -0800

Dara Navaei committed 7cb4ad8 on branch master, 2020_EOY_DEMO and 275 more in application

Updated the Copyright with the current year and replaced tabs with 4 spaces

· /sources/canbus/frameinterface.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/frameinterface.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/messagebuilder.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/messagebuilder.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/messagedispatcher.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/messagedispatcher.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/messageglobals.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/messageinterpreter.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/messageinterpreter.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/utility/crc.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/utility/format.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/utility/format.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/utility/types.h	(-1, +1)	\| History	\| Source	\| Diff
· /unittests/tst_canbus.cpp	(-1, +1)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): DEN-1617 : Implementation - Alarm Logging and Acknowledgment...

Behrouz NematiPour — Tue, 07 Jan 2020 13:31:16 -0800

Behrouz NematiPour committed 56d00a8 on branch master, 2020_EOY_DEMO and 275 more in application

DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added threading to other classes (Application / Gui controller, ...) and restructured the threading to meed the Qt limitation.

- Documented the code

- Ran cppCheck again

- Cleaned the includes and using namespace (They have left after so many changes and some were useless.)

- Added _init flag for init methods so not to be able to call them twice.

- Added another init method with the thread parameter to be able to pass the thread of the class and also be able to use the class without any thread for unit tests.

- Created a Threads namespace to gather all the threads in one place.

- Update the unit tests as well. [to make it work with the new structure/threading.]

· /cppcheck.err

(-6, +4)

| History

| Source

| Diff

· /cppcheck.log

(-18, +18)

| History

| Source

| Diff

· /denali.pro

(-3, +2)

| History

| Source

| Diff

· /main.cpp

(-15, +19)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-3, +88)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-8, +12)

| History

| Source

| Diff

· /sources/canbus/alarminterpreter.cpp

(-19, +0)

| History

| Source

| Diff

· /sources/canbus/alarminterpreter.h

(-41, +0)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-29, +60)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-7, +18)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-21, +56)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-9, +16)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-7, +6)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-18, +17)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-17, +56)

| History

| Source

| Diff

… 21 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-1617 : Implementation - Alarm Logging and Acknowledgment...

Behrouz NematiPour — Sun, 05 Jan 2020 22:17:50 -0800

Behrouz NematiPour committed e160521 on branch master, 2020_EOY_DEMO and 275 more in application

DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added Threading for :

. Can Frame

. Can Message

. USB Watcher

- Changed the File Handler implementation

- Changed the Singleton from pointer to static reference

// TODO :

- We still need to work on threading on other classes

- We need to have a singleton parent class

- Some code has been added to debug can interface (We still have swap frames)

- Thread Objects need to be gathered all together in one place to be handled easily.

· /denali.pro

(-0, +1)

| History

| Source

| Diff

· /main.cpp

(-13, +13)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-17, +12)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-38, +84)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-1, +6)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-8, +30)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-2, +3)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-10, +38)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.h

(-2, +3)

| History

| Source

| Diff

· /sources/canbus/messageglobals.cpp

(-0, +20)

| History

| Source

· /sources/canbus/messageglobals.h

(-0, +5)

| History

| Source

| Diff

· /sources/gui/guicontroller.cpp

(-10, +6)

| History

| Source

| Diff

· /sources/gui/guicontroller.h

(-1, +1)

| History

| Source

| Diff

· /sources/gui/guiview.cpp

(-12, +12)

| History

| Source

| Diff

… 7 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-1090 : UI Message Handler / Error Handler...

Behrouz NematiPour — Thu, 19 Dec 2019 03:37:24 -0800

Behrouz NematiPour committed 5610552 on branch master, 2020_EOY_DEMO and 276 more in application

DEN-1090 : UI Message Handler / Error Handler

- Trying a solution to have separate unit tests for each feature.

- Changed the unittests class to tst_canbus since this is the unit test for implemented canbus messages and interaction.

- removed .pro.user from gitignore since denali.pro.user contains configurations for local unit tests setup and need to be cloned for the new ones.

- Fixed issues which has been found during the unit tests.

· /.gitignore	(-1, +0)	\| History	\| Source	\| Diff
· /denali.pro	(-7, +9)	\| History	\| Source	\| Diff
· /denali.pro.user	(-0, +737)	\| History	\| Source
· /main.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/canbus/caninterface.cpp	(-0, +1)	\| History	\| Source	\| Diff
· /sources/canbus/caninterface.h	(-2, +2)	\| History	\| Source	\| Diff
· /sources/canbus/frameinterface.h	(-2, +2)	\| History	\| Source	\| Diff
· /sources/canbus/messagebuilder.cpp	(-7, +7)	\| History	\| Source	\| Diff
· /sources/canbus/messagedispatcher.h	(-0, +6)	\| History	\| Source	\| Diff
· /sources/canbus/messageinterpreter.cpp	(-0, +1)	\| History	\| Source	\| Diff
· /sources/utility/format.cpp	(-0, +7)	\| History	\| Source	\| Diff
· /sources/utility/format.h	(-3, +3)	\| History	\| Source	\| Diff
· /unittests/tst_canbus.cpp	(-0, +277)	\| History	\| Source
· /unittests/tst_canbus.h	(-0, +62)	\| History	\| Source
· /unittests/unittests.cpp	(-136, +0)	\| History	\| Source	\| Diff
· /unittests/unittests.h	(-51, +0)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): DEN-1090 : UI Message Handler / Error Handler...

Behrouz NematiPour — Wed, 18 Dec 2019 21:24:31 -0800

Behrouz NematiPour committed d3f9838 on branch master, 2020_EOY_DEMO and 276 more in application

DEN-1090 : UI Message Handler / Error Handler

- renamed MessageHandler to FrameInterface to understand easier in SDD.

· /denali.pro	(-2, +2)	\| History	\| Source	\| Diff
· /main.cpp	(-5, +5)	\| History	\| Source	\| Diff
· /sources/canbus/caninterface.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/canbus/frameinterface.cpp	(-0, +168)	\| History	\| Source
· /sources/canbus/frameinterface.h	(-0, +102)	\| History	\| Source
· /sources/canbus/messagedispatcher.cpp	(-3, +3)	\| History	\| Source	\| Diff
· /sources/canbus/messagehandler.cpp	(-168, +0)	\| History	\| Source	\| Diff
· /sources/canbus/messagehandler.h	(-101, +0)	\| History	\| Source	\| Diff
· /unittests/unittests.cpp	(-20, +20)	\| History	\| Source	\| Diff
· /unittests/unittests.h	(-8, +8)	\| History	\| Source	\| Diff