Fisheye on application/unittests/tst_views.h

application (bugfix/DEN-16597-UI-BN-S114): DEN-3605, DEN-3726: Addressed code review comments

Tue, 06 Oct 2020 12:16:42 -0700

Peter Lucia committed 20a6717 on branch master, 2020_EOY_DEMO and 248 more in application

DEN-3605, DEN-3726: Addressed code review comments

· /denali.qrc	(-3, +3)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/NotificationBar.qml	(-3, +3)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/RectSelectCreateTreatment.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/SliderCreateTreatment.qml	(-2, +2)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/SliderDoubleCreateTreatment.qml	(-4, +4)	\| History	\| Source	\| Diff
· /sources/gui/qml/dialogs/NotificationDialog.qml	(-4, +4)	\| History	\| Source	\| Diff
· /sources/gui/qml/globals/Colors.qml	(-58, +58)	\| History	\| Source	\| Diff
· /sources/gui/qml/globals/Variables.qml	(-7, +7)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/treatment/TreatmentCreate.qml	(-3, +3)	\| History	\| Source	\| Diff
· /sources/storage/filehandler.h	(-1, +0)	\| History	\| Source	\| Diff
· /unittests/tst_views.h	(-2, +4)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Merge master into DEN-3605_Create_Treatment

Wed, 02 Sep 2020 12:29:09 -0700

Peter Lucia committed 7edcaf0 on branch master, 2020_EOY_DEMO and 249 more in application

Merge master into DEN-3605_Create_Treatment

· /denali.pro

(-38, +56)

| History

| Source

| Diff

· /denali.pro.user

(-8, +8)

| History

| Source

| Diff

· /denali.qrc

(-0, +3)

| History

| Source

| Diff

· /scripts/copy.sh

(-1, +1)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-2, +23)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-3, +7)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-10, +15)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-99, +108)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-2, +2)

| History

| Source

| Diff

· /sources/gui/guicontroller.cpp

(-8, +30)

| History

| Source

| Diff

· /sources/gui/guicontroller.h

(-3, +7)

| History

| Source

| Diff

· /sources/gui/guiglobals.cpp

(-13, +21)

| History

| Source

| Diff

· /sources/gui/guiglobals.h

(-11, +39)

| History

| Source

| Diff

· /sources/gui/qml/components/NotificationBar.qml

(-2, +2)

| History

| Source

| Diff

· /sources/gui/qml/components/Slider.qml

(-3, +3)

| History

| Source

| Diff

… 20 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Mon, 31 Aug 2020 14:05:55 -0700

Dara Navaei committed 56e378f on branch master, 2020_EOY_DEMO and 253 more in application

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /main.cpp

(-2, +2)

| History

| Source

| Diff

· /scripts/autostart

(-9, +12)

| History

| Source

| Diff

· /scripts/copy.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/run.sh

(-3, +3)

| History

| Source

| Diff

· /scripts/setup.sh

(-1, +1)

| History

| Source

| Diff

· /sources/abstract/singleton.h

(-3, +3)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-2, +2)

| History

| Source

| Diff

· /sources/applicationpost.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/applicationpost.h

(-3, +3)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-3, +3)

| History

| Source

| Diff

· /sources/canbus/messageacknowmodel.cpp

(-4, +4)

| History

| Source

| Diff

… 242 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-3884: Code Review 0

Behrouz NematiPour — Thu, 20 Aug 2020 15:48:31 -0700

Behrouz NematiPour committed ed5d989 on branch master, 2020_EOY_DEMO and 256 more in application

DEN-3884: Code Review 0

· /sources/canbus/caninterface.cpp

(-421, +421)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-5, +3)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-5, +5)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-16, +16)

| History

| Source

| Diff

· /sources/gui/qml/dialogs/NotificationDialog.qml

(-0, +2)

| History

| Source

| Diff

· /sources/gui/qml/pages/ManagerHome.qml

(-15, +3)

| History

| Source

| Diff

· /sources/gui/qml/pages/treatment/TreatmentStack.qml

(-4, +5)

| History

| Source

| Diff

· /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml

(-4, +4)

| History

| Source

| Diff

· /sources/storage/logger.cpp

(-3, +3)

| History

| Source

| Diff

· /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h

(-4, +4)

| History

| Source

| Diff

· /unittests/tst_acknow.h

(-4, +3)

| History

| Source

| Diff

· /unittests/tst_canbus.h

(-5, +3)

| History

| Source

| Diff

· /unittests/tst_initializations.h

(-4, +3)

| History

| Source

| Diff

… 7 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Updated unit tests, fixed arterial and venous conversions to signed int.

Fri, 14 Aug 2020 16:48:18 -0700

Peter Lucia committed 97fc44f on branch master, 2020_EOY_DEMO and 250 more in application

Updated unit tests, fixed arterial and venous conversions to signed int.

· /denali.pro.user	(-3, +3)	\| History	\| Source	\| Diff
· /sources/model/mtreatmentparameters.cpp	(-4, +4)	\| History	\| Source	\| Diff
· /sources/view/VCreateTreatment.cpp	(-0, +1)	\| History	\| Source	\| Diff
· /unittests/tst_messaging.cpp	(-0, +6)	\| History	\| Source	\| Diff
· /unittests/tst_models.cpp	(-61, +189)	\| History	\| Source	\| Diff
· /unittests/tst_models.h	(-0, +1)	\| History	\| Source	\| Diff
· /unittests/tst_views.cpp	(-1, +155)	\| History	\| Source	\| Diff
· /unittests/tst_views.h	(-0, +1)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Updated unit tests. Fixed treatment parameter length check and made arterial and venous ints signed instead of unsigned....

Fri, 14 Aug 2020 11:01:48 -0700

Peter Lucia committed c838ade on branch master, 2020_EOY_DEMO and 250 more in application

Updated unit tests. Fixed treatment parameter length check and made arterial and venous ints signed instead of unsigned.

· /sources/model/mtreatmentparameters.cpp	(-2, +3)	\| History	\| Source	\| Diff
· /sources/view/VCreateTreatment.h	(-4, +4)	\| History	\| Source	\| Diff
· /unittests/tst_models.cpp	(-2, +80)	\| History	\| Source	\| Diff
· /unittests/tst_models.h	(-0, +4)	\| History	\| Source	\| Diff
· /unittests/tst_views.cpp	(-0, +23)	\| History	\| Source	\| Diff
· /unittests/tst_views.h	(-1, +0)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Updated unit tests: CSV, message interpreter. Added ability to save treatment parameter ranges to CSV

Thu, 13 Aug 2020 13:59:02 -0700

Peter Lucia committed 9551959 on branch master, 2020_EOY_DEMO and 250 more in application

Updated unit tests: CSV, message interpreter. Added ability to save treatment parameter ranges to CSV

· /sources/storage/storageglobals.cpp	(-6, +8)	\| History	\| Source	\| Diff
· /sources/storage/storageglobals.h	(-3, +4)	\| History	\| Source	\| Diff
· /sources/view/VCreateTreatment.cpp	(-0, +57)	\| History	\| Source	\| Diff
· /sources/view/VCreateTreatment.h	(-0, +2)	\| History	\| Source	\| Diff
· /unittests/tst_messaging.cpp	(-1, +17)	\| History	\| Source	\| Diff
· /unittests/tst_messaging.h	(-1, +2)	\| History	\| Source	\| Diff
· /unittests/tst_views.cpp	(-0, +17)	\| History	\| Source	\| Diff
· /unittests/tst_views.h	(-1, +3)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Updated unit tests, improved code testability

Thu, 13 Aug 2020 12:02:37 -0700

Peter Lucia committed 9612f30 on branch master, 2020_EOY_DEMO and 250 more in application

Updated unit tests, improved code testability

· /sources/model/mtreatmentparameters.h	(-0, +22)	\| History	\| Source	\| Diff
· /sources/view/VCreateTreatment.cpp	(-9, +7)	\| History	\| Source	\| Diff
· /sources/view/VCreateTreatment.h	(-2, +2)	\| History	\| Source	\| Diff
· /unittests/tst_views.cpp	(-32, +215)	\| History	\| Source	\| Diff
· /unittests/tst_views.h	(-0, +3)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Added Create Treatment unit tests

Wed, 12 Aug 2020 18:30:51 -0700

Peter Lucia committed 5422782 on branch master, 2020_EOY_DEMO and 250 more in application

Added Create Treatment unit tests

· /denali.pro.user	(-59, +925)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/treatment/TreatmentConfirm.qml	(-1, +3)	\| History	\| Source	\| Diff
· /sources/view/VCreateTreatment.cpp	(-32, +37)	\| History	\| Source	\| Diff
· /sources/view/VCreateTreatment.h	(-1, +7)	\| History	\| Source	\| Diff
· /unittests/tst_views.cpp	(-0, +250)	\| History	\| Source	\| Diff
· /unittests/tst_views.h	(-0, +9)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Tue, 07 Jul 2020 12:22:46 -0700

Dara Navaei committed 44a85c9 on branch master, 2020_EOY_DEMO and 258 more in application

Updated the Copyright with the current year and replaced tabs with 4 spaces

· /cppcheck.sh

(-0, +15)

| History

| Source

| Diff

· /main.cpp

(-10, +11)

| History

| Source

| Diff

· /scripts/copy.sh

(-11, +13)

| History

| Source

| Diff

· /scripts/run.sh

(-12, +13)

| History

| Source

| Diff

· /scripts/setup.sh

(-10, +12)

| History

| Source

| Diff

· /sources/abstract/singleton.h

(-10, +11)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-10, +11)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-10, +11)

| History

| Source

| Diff

· /sources/applicationpost.cpp

(-10, +11)

| History

| Source

| Diff

· /sources/applicationpost.h

(-10, +11)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-13, +14)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-13, +14)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-9, +10)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-9, +10)

| History

| Source

| Diff

· /sources/canbus/messageacknowmodel.cpp

(-9, +10)

| History

| Source

| Diff

… 184 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-3157 : Code Coverage...

Behrouz NematiPour — Tue, 23 Jun 2020 14:18:20 -0700

Behrouz NematiPour committed 0b1e556 on branch master, 2020_EOY_DEMO and 260 more in application

DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /sources/model/mtreatmentadjustrequests.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp	(-12, +6)	\| History	\| Source	\| Diff
· /unittests/tst_views.cpp	(-0, +31)	\| History	\| Source	\| Diff
· /unittests/tst_views.h	(-0, +2)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): DEN-3164 : Code Review 0...

Behrouz NematiPour — Thu, 07 May 2020 03:54:43 -0700

Behrouz NematiPour committed b798668 on branch master, 2020_EOY_DEMO and 262 more in application

DEN-3164 : Code Review 0

- Corrected the copyright comment Doxygen tags.

- Corrected the copyright template Doxygen tags.

- Added check for fall through in switch statements to project.

- Added method comments in tst_messaging, unit test class.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /copyright

(-4, +4)

| History

| Source

| Diff

· /denali.pro

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-3, +3)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageacknowmodel.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageacknowmodel.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-4, +4)

| History

| Source

| Diff

· /sources/gui/guiglobals.cpp

(-4, +4)

| History

| Source

| Diff

… 69 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-2236_UI100%CoverageoftheApplicationSoftware...

Behrouz NematiPour — Tue, 21 Apr 2020 05:14:04 -0700

Behrouz NematiPour committed d3f9160 on branch master, 2020_EOY_DEMO and 266 more in application

DEN-2236_UI100%CoverageoftheApplicationSoftware

level 1

Coverage : 99.594% (1473/1479)

Manual : 15.416% (228/1479)

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /denali.pro

(-4, +60)

| History

| Source

| Diff

· /denali.pro.user

(-375, +694)

| History

| Source

| Diff

· /main.cpp

(-17, +15)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-0, +6)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-6, +26)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-3, +11)

| History

| Source

| Diff

· /sources/canbus/frameinterface.h

(-0, +2)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-0, +2)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-0, +5)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-0, +4)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-0, +3)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-1, +2)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-0, +8)

| History

| Source

| Diff

· /sources/gui/guiglobals.cpp

(-2, +7)

| History

| Source

| Diff

· /sources/gui/guiglobals.h

(-1, +1)

| History

| Source

| Diff

… 24 more files in changeset.