Fisheye on application/sources/model/hd

application (bugfix/DEN-16597-UI-BN-S114): DEN-3884: Code Review 0...

Behrouz NematiPour — Thu, 20 Aug 2020 18:05:16 -0700

Behrouz NematiPour committed 6188918 on branch master, 2020_EOY_DEMO and 256 more in application

DEN-3884: Code Review 0

- fixed typos

· /sources/applicationcontroller.h

(-1, +1)

| History

| Source

| Diff

· /sources/applicationpost.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.h

(-133, +133)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-5, +5)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-2, +2)

| History

| Source

| Diff

· /sources/gui/guicontroller.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/gui/guiglobals.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/guiglobals.h

(-4, +4)

| History

| Source

| Diff

· /sources/gui/guiview.cpp

(-6, +6)

| History

| Source

| Diff

· /sources/model/MAbstract.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/model/MAbstract.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/MDGDebugText.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/model/MHDDebugText.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/model/MModel.h

(-1, +1)

| History

| Source

| Diff

… 13 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-3883: Coverage

Behrouz NematiPour — Thu, 06 Aug 2020 02:16:15 -0700

Behrouz NematiPour committed bf645ac on branch master, 2020_EOY_DEMO and 257 more in application

DEN-3883: Coverage

· /denali.pro.user	(-244, +57)	\| History	\| Source	\| Diff
· /sources/canbus/messagedispatcher.cpp	(-3, +7)	\| History	\| Source	\| Diff
· /sources/canbus/messageinterpreter.cpp	(-20, +14)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/NotificationBar.qml	(-18, +17)	\| History	\| Source	\| Diff
· /sources/gui/qml/dialogs/NotificationDialog.qml	(-6, +9)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/SettingsHome.qml	(-0, +1)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmStatusData.cpp	(-65, +67)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmStatusData.h	(-2, +9)	\| History	\| Source	\| Diff
· /sources/storage/filehandler.cpp	(-7, +5)	\| History	\| Source	\| Diff
· /sources/storage/logger.cpp	(-0, +2)	\| History	\| Source	\| Diff
· /sources/view/valarmstatus.cpp	(-7, +1)	\| History	\| Source	\| Diff
· /unittests/tst_messaging.cpp	(-27, +56)	\| History	\| Source	\| Diff
· /unittests/tst_messaging.h	(-5, +7)	\| History	\| Source	\| Diff
· /unittests/tst_models.cpp	(-11, +138)	\| History	\| Source	\| Diff
· /unittests/tst_models.h	(-5, +16)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Merge master into Logging (#1 successful build and run)

Behrouz NematiPour — Thu, 30 Jul 2020 03:03:55 -0700

Behrouz NematiPour committed 93b6ad6 on branch master, 2020_EOY_DEMO and 257 more in application

Merge master into Logging (#1 successful build and run)

· /sources/applicationcontroller.cpp	(-4, +4)	\| History	\| Source	\| Diff
· /sources/applicationcontroller.h	(-3, +4)	\| History	\| Source	\| Diff
· /sources/canbus/messageinterpreter.cpp	(-5, +4)	\| History	\| Source	\| Diff
· /sources/canbus/messageinterpreter.h	(-3, +3)	\| History	\| Source	\| Diff
· /sources/gui/guicontroller.h	(-3, +4)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/SettingsHome.qml	(-3, +56)	\| History	\| Source	\| Diff
· /sources/model/hd/adjustment/MTreatmentAdjustRequests.h	(-0, +16)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmStatusData.cpp	(-0, +76)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmStatusData.h	(-2, +4)	\| History	\| Source	\| Diff
· /sources/view/valarmstatus.cpp	(-4, +4)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): 4246: Merge Newly added Squish API Messages into Dial-In...

Behrouz NematiPour — Tue, 28 Jul 2020 11:58:16 -0700

Behrouz NematiPour committed aa0772f on branch master, 2020_EOY_DEMO and 257 more in application

4246: Merge Newly added Squish API Messages into Dial-In

- Has not been merged yet but preparing for.

· /denali.pro.user	(-254, +103)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/ManagerHome.qml	(-9, +9)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/SettingsHome.qml	(-1, +2)	\| History	\| Source	\| Diff
· /sources/maintimer.cpp	(-0, +3)	\| History	\| Source	\| Diff
· /sources/model/hd/adjustment/MTreatmentAdjustRequests.h	(-6, +18)	\| History	\| Source	\| Diff
· /sources/model/hd/data/MTreatmentFlowsData.h	(-0, +9)	\| History	\| Source	\| Diff
· /sources/model/hd/data/MTreatmentOutletFlowData.h	(-0, +6)	\| History	\| Source	\| Diff
· /sources/model/hd/data/MTreatmentPressureOcclusionData.h	(-1, +6)	\| History	\| Source	\| Diff
· /sources/model/hd/data/MTreatmentTimeData.h	(-0, +6)	\| History	\| Source	\| Diff
· /sources/storage/filehandler.cpp	(-0, +6)	\| History	\| Source	\| Diff
· /sources/storage/logger.cpp	(-0, +3)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGValvesStatesData.h	(-0, +2)	\| History	\| Source	\| Diff
· /unittests/tst_models.cpp	(-229, +867)	\| History	\| Source	\| Diff
· /unittests/tst_models.h	(-17, +35)	\| History	\| Source	\| Diff
· /unittests/tst_utilities.cpp	(-0, +51)	\| History	\| Source	\| Diff
· /unittests/tst_utilities.h	(-0, +3)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): DEN-3881: Unit Testing...

Behrouz NematiPour — Sun, 19 Jul 2020 20:08:48 -0700

Behrouz NematiPour committed cb2101c on branch master, 2020_EOY_DEMO and 257 more in application

DEN-3881: Unit Testing

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /sources/canbus/messageinterpreter.cpp	(-32, +24)	\| History	\| Source	\| Diff
· /sources/canbus/messageinterpreter.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/hd/adjustment/MTreatmentAdjustRequests.h	(-1, +1)	\| History	\| Source	\| Diff
· /unittests/tst_logging.cpp	(-6, +6)	\| History	\| Source	\| Diff
· /unittests/tst_logging.h	(-1, +1)	\| History	\| Source	\| Diff
· /unittests/tst_messaging.cpp	(-13, +13)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): DEN-4002: Implementation 2 [SRSUI 476: Log files rotation]...

Behrouz NematiPour — Fri, 17 Jul 2020 22:24:00 -0700

Behrouz NematiPour committed 3aab844 on branch master, 2020_EOY_DEMO and 257 more in application

DEN-4002: Implementation 2 [SRSUI 476: Log files rotation]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /denali.pro

(-2, +2)

| History

| Source

| Diff

· /main.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-6, +6)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-3, +3)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-3, +3)

| History

| Source

| Diff

· /sources/canbus/messageacknowmodel.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-5, +5)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-7, +24)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-1, +2)

| History

| Source

| Diff

· /sources/gui/guiglobals.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/model/MAbstract.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/dg/data/MDGDrainPumpData.h

(-3, +5)

| History

| Source

| Diff

· /sources/model/dg/data/MDGHeatersData.h

(-3, +5)

| History

| Source

| Diff

· /sources/model/dg/data/MDGLoadCellReadingsData.h

(-3, +5)

| History

| Source

| Diff

… 33 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-4002 : Implementation 2...

Behrouz NematiPour — Thu, 16 Jul 2020 12:27:38 -0700

Behrouz NematiPour committed 246bf68 on branch master, 2020_EOY_DEMO and 257 more in application

DEN-4002 : Implementation 2

- Improvements of log text and so .

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /sources/canbus/messageacknowmodel.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/messagedispatcher.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/messageinterpreter.cpp	(-38, +32)	\| History	\| Source	\| Diff
· /sources/canbus/messageinterpreter.h	(-0, +2)	\| History	\| Source	\| Diff
· /sources/gui/qml/main.qml	(-2, +2)	\| History	\| Source	\| Diff
· /sources/model/hd/adjustment/MTreatmentAdjustRequests.h	(-6, +22)	\| History	\| Source	\| Diff
· /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationConfirmResponse.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationEditResponse.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/hd/data/MTreatmentOutletFlowData.h	(-1, +0)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): FW Support for HD/DG Debug Text & HDOpMode....

Behrouz NematiPour — Mon, 13 Jul 2020 11:24:33 -0700

Behrouz NematiPour committed 15de0cd on branch master, 2020_EOY_DEMO and 257 more in application

FW Support for HD/DG Debug Text & HDOpMode.

- Added a newly added channel to the list of listened channels eChlid_DG_UI = 0x070

- The MessageBuilder::getActionId implementation has been improved.

- New Messages has been added and enum/length defined as well.

- Message interpreter code has been improved to be easily modifiable.

- Changed the message ID enum ID_PowerOffBroadcast to ID_ShuttingDown.

- Added HDOperationMode to the setting screen.

- Made the floating point rounding optional by a #define and disabled the rounding for now.

- Inherit the MPowerOff Model from MAbstract as a new design.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /denali.pro

(-6, +12)

| History

| Source

| Diff

· /denali.pro.user

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/frameinterface.cpp

(-0, +1)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-5, +5)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-36, +42)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-60, +37)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-1, +0)

| History

| Source

| Diff

· /sources/gui/guiglobals.cpp

(-1, +2)

| History

| Source

| Diff

· /sources/gui/guiglobals.h

(-3, +16)

| History

| Source

| Diff

· /sources/gui/qml/main.qml

(-3, +3)

| History

| Source

| Diff

· /sources/gui/qml/pages/SettingsHome.qml

(-2, +27)

| History

| Source

| Diff

· /sources/model/MAbstract.cpp

(-0, +6)

| History

| Source

| Diff

· /sources/model/MAbstract.h

(-2, +2)

| History

| Source

| Diff

· /sources/model/MDGDebugText.cpp

(-0, +35)

| History

| Source

… 17 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-3874 : HW Support [Per Peman's Email]...

Behrouz NematiPour — Mon, 06 Jul 2020 00:42:12 -0700

Behrouz NematiPour committed 30f83b2 on branch master, 2020_EOY_DEMO and 257 more in application

DEN-3874 : HW Support [Per Peman's Email]

- Unified All the Data messages to use the newly created parent model MAbstract.

- Cleaned up the logging class.

- Removed log_once macros.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /denali.pro.user

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/caninterface.cpp

(-2, +3)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-2, +3)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-257, +29)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-25, +13)

| History

| Source

| Diff

· /sources/gui/qml/pages/SettingsHome.qml

(-1, +1)

| History

| Source

| Diff

· /sources/model/MAbstract.cpp

(-7, +18)

| History

| Source

| Diff

· /sources/model/MAbstract.h

(-0, +1)

| History

| Source

| Diff

· /sources/model/dg/data/MDGDrainPumpData.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/hd/adjustment/MTreatmentAdjustBloodDialysateResponse.cpp

(-17, +11)

| History

| Source

| Diff

· /sources/model/hd/adjustment/MTreatmentAdjustBloodDialysateResponse.h

(-15, +15)

| History

| Source

| Diff

· /sources/model/hd/adjustment/MTreatmentAdjustDurationResponse.cpp

(-16, +11)

| History

| Source

| Diff

· /sources/model/hd/adjustment/MTreatmentAdjustDurationResponse.h

(-15, +15)

| History

| Source

| Diff

· /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationEditResponse.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationStateResponse.cpp

(-6, +4)

| History

| Source

| Diff

… 17 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-3874 : HW Support [Per Peman's Email]...

Behrouz NematiPour — Thu, 02 Jul 2020 21:47:57 -0700

Behrouz NematiPour committed 6ae83fa on branch master, 2020_EOY_DEMO and 257 more in application

DEN-3874 : HW Support [Per Peman's Email]

- Just to keep the code. Needs clean up.

- Don't forget Logs (DG, HD is different)

- So many more.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /denali.pro

(-77, +145)

| History

| Source

| Diff

· /denali.pro.user

(-1, +1)

| History

| Source

| Diff

· /sources/applicationcontroller.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/applicationcontroller.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagebuilder.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.cpp

(-7, +7)

| History

| Source

| Diff

· /sources/canbus/messagedispatcher.h

(-5, +5)

| History

| Source

| Diff

· /sources/canbus/messageglobals.h

(-29, +40)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.cpp

(-98, +89)

| History

| Source

| Diff

· /sources/canbus/messageinterpreter.h

(-5, +4)

| History

| Source

| Diff

· /sources/gui/guicontroller.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/guicontroller.h

(-1, +1)

| History

| Source

| Diff

· /sources/gui/guiglobals.cpp

(-3, +13)

| History

| Source

| Diff

· /sources/gui/guiglobals.h

(-37, +43)

| History

| Source

| Diff

· /sources/gui/qml/main.qml

(-4, +18)

| History

| Source

| Diff

… 127 more files in changeset.