RESOLVED

Hey Peter,
Thanks for the comments and all the testing .
This function doesn't mean to be used the way you tested it.
But anyway I came up with a better solution.

def partition(vString, vPart, vRightDirection=True):
    return [vString[i: i + vPart] for i in range(0, len(vString), vPart)][::-1 if vRightDirection else 1]

Actually my first thought was not correct on how this portion of the code should work.

def partition_orig(vString, vPart, vRightDirection = True):
    if vRightDirection:
        list = [vString[i - vPart : i] for i in range(len(vString), 0, -vPart)]
    else:
        list = [vString[i : i + vPart] for i in range(0, len(vString), vPart)]
    return list


def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart][::-1] for i in range(0, len(vString), vPart)]

print(partition_orig("TESTING123", 3))
print(partition_2("TESTING123", 3))

                  

Outputs:

['123', 'ING', 'EST', '']
['123', 'ING', 'EST', 'T']

whereas

def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart] for i in range(0, len(vString), vPart)]

outputs

['321', 'GNI', 'TSE', 'T']

I think you're saying you want to do the second one right? I think that would be better too!

Edit: Also I don't think you need the mString because in python immutable types (e.g. string, number, tuple) behave like call by value

I came out with the solution below :

def partition1(vString, vPart, vRightDirection=True):
mString = vString
if vRightDirection:
mString = vString[::-1]
else:
mString = vString
list = [mString[i: i + vPart] for i in range(0, len(mString), vPart)]
return list

if _name_ == "_main_":
vString = "TESTING"
vPart = 3

list = partition1(vString, vPart, True)
print(list)


list = partition1(vString, vPart, False)
print(list)

// ----- Output ----- :
['GNI', 'TSE', 'T']
['TES', 'TIN', 'G']

which is exactly what I want.
I'm gonna push changes if you agree.

Thank you so much Peter.
This is exactly the kind of code review I really like.
I looked at the code you sent and tried to test it.
At a first glance I saw a misbehavior.

your code is partition2.
list = partition2("TESTING", 2, False)
print(list)

list = partition("TESTING", 2, False)
print(list)
// —
The output is different :
['ET', 'TS', 'NI', 'G'] partition2
['TE', 'ST', 'IN', 'G'] partition

so the output is unexpected.

 partition("TESTING123", 3) 

will return

['123', 'ING', 'EST', ''] 

which is missing a character.

Also,

 partition("TESTING123", 12) 

returns

 ['23'] 

which isn't right.

How about:

def partition(vString, vPart, vRightDirection = True):
	if vRightDirection:
		vString = vString[::-1]
	return [vString[i : i + vPart][::-1] for i in range(0, len(vString), vPart)]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

· /shared/scripts/crc.py	(-0, +51)	| History	| Source
· /shared/scripts/denaliMessages.py	(-0, +138)	| History	| Source
· /shared/scripts/globals.py	(-0, +16)	| History	| Source
· /shared/scripts/messageBuilder.py	(-0, +52)	| History	| Source
· /shared/scripts/names.py	(-1, +41)	| History	| Source	| Diff
· /shared/scripts/unittests.py	(-0, +49)	| History	| Source
· /shared/scripts/utils.py	(-0, +48)	| History	| Source
· /suite.conf	(-1, +1)	| History	| Source	| Diff
· /tst_GlobalTests/test.py	(-0, +20)	| History	| Source
· /tst_HomeScreen/test.py	(-0, +37)	| History	| Source
· /tst_ServiceShutdown/test.py	(-0, +118)	| History	| Source
· /tst_TreatmentScreen/test.py	(-0, +32)	| History	| Source
· /tst_Treatment_Adjustment_BloodDialysate/test.py	(-0, +72)	| History	| Source
· /tst_Treatment_BloodDialysate_Section/test.py	(-0, +42)	| History	| Source
· /tst_Treatment_ParametersRange/test.py	(-0, +45)	| History	| Source
… 4 more files in changeset.

]]> Wed, 20 Nov 2019 18:20:29 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/testsuites?cs=5e50c9793e8200292af43dec8657e659a16deca4 https://devapps.diality.us/changelog/testsuites?cs=5e50c9793e8200292af43dec8657e659a16deca4 Behrouz NematiPour committed 5e50c97 on branch 2020_EOY_DEMO, DEN-10602_UI_DEV_PatientID and 56 more in testsuites DEN-704_HomeScreen

- Updated the SquishQt test-suites for Home Screen regarding the new design.

· /.gitignore	(-0, +1)	| History	| Source
· /shared/scripts/bdd_hooks.py	(-24, +0)	| History	| Source	| Diff
· /shared/scripts/names.py	(-12, +21)	| History	| Source	| Diff
· /shared/scripts/names.pyc	(binary)	| History	| Source	| Diff
· /shared/steps/steps.py	(-82, +0)	| History	| Source	| Diff
· /suite.conf	(-1, +1)	| History	| Source	| Diff
· /tst_Manager/test.feature	(-23, +0)	| History	| Source	| Diff
· /tst_Manager/test.py	(-8, +0)	| History	| Source	| Diff
· /tst_Treatment/test.feature	(-23, +0)	| History	| Source	| Diff
· /tst_Treatment/test.py	(-8, +0)	| History	| Source	| Diff
· /tst_homescreen/test.py	(-0, +25)	| History	| Source
· /tst_pythonversion/test.py	(-0, +6)	| History	| Source

]]>