Fisheye on dgfirmware/

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 code review

Dara Navaei — Wed, 09 Dec 2020 11:37:03 -0800

Dara Navaei committed 080a5f1 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 code review

· /firmware/App/Controllers/UVReactors.c

(-17, +6)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 addressed code review comments and continued with dev testing

Dara Navaei — Mon, 07 Dec 2020 18:34:49 -0800

Dara Navaei committed 5e99007 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 addressed code review comments and continued with dev testing

· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-15, +22)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-11, +10)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-1, +1)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-1077, +1087)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 continued with dev testing

Dara Navaei — Thu, 03 Dec 2020 15:30:17 -0800

Dara Navaei committed 58774a3 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 continued with dev testing

· /results/Build_Status_Report.csv	(-3, +13)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-1218, +2279)	\| History	\| Source	\| Diff
· /results/cppcheck.log	(-48, +51)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-25, +28)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 added TODO comments for the persistent alarm checks

Dara Navaei — Wed, 02 Dec 2020 12:47:24 -0800

Dara Navaei committed 9e24f08 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 added TODO comments for the persistent alarm checks

· /firmware/App/Controllers/ConcentratePumps.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 made some temporary changes in the code to be able to use the latest changed from peristent alarm driver

Dara Navaei — Wed, 02 Dec 2020 12:35:51 -0800

Dara Navaei committed 10be818 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 made some temporary changes in the code to be able to use the latest changed from peristent alarm driver

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/MessagePayloads.h	(-8, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 addressed code review comments and continued with dev testing

Dara Navaei — Wed, 02 Dec 2020 11:26:43 -0800

Dara Navaei committed 4638fd7 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 addressed code review comments and continued with dev testing

· /firmware/App/Controllers/UVReactors.c	(-19, +20)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-8, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-53, +22)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-6, +3)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 initial commit of the unit test and integration test of the UV reactors

Dara Navaei — Sat, 28 Nov 2020 17:26:42 -0800

Dara Navaei committed ae407ab on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 initial commit of the unit test and integration test of the UV reactors

· /firmware/App/Controllers/UVReactors.c	(-20, +33)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 initial commit of the branch

Dara Navaei — Tue, 24 Nov 2020 23:46:16 -0800

Dara Navaei committed 00b0fce on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 initial commit of the branch

· /firmware/App/Controllers/UVReactors.c	(-0, +570)	\| History	\| Source
· /firmware/App/Controllers/UVReactors.h	(-0, +54)	\| History	\| Source
· /firmware/App/Modes/ModeInitPOST.c	(-0, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-0, +15)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-986, +994)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1148, +1307)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-137, +152)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-3, +15)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merge branch 'DEN-3504-dg-dialysate-composition-1-of-2'

Mon, 23 Nov 2020 17:25:40 -0800

Quang Nguyen committed 4e5752a on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 227 more in dgfirmware

Merge branch 'DEN-3504-dg-dialysate-composition-1-of-2'

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Updated accelerometer UT

Mon, 23 Nov 2020 16:01:37 -0800

Quang Nguyen committed 0c61042 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Updated accelerometer UT

· /results/Build_Status_Report.csv	(-1, +2)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-761, +643)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-4, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Added IT for concentrate pumps

Mon, 23 Nov 2020 12:59:06 -0800

Quang Nguyen committed 6a8f441 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Added IT for concentrate pumps

· /results/Build_Status_Report.csv	(-2, +1)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-591, +937)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Updated UT and IT

Tue, 17 Nov 2020 11:16:47 -0800

Quang Nguyen committed a6bf8a0 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Updated UT and IT

· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-1, +1)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-619, +601)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Addressed code review

Tue, 17 Nov 2020 10:39:05 -0800

Quang Nguyen committed 498aa28 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Addressed code review

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Refactor control pump separately and add reverse motor dir

Mon, 16 Nov 2020 14:13:22 -0800

Quang Nguyen committed 3461c14 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Refactor control pump separately and add reverse motor dir

· /firmware/App/Controllers/ConcentratePumps.c	(-84, +136)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-6, +6)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-1, +1)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-1336, +1487)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-11, +11)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Prevent division by zero when pumps on with zero flow rate

Fri, 13 Nov 2020 15:36:44 -0800

Quang Nguyen committed d717fd8 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Prevent division by zero when pumps on with zero flow rate

· /firmware/App/Controllers/ConcentratePumps.c

(-16, +18)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Turn concentrate pumps during mode transition

Fri, 13 Nov 2020 11:13:12 -0800

Quang Nguyen committed dd7fad8 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Turn concentrate pumps during mode transition

· /firmware/App/Modes/ModeRecirculate.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Removed operation mode clean up and refactor concentrate pumps

Fri, 13 Nov 2020 10:45:50 -0800

Quang Nguyen committed 3f22d88 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Removed operation mode clean up and refactor concentrate pumps

· /firmware/App/Controllers/ConcentratePumps.c	(-8, +29)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-13, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-24, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-3, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Added fill dialysate time out and concentrate pump speed check

Thu, 12 Nov 2020 08:59:25 -0800

Quang Nguyen committed 80028d3 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Added fill dialysate time out and concentrate pump speed check

· /firmware/App/Controllers/ConcentratePumps.c	(-5, +98)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-9, +32)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-0, +24)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +32)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Addressed code review

Tue, 10 Nov 2020 14:17:28 -0800

Quang Nguyen committed 273f797 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Addressed code review

· /firmware/App/Controllers/ConcentratePumps.c	(-38, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Addressed code reviews

Tue, 10 Nov 2020 11:05:11 -0800

Quang Nguyen committed 62ee40b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Addressed code reviews

· /firmware/App/Controllers/ConcentratePumps.c	(-86, +57)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-43, +9)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-18, +18)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-10, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Added probe type for cpi and check empty emstat read size

Mon, 09 Nov 2020 11:57:30 -0800

Quang Nguyen committed 7e2931d on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Added probe type for cpi and check empty emstat read size

· /firmware/App/Controllers/ConductivitySensors.c	(-3, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-29, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-3, +0)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-1, +1)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-1101, +1080)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-3, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Fixed style issue

Fri, 06 Nov 2020 09:48:59 -0800

Quang Nguyen committed b5a2c2e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Fixed style issue

· /firmware/App/Controllers/ConductivitySensors.c

(-4, +4)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Fixed compile issues and updated persistent alarm tests

Wed, 04 Nov 2020 11:36:41 -0800

Quang Nguyen committed 41c7186 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Fixed compile issues and updated persistent alarm tests

· /firmware/App/Controllers/ConductivitySensors.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Added missing function header

Mon, 02 Nov 2020 17:55:29 -0800

Quang Nguyen committed 88fdd83 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Added missing function header

· /firmware/App/Controllers/ConcentratePumps.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +16)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Fixed UT for system comm messages

Mon, 02 Nov 2020 11:41:33 -0800

Quang Nguyen committed 2f8e714 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Fixed UT for system comm messages

· /firmware/App/Services/SystemCommMessages.c	(-0, +1)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-1, +1)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-842, +868)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Addressed code reviews

Mon, 02 Nov 2020 10:43:12 -0800

Quang Nguyen committed 2059f90 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Addressed code reviews

· /firmware/App/DGCommon.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Addressed code reviews

Mon, 02 Nov 2020 10:28:42 -0800

Quang Nguyen committed d4e5e5e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Addressed code reviews

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +18)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-6, +23)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-19, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Addressed code review

Fri, 30 Oct 2020 14:57:54 -0700

Quang Nguyen committed c593086 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Addressed code review

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Addressed code reviews

Fri, 30 Oct 2020 14:55:47 -0700

Quang Nguyen committed 3166d2e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Addressed code reviews

· /firmware/App/Controllers/ConductivitySensors.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Added concentrate pump publish data override functions

Thu, 29 Oct 2020 16:46:56 -0700

Quang Nguyen committed 7336ffd on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Added concentrate pump publish data override functions

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +72)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +32)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff