Fisheye on dgfirmware/firmware/App/Controllers

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6081 added more prathesis for clarity

Dara Navaei — Wed, 30 Dec 2020 14:10:25 -0800

Dara Navaei committed d5b2e26 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 223 more in dgfirmware

DEN-6081 added more prathesis for clarity

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6081 added pranthesis in ROPump.c

Dara Navaei — Wed, 30 Dec 2020 12:57:40 -0800

Dara Navaei committed 6dd2dda on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 223 more in dgfirmware

DEN-6081 added pranthesis in ROPump.c

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6081 addressed code review comments

Dara Navaei — Tue, 29 Dec 2020 20:49:29 -0800

Dara Navaei committed 3090e6a on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 223 more in dgfirmware

DEN-6081 addressed code review comments

· /firmware/App/Controllers/ROPump.c

(-7, +14)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6080 addressed code review comments

Dara Navaei — Tue, 29 Dec 2020 14:09:35 -0800

Dara Navaei committed 1abaeb3 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 222 more in dgfirmware

DEN-6080 addressed code review comments

· /firmware/App/Controllers/DrainPump.c

(-10, +15)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6080 addressed code review comments

Dara Navaei — Tue, 29 Dec 2020 10:25:23 -0800

Dara Navaei committed 6a1cc50 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 222 more in dgfirmware

DEN-6080 addressed code review comments

· /firmware/App/Controllers/DrainPump.c

(-16, +17)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6080 added safety shutdown for the drain pump driver

Dara Navaei — Mon, 28 Dec 2020 14:20:42 -0800

Dara Navaei committed 6915ff4 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 222 more in dgfirmware

DEN-6080 added safety shutdown for the drain pump driver

· /firmware/App/Controllers/DrainPump.c

(-23, +39)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6080 changed the drain pump delta pressure control to drain pump outlet pressure control

Dara Navaei — Mon, 28 Dec 2020 12:57:52 -0800

Dara Navaei committed 3d8b84b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 222 more in dgfirmware

DEN-6080 changed the drain pump delta pressure control to drain pump outlet pressure control

· /firmware/App/Controllers/DrainPump.c	(-30, +29)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6081 added a flow out of lower range alarm in the RO pump

Dara Navaei — Mon, 28 Dec 2020 10:45:59 -0800

Dara Navaei committed 48e0b1c on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 223 more in dgfirmware

DEN-6081 added a flow out of lower range alarm in the RO pump

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6081 worked on ROPump.c

Dara Navaei — Mon, 28 Dec 2020 10:39:04 -0800

Dara Navaei committed 40de07b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 223 more in dgfirmware

DEN-6081 worked on ROPump.c

· /firmware/App/Controllers/ROPump.c

(-1, +16)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6081 worked on the comments in ROPump.c

Dara Navaei — Sat, 26 Dec 2020 10:30:08 -0800

Dara Navaei committed f2e1d5b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 223 more in dgfirmware

DEN-6081 worked on the comments in ROPump.c

· /firmware/App/Controllers/ROPump.c

(-23, +23)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-6081 initial commit

Dara Navaei — Fri, 18 Dec 2020 14:22:38 -0800

Dara Navaei committed d0ddf8f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 223 more in dgfirmware

DEN-6081 initial commit

· /firmware/App/Controllers/ROPump.c

(-24, +26)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5855 addressed code review comments

Dara Navaei — Thu, 10 Dec 2020 15:19:27 -0800

Dara Navaei committed 00b32a5 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 224 more in dgfirmware

DEN-5855 addressed code review comments

· /firmware/App/Controllers/ROPump.c	(-28, +25)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-11, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +0)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-1, +1)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-625, +4107)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-4, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5855 merged DEN-5873, UV reactors and ran the script

Dara Navaei — Thu, 10 Dec 2020 13:39:13 -0800

Dara Navaei committed 88f2823 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 224 more in dgfirmware

DEN-5855 merged DEN-5873, UV reactors and ran the script

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-0, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-29, +166)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +14)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +14)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +2)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-12, +6)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-1821, +3105)	\| History	\| Source	\| Diff
· /results/cppcheck.log	(-50, +52)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5855 resolved merge conflicts and ran the script

Dara Navaei — Wed, 09 Dec 2020 21:24:33 -0800

Dara Navaei committed 497e910 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 224 more in dgfirmware

DEN-5855 resolved merge conflicts and ran the script

· /firmware/App/Controllers/ROPump.c	(-11, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-9, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-129, +20)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-5, +2)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-0, +94)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-0, +37701)	\| History	\| Source	\| Diff
· /results/cppcheck.log	(-0, +158)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-0, +84)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5855 mereged master into the branch and resolved the merge conflicts

Dara Navaei — Wed, 09 Dec 2020 13:36:36 -0800

Dara Navaei committed 666d172 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 224 more in dgfirmware

DEN-5855 mereged master into the branch and resolved the merge conflicts

· /firmware/App/Controllers/ConcentratePumps.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-0, +11)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +42)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-869, +1215)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-3, +22)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-91, +0)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-34356, +0)	\| History	\| Source	\| Diff
· /results/cppcheck.log	(-158, +0)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-88, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 code review

Dara Navaei — Wed, 09 Dec 2020 11:37:03 -0800

Dara Navaei committed 080a5f1 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 code review

· /firmware/App/Controllers/UVReactors.c

(-17, +6)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5846 ran the script

Dara Navaei — Wed, 09 Dec 2020 09:24:52 -0800

Dara Navaei committed 374bab1 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5846 ran the script

· /firmware/App/Controllers/Thermistors.c	(-9, +5)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-11, +6)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-1143, +2449)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5855 addressed code review comments

Dara Navaei — Wed, 09 Dec 2020 08:07:44 -0800

Dara Navaei committed 93dc357 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 224 more in dgfirmware

DEN-5855 addressed code review comments

· /firmware/App/Controllers/DrainPump.c	(-12, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-3, +2)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-1113, +1157)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5864 addressed code review comments and continued with dev testing

Dara Navaei — Tue, 08 Dec 2020 13:59:30 -0800

Dara Navaei committed c31c6e4 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5864 addressed code review comments and continued with dev testing

· /firmware/App/Controllers/ROPump.c	(-48, +33)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-4, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 addressed code review comments and continued with dev testing

Dara Navaei — Mon, 07 Dec 2020 18:34:49 -0800

Dara Navaei committed 5e99007 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 addressed code review comments and continued with dev testing

· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-15, +22)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-11, +10)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-1, +1)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-1077, +1087)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5846 addressed code review comments and continued with dev testing

Dara Navaei — Mon, 07 Dec 2020 14:54:20 -0800

Dara Navaei committed 2e4afce on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5846 addressed code review comments and continued with dev testing

· /firmware/App/Controllers/Fans.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-33, +26)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Thermistors.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5846 addressed code review comments and continued with dev testing

Dara Navaei — Sun, 06 Dec 2020 10:06:46 -0800

Dara Navaei committed feb9374 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5846 addressed code review comments and continued with dev testing

· /firmware/.launches/DG.launch

(-0, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-5, +8)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-49, +37)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-2, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-154, +78)

| History

| Source

| Diff

· /firmware/App/Controllers/Thermistors.c

(-14, +18)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +3)

| History

| Source

| Diff

· /firmware/App/Services/FPGA.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Services/FPGA.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/MessagePayloads.h

(-8, +0)

| History

| Source

| Diff

· /firmware/App/Services/SystemComm.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Services/SystemCommMessages.c

(-36, +36)

| History

| Source

| Diff

· /firmware/App/Services/SystemCommMessages.h

(-3, +3)

| History

| Source

| Diff

· /results/Build_Status_Report.csv

(-3, +16)

| History

| Source

| Diff

… 3 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5855 addressed code review comments and continued with dev testing

Dara Navaei — Thu, 03 Dec 2020 14:11:42 -0800

Dara Navaei committed 3524635 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 224 more in dgfirmware

DEN-5855 addressed code review comments and continued with dev testing

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-5, +8)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-46, +11)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-2, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-0, +8)

| History

| Source

| Diff

· /firmware/App/Services/MessagePayloads.h

(-8, +0)

| History

| Source

| Diff

· /firmware/App/Services/PIControllers.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Services/PIControllers.h

(-1, +3)

| History

| Source

| Diff

· /firmware/App/Services/SystemCommMessages.c

(-52, +19)

| History

| Source

| Diff

· /firmware/App/Services/SystemCommMessages.h

(-4, +0)

| History

| Source

| Diff

· /results/Build_Status_Report.csv

(-5, +12)

| History

| Source

| Diff

… 3 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5864 addressed code review comments and continued with dev testing

Dara Navaei — Wed, 02 Dec 2020 16:58:55 -0800

Dara Navaei committed fbc0a28 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5864 addressed code review comments and continued with dev testing

· /firmware/App/Controllers/ROPump.c	(-47, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-7, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-54, +24)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-6, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 added TODO comments for the persistent alarm checks

Dara Navaei — Wed, 02 Dec 2020 12:47:24 -0800

Dara Navaei committed 9e24f08 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 added TODO comments for the persistent alarm checks

· /firmware/App/Controllers/ConcentratePumps.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 made some temporary changes in the code to be able to use the latest changed from peristent alarm driver

Dara Navaei — Wed, 02 Dec 2020 12:35:51 -0800

Dara Navaei committed 10be818 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 made some temporary changes in the code to be able to use the latest changed from peristent alarm driver

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/MessagePayloads.h	(-8, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5873 addressed code review comments and continued with dev testing

Dara Navaei — Wed, 02 Dec 2020 11:26:43 -0800

Dara Navaei committed 4638fd7 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5873 addressed code review comments and continued with dev testing

· /firmware/App/Controllers/UVReactors.c	(-19, +20)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-8, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-53, +22)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-6, +3)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5846 addressed code review comments and continued with dev testing

Dara Navaei — Tue, 01 Dec 2020 12:57:30 -0800

Dara Navaei committed ec15e94 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5846 addressed code review comments and continued with dev testing

· /firmware/App/Controllers/Fans.c

(-16, +26)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5846 ran VectorCAST

Dara Navaei — Tue, 01 Dec 2020 10:38:51 -0800

Dara Navaei committed 4fdc324 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5846 ran VectorCAST

· /firmware/App/Controllers/Heaters.c	(-19, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Thermistors.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5846 ran vectorCAST and addressed code review comments

Dara Navaei — Mon, 30 Nov 2020 22:02:17 -0800

Dara Navaei committed 0b17c62 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 225 more in dgfirmware

DEN-5846 ran vectorCAST and addressed code review comments

· /firmware/App/Controllers/Fans.c	(-69, +60)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Fans.h	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-88, +166)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Thermistors.c	(-46, +44)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Thermistors.h	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/InternalADC.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-0, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-0, +48)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-0, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-2, +2)	\| History	\| Source	\| Diff