Fisheye on dialin/

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6638: ptTx-RB: Code Review 0...

Behrouz NematiPour — Mon, 15 Feb 2021 18:05:34 -0800

Behrouz NematiPour committed e5d96ec on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 244 more in dialin

DEN-6638: ptTx-RB: Code Review 0

- removed extra empty line.

· /dialin/ui/hd_simulator.py

(-1, +0)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6638: ptTx-RB: Code Review 0...

Behrouz NematiPour — Mon, 15 Feb 2021 18:00:04 -0800

Behrouz NematiPour committed 7089b9a on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 244 more in dialin

DEN-6638: ptTx-RB: Code Review 0

- made the console out of the received can messages optional in the HDSimulator class constructor.

· /dialin/protocols/CAN.py	(-2, +4)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-2, +4)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6869: Added Version Dialin API and a Simulator plugin...

Behrouz NematiPour — Sat, 13 Feb 2021 20:47:11 -0800

Behrouz NematiPour committed 3ed79c5 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 244 more in dialin

DEN-6869: Added Version Dialin API and a Simulator plugin

- Added two more conversion functions to convert 2 and 1 byte values to byte array.

- used byte_to_bytearray (1 byte value conversion) and short_to_bytearray (2 bytes value conversion) in versions messages.

· /dialin/ui/hd_simulator.py	(-21, +21)	\| History	\| Source	\| Diff
· /dialin/utils/conversions.py	(-0, +20)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6869: Added Accelerometer Dialin API and a Simulator plugin...

Behrouz NematiPour — Sat, 13 Feb 2021 19:40:17 -0800

Behrouz NematiPour committed bf3f26d on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 244 more in dialin

DEN-6869: Added Accelerometer Dialin API and a Simulator plugin

- Added version API

- Added signal strength parameters to the blood/dialysate flow rate APIs

· /dialin/common/msg_defs.py	(-3, +0)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-8, +163)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6869: ptTx-RB: Implementation [Simulator/Testing] (2/2)...

Behrouz NematiPour — Thu, 11 Feb 2021 22:35:07 -0800

Behrouz NematiPour committed 5d509ca on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 244 more in dialin

DEN-6869: ptTx-RB: Implementation [Simulator/Testing] (2/2)

- Added Treatment End API to be used in the Simulator.

· /dialin/common/msg_defs.py	(-0, +3)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-0, +22)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6868: ptTx-RB: Implementation [Simulator/Testing] (1/2)...

Behrouz NematiPour — Wed, 10 Feb 2021 23:06:59 -0800

Behrouz NematiPour committed e41213d on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 244 more in dialin

DEN-6868: ptTx-RB: Implementation [Simulator/Testing] (1/2)

- Completed the Treatment States (SubMode) enums

- Added "Blood Prime", "Treatment End". "Treatment Stop" states enums

- Added 3 parameter of "Blood Prime", "Treatment End". "Treatment Stop" to the cmd_set_treatment_states_data method.

- Added rinseback timeout parameter to cmd_send_treatment_rinseback_data

- Added recirculate timeout data message as cmd_send_treatment_recirculate_data method.

· /dialin/common/msg_defs.py	(-1, +2)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-30, +93)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6868: Blood Prime Simulation...

Behrouz NematiPour — Tue, 09 Feb 2021 17:01:23 -0800

Behrouz NematiPour committed 342405f on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 244 more in dialin

DEN-6868: Blood Prime Simulation

- Added Blood Prime Dialin API

· /dialin/common/msg_defs.py	(-0, +1)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-0, +21)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6868: ptTx-RB: Implementation [Simulator/Testing] (1/2)...

Behrouz NematiPour — Tue, 09 Feb 2021 13:57:28 -0800

Behrouz NematiPour committed 15ac4ef on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 244 more in dialin

DEN-6868: ptTx-RB: Implementation [Simulator/Testing] (1/2)

- Added an instance counter for HDSimulator to be used in Simulator.

- Added Rinseback and Recirculate states in HDSimulator

- Updated cmd_set_treatment_states_data for Rinseback and Recirculate.

- Added Rinseback Rsp/Data messages

- Added Recirculate Rsp

- Added a print so HDSimulator will print out the received messages in console.

· /dialin/common/msg_defs.py	(-0, +4)	\| History	\| Source	\| Diff
· /dialin/protocols/CAN.py	(-0, +1)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-6, +88)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-5759: Code Review 0

Behrouz NematiPour — Mon, 01 Feb 2021 13:43:17 -0800

Behrouz NematiPour committed 46af3f4 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 245 more in dialin

DEN-5759: Code Review 0

· /dialin/ui/hd_simulator.py

(-5, +0)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6612 UI_DVT: Pre-Treatment Ultrafiltration...

Behrouz NematiPour — Sun, 24 Jan 2021 21:14:43 -0800

Behrouz NematiPour committed c8f8886 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 245 more in dialin

DEN-6612 UI_DVT: Pre-Treatment Ultrafiltration

- This story wasn't part of the current sprint S37 but while I worked on it to be able to push it to master ASAP, so put the story as the commit comment.

- Added cmd_set_treatment_adjust_ultrafiltration_init_response

· /dialin/ui/hd_simulator.py

(-0, +24)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-5757: Code Coverage...

Behrouz NematiPour — Thu, 21 Jan 2021 19:14:42 -0800

Behrouz NematiPour committed 1935655 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 245 more in dialin

DEN-5757: Code Coverage

- Fixing priming message ID

· /dialin/common/msg_defs.py

(-2, +2)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): Merge branch 'master' into DEN-5751_Pre-TreatmentUltrafiltration

Behrouz NematiPour — Thu, 21 Jan 2021 18:44:19 -0800

Behrouz NematiPour committed a7915e1 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 245 more in dialin

Merge branch 'master' into DEN-5751_Pre-TreatmentUltrafiltration

dialin (DEN-12358-sw_dev-sprint-67_mg): Temporarily fixed the Priming messaging issue...

Behrouz NematiPour — Thu, 21 Jan 2021 01:48:51 -0800

Behrouz NematiPour committed 9f4b091 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 245 more in dialin

Temporarily fixed the Priming messaging issue

- This was causing the the tst_confirmprimingbegin to not to receive the priming status message therefore couldn't reach 100% coverage.

- Not sure if this will break anything for now all the test were working and passed with 100% coverage.

· /dialin/common/msg_defs.py

(-2, +2)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): Merge branch 'DEN-5830_AlarmDesign'...

Behrouz NematiPour — Wed, 20 Jan 2021 20:01:29 -0800

Behrouz NematiPour committed 996674b on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 245 more in dialin

Merge branch 'DEN-5830_AlarmDesign'

- Kept the squish folder content for backward compatibility since the dialin migration has need been code reviewed yet.

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-5838: Code Review 0...

Behrouz NematiPour — Tue, 19 Jan 2021 14:34:26 -0800

Behrouz NematiPour committed ef52d75 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 246 more in dialin

DEN-5838: Code Review 0

- moved the cr shell script into the tools folder.

· /cr_objectives.sh	(-4, +0)	\| History	\| Source	\| Diff
· /tools/cr_objectives.sh	(-0, +4)	\| History	\| Source

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-5838: Code Review 0

Behrouz NematiPour — Wed, 13 Jan 2021 17:02:17 -0800

Behrouz NematiPour committed 60a0619 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 246 more in dialin

DEN-5838: Code Review 0

· /cr_objectives.sh	(-0, +4)	\| History	\| Source
· /dialin/squish/unittests.py	(-3, +0)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): Updated changelog

Wed, 30 Dec 2020 09:56:20 -0800

Peter Lucia committed eec0986 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 250 more in dialin

Updated changelog

· /CHANGELOG.md

(-0, +91)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6018: Deleted unneeded test script

Tue, 22 Dec 2020 12:59:57 -0800

Peter Lucia committed 2d3ff06 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 255 more in dialin

DEN-6018: Deleted unneeded test script

· /tests/send_malformed_message.sh

(-8, +0)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DIAL-49, DIAL-52: Handling invalid denali message gracefully, ensure sleep of 1ms before re-checking receive buffer.

Tue, 22 Dec 2020 12:49:53 -0800

Peter Lucia committed 3338499 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 255 more in dialin

DIAL-49, DIAL-52: Handling invalid denali message gracefully, ensure sleep of 1ms before re-checking receive buffer.

· /dialin/protocols/CAN.py	(-2, +4)	\| History	\| Source	\| Diff
· /tests/send_malformed_message.sh	(-0, +8)	\| History	\| Source

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6018, DIAL-49, DIAL-52: Added to logging test, updated logger, handle malformed denali messages that don't include a...

Tue, 22 Dec 2020 09:45:51 -0800

Peter Lucia committed e10534f on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 255 more in dialin

DEN-6018, DIAL-49, DIAL-52: Added to logging test, updated logger, handle malformed denali messages that don't include a payload length

· /dialin/protocols/CAN.py	(-1, +4)	\| History	\| Source	\| Diff
· /dialin/utils/base.py	(-3, +14)	\| History	\| Source	\| Diff
· /tests/test_logging.py	(-2, +24)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6018, DEN-4864: Ensuring ACK is sent back when required. Clearing alarms when starting hd simulator.

Mon, 21 Dec 2020 10:05:13 -0800

Peter Lucia committed a3f3f5c on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 256 more in dialin

DEN-6018, DEN-4864: Ensuring ACK is sent back when required. Clearing alarms when starting hd simulator.

· /dialin/common/msg_defs.py	(-2, +4)	\| History	\| Source	\| Diff
· /dialin/protocols/CAN.py	(-2, +5)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-1, +44)	\| History	\| Source	\| Diff
· /tests/test_gen_requirements.py	(-13, +18)	\| History	\| Source	\| Diff
· /tests/test_hd_simulator.py	(-1, +2)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-5802: Fixed _publish decorator typo

Fri, 18 Dec 2020 12:34:14 -0800

Peter Lucia committed 84eb432 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 256 more in dialin

DEN-5802: Fixed _publish decorator typo

· /dialin/hd/ui_proxy.py

(-1, +1)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DIAL-54, DEN-5802: Added flag to disable/enable metadata in the logger

Fri, 18 Dec 2020 12:03:25 -0800

Peter Lucia committed 1497311 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 256 more in dialin

DIAL-54, DEN-5802: Added flag to disable/enable metadata in the logger

· /dialin/utils/base.py

(-2, +9)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6018: Added unit tests, added defaults when settings treatment parameters.

Wed, 16 Dec 2020 17:46:14 -0800

Peter Lucia committed 5f420f9 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 256 more in dialin

DEN-6018: Added unit tests, added defaults when settings treatment parameters.

· /dialin/hd/ui_proxy.py	(-17, +17)	\| History	\| Source	\| Diff
· /dialin/ui/__init__.py	(-2, +1)	\| History	\| Source	\| Diff
· /tests/unit_tests/test_ui_proxy.py	(-0, +122)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-6018: Fixed squish migration conflicts after merge

Wed, 16 Dec 2020 15:04:52 -0800

Peter Lucia committed 5a37805 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 256 more in dialin

DEN-6018: Fixed squish migration conflicts after merge

· /dialin/common/msg_defs.py	(-0, +2)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-153, +39)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): Merge branch '2020_EOY_DEMO' into develop

Wed, 16 Dec 2020 13:46:27 -0800

Peter Lucia committed 0392b23 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 256 more in dialin

Merge branch '2020_EOY_DEMO' into develop

· /dialin/common/msg_defs.py	(-0, +1)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-0, +46)	\| History	\| Source	\| Diff
· /dialin/ui/unittests.py	(-13, +4)	\| History	\| Source	\| Diff
· /dialin/ui/utils.py	(-0, +18)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): Merge master into develop

Wed, 16 Dec 2020 12:05:07 -0800

Peter Lucia committed a37f46b on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 256 more in dialin

Merge master into develop

· /dialin/squish/denaliMessages.py	(-1330, +0)	\| History	\| Source	\| Diff
· /dialin/ui/__init__.py	(-0, +1)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-5, +180)	\| History	\| Source	\| Diff
· /dialin/ui/utils.py	(-10, +38)	\| History	\| Source	\| Diff
· /tests/unit_tests/test_imports.py	(-1, +1)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): Merge branch 'DEN-3504-dg-dialysate-composition-1-of-2' into develop

Tue, 15 Dec 2020 09:54:45 -0800

Quang Nguyen committed 9f42ac3 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 256 more in dialin

Merge branch 'DEN-3504-dg-dialysate-composition-1-of-2' into develop

· /dialin/common/msg_defs.py

(-2, +2)

| History

| Source

| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): Merge branch 'DEN-5802-Sprint-33' into develop

Mon, 14 Dec 2020 20:07:08 -0800

Peter Lucia committed 7c94a3d on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 256 more in dialin

Merge branch 'DEN-5802-Sprint-33' into develop

dialin (DEN-12358-sw_dev-sprint-67_mg): Merge branch 'DEN-5751_Pre-TreatmentUltrafiltration' into 2020_EOY_DEMO

Behrouz NematiPour — Mon, 14 Dec 2020 19:23:42 -0800

Behrouz NematiPour committed 1ea73de on branch 2020_EOY_DEMO, Calibration_fixes and 257 more in dialin

Merge branch 'DEN-5751_Pre-TreatmentUltrafiltration' into 2020_EOY_DEMO