Fisheye on application/sources/view/VBluetooth.h https://devapps.diality.us/changelog/~br%3DDEN-7524_Service-Mode/application/sources/view/VBluetooth.h Recent activity in "application" under directory /sources/view/VBluetooth.h UI-DEN-7044-2: closed by Behrouz NematiPour Wed, 01 Feb 2023 00:00:46 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-2 https://devapps.diality.us/cru/UI-DEN-7044-2 Behrouz NematiPour Closed UI-DEN-7044-2 ]]> UI-DEN-7524-3: closed by Behrouz NematiPour Tue, 31 Jan 2023 23:59:33 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7524-3 https://devapps.diality.us/cru/UI-DEN-7524-3 Behrouz NematiPour Closed UI-DEN-7524-3 ]]> UI-DEN-8058-1: closed by Behrouz NematiPour Tue, 31 Jan 2023 23:48:51 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8058-1 https://devapps.diality.us/cru/UI-DEN-8058-1 Behrouz NematiPour Closed UI-DEN-8058-1 ]]> UI-DEN-8058-1: started by Dara Navaei Mon, 09 Jan 2023 07:03:50 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-8058-1 https://devapps.diality.us/cru/UI-DEN-8058-1 Dara Navaei started review UI-DEN-8058-1 ]]> UI-DEN-7524-3: started by Dara Navaei Mon, 09 Jan 2023 07:02:12 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-7524-3 https://devapps.diality.us/cru/UI-DEN-7524-3 Dara Navaei started review UI-DEN-7524-3 ]]> UI-DEN-7044-2: started by Dara Navaei Wed, 28 Dec 2022 08:59:26 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-7044-2 https://devapps.diality.us/cru/UI-DEN-7044-2 Dara Navaei started review UI-DEN-7044-2 ]]> UI-DEN-7044-1: closed by plucia Tue, 13 Apr 2021 15:46:46 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7044-1 https://devapps.diality.us/cru/UI-DEN-7044-1 plucia  (deleted user) Closed UI-DEN-7044-1 ]]> UI-DEN-7044-1: reviewers finished Tue, 13 Apr 2021 15:46:31 -0700 https://devapps.diality.us/cru/UI-DEN-7044-1 https://devapps.diality.us/cru/UI-DEN-7044-1 Behrouz NematiPour and pmontazemi  (deleted user) finished reviewing UI-DEN-7044-1 UI-DEN-7044_Wifi ]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Tue, 13 Apr 2021 15:45:54 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9261 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9261 Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Tue, 13 Apr 2021 15:44:53 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9260 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9260 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Tue, 13 Apr 2021 15:39:34 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9259 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9259 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Tue, 13 Apr 2021 15:38:11 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9258 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9258 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by plucia "Done" Thu, 08 Apr 2021 17:49:29 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7044-1/#c9107 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9107 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-7044-1

Done

]]> UI-DEN-7044-1: comment by plucia "Addressed - ready for review" Thu, 08 Apr 2021 17:45:14 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7044-1/#c9106 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9106 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-7044-1

Addressed - ready for review

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Wed, 07 Apr 2021 16:37:49 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9059 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9059 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Wed, 07 Apr 2021 16:36:56 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9058 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9058 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Wed, 07 Apr 2021 16:36:27 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9057 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9057 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Wed, 07 Apr 2021 16:36:06 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9056 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9056 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "Please move it to line 139" Wed, 07 Apr 2021 16:32:12 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9055 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9055 Behrouz NematiPour commented on UI-DEN-7044-1

Please move it to line 139

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "Thanks for doing this. But that is not what I ..." Wed, 07 Apr 2021 16:25:29 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9054 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9054 Behrouz NematiPour commented on UI-DEN-7044-1

Thanks for doing this.
But that is not what I meant.
Struct Data should only have basic data types which require to be sending between threads.
What is implemented here is an immediate struct definition in a class which will be passed and is literally the same as a class and has the only overhead of a struct defined in the class.
Please use Data as the data and remove the functions from the struct Data.
I think the concept of having the struct Data is not clarified, let me know if I need to explain mor.

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Wed, 07 Apr 2021 16:22:07 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9053 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9053 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Wed, 07 Apr 2021 16:20:49 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9052 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9052 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by Behrouz NematiPour "RESOLVED" Wed, 07 Apr 2021 16:19:09 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-1/#c9051 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9051 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED

]]> UI-DEN-7044-1: comment by pmontazemi "RESOLVED." Wed, 07 Apr 2021 09:40:42 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-7044-1/#c9046 https://devapps.diality.us/cru/UI-DEN-7044-1/#c9046 pmontazemi  (deleted user) replied to plucia  (deleted user) in UI-DEN-7044-1

RESOLVED.

]]> UI-DEN-7044-1: comment by plucia "It is now removed, WifiNetworkData is added to ..." Thu, 01 Apr 2021 13:27:59 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7044-1/#c8933 https://devapps.diality.us/cru/UI-DEN-7044-1/#c8933 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-7044-1

It is now removed, WifiNetworkData is added to REGISTER_MODEL_METATYPES now

]]> UI-DEN-7044-1: comment by plucia "Moved this to onStart() and calling start() in ..." Thu, 01 Apr 2021 10:48:08 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7044-1/#c8925 https://devapps.diality.us/cru/UI-DEN-7044-1/#c8925 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-7044-1

Moved this to onStart() and calling start() in main.cpp which emits a private signal didStart() that is connected to onStart as we discussed

]]> UI-DEN-7044-1: comment by plucia "Done" Thu, 01 Apr 2021 10:23:07 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7044-1/#c8914 https://devapps.diality.us/cru/UI-DEN-7044-1/#c8914 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-7044-1

Done

]]> UI-DEN-7044-1: comment by plucia "I agree it should be private. I've updated it t..." Thu, 01 Apr 2021 10:19:33 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7044-1/#c8913 https://devapps.diality.us/cru/UI-DEN-7044-1/#c8913 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-7044-1

I agree it should be private. I've updated it to onAddNetwork and it is now private

]]> UI-DEN-7044-1: comment by plucia "Updated it to use the settings stack specifical..." Thu, 01 Apr 2021 10:06:23 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7044-1/#c8912 https://devapps.diality.us/cru/UI-DEN-7044-1/#c8912 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-7044-1

Updated it to use the settings stack specifically when popping or pushing

]]> UI-DEN-7044-1: comment by plucia "Just tested this and confirmed the alarm dialog..." Thu, 01 Apr 2021 09:57:48 -0700 plucia https://devapps.diality.us/cru/UI-DEN-7044-1/#c8911 https://devapps.diality.us/cru/UI-DEN-7044-1/#c8911 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-7044-1

Just tested this and confirmed the alarm dialog shows up in front of the join / disconnect dialog

]]>