Fisheye on dgfirmware/firmware/App/Modes

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 11 Apr 2024 18:03:29 -0700

Dara Navaei committed 7d0fd5e on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 23 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-232 added code to get the reservoirs empty weight from the calibration records and set the reservoirs tare offset...

Dara Navaei — Thu, 11 Apr 2024 13:30:26 -0700

Dara Navaei committed c2df1e4 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-232 added code to get the reservoirs empty weight from the calibration records and set the reservoirs tare offset to 0 upon transitioning to service mode

· /firmware/App/Controllers/LoadCell.c	(-8, +29)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeService.c	(-0, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the mode fill produce diaylsate timeouts to run the concentrate pumps at faster speed

Dara Navaei — Wed, 10 Apr 2024 14:43:08 -0700

Dara Navaei committed b2262c1 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 changed the mode fill produce diaylsate timeouts to run the concentrate pumps at faster speed

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 added a blank line

Dara Navaei — Tue, 09 Apr 2024 13:27:35 -0700

Dara Navaei committed f108744 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 added a blank line

· /firmware/App/Modes/ModeFill.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the polarity of the concentrate pumps park progress

Dara Navaei — Tue, 09 Apr 2024 13:26:53 -0700

Dara Navaei committed c6e110b on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 changed the polarity of the concentrate pumps park progress

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 added code to check the progress of the concentrate pump's park

Dara Navaei — Tue, 09 Apr 2024 13:22:30 -0700

Dara Navaei committed 0dc0ea1 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 added code to check the progress of the concentrate pump's park

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +39)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 added code to not transition from the fill modes's start state unless both concentrate pumps are parked

Dara Navaei — Tue, 09 Apr 2024 10:59:34 -0700

Dara Navaei committed dc0a9db on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 added code to not transition from the fill modes's start state unless both concentrate pumps are parked

· /firmware/App/Modes/ModeFill.c

(-31, +33)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 moved the local variables to the top in Gen Idle

Dara Navaei — Tue, 09 Apr 2024 09:14:18 -0700

Dara Navaei committed 95a629a on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 moved the local variables to the top in Gen Idle

· /firmware/App/Modes/ModeGenIdle.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the code set the reset park alarms to False once the pump started and not to park the concentrate pum...

Dara Navaei — Tue, 09 Apr 2024 09:07:23 -0700

Dara Navaei committed d607909 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 changed the code set the reset park alarms to False once the pump started and not to park the concentrate pumps if they are already parked

· /firmware/App/Controllers/ConcentratePumps.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-236 changed the concentrate pumps to park in Gen Idle and also remove the concentrate pumps park alarm

Dara Navaei — Fri, 05 Apr 2024 17:27:31 -0700

Dara Navaei committed c1d5811 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-236 changed the concentrate pumps to park in Gen Idle and also remove the concentrate pumps park alarm

· /firmware/App/Controllers/ConcentratePumps.c	(-14, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 05 Apr 2024 10:37:53 -0700

Dara Navaei committed 69a0d10 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-218 changed the macro of alarm 274 to F32 from U32

Dara Navaei — Mon, 01 Apr 2024 15:50:15 -0700

Dara Navaei committed 72ac4f8 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

DENBUG-218 changed the macro of alarm 274 to F32 from U32

· /firmware/App/Modes/ModeGenIdle.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 07 Mar 2024 10:32:48 -0800

Dara Navaei committed ac029c3 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 24 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 updated the comments

Dara Navaei — Wed, 06 Mar 2024 14:47:44 -0800

Dara Navaei committed 8d0fc6d on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 25 more in dgfirmware

DEN-16682 updated the comments

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-28, +30)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 changed the fill mode to get the target conductivity values from the bicarb values of the fill conductivities ...

Dara Navaei — Wed, 06 Mar 2024 13:32:02 -0800

Dara Navaei committed 9d47686 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 25 more in dgfirmware

DEN-16682 changed the fill mode to get the target conductivity values from the bicarb values of the fill conductivities in the non-volaitle memory. Updated the VectorCAST test cases

· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 removed CD1 check in the fill mode

Dara Navaei — Tue, 05 Mar 2024 15:41:18 -0800

Dara Navaei committed 7cd8a55 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 25 more in dgfirmware

DEN-16682 removed CD1 check in the fill mode

· /firmware/App/Modes/ModeFill.c

(-16, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump...

Dara Navaei — Tue, 05 Mar 2024 08:14:46 -0800

Dara Navaei committed 7c5eba5 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 25 more in dgfirmware

DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump driver

· /firmware/App/Controllers/ConductivitySensors.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-0, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 added the alarm for the fill acid/bicarb target conductivities in the DG calibration record

Dara Navaei — Sat, 02 Mar 2024 15:58:22 -0800

Dara Navaei committed 581064e on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 25 more in dgfirmware

DEN-16682 added the alarm for the fill acid/bicarb target conductivities in the DG calibration record

· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 changed the acid pumps speed in mode fill

Dara Navaei — Fri, 01 Mar 2024 16:52:32 -0800

Dara Navaei committed 166097c on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 25 more in dgfirmware

DEN-16682 changed the acid pumps speed in mode fill

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 29 Feb 2024 15:04:39 -0800

Dara Navaei committed e3839e1 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 25 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 addressed the code reivew comment

Dara Navaei — Thu, 29 Feb 2024 13:04:22 -0800

Dara Navaei committed 9663d70 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 26 more in dgfirmware

DEN-16674 addressed the code reivew comment

· /firmware/App/Modes/ModeFill.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 addressed the code review comments

Dara Navaei — Thu, 29 Feb 2024 10:59:06 -0800

Dara Navaei committed 63c6107 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 26 more in dgfirmware

DEN-16674 addressed the code review comments

· /firmware/App/Modes/ModeFill.c

(-30, +33)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 updated the code for mode fill calibration check command

Dara Navaei — Thu, 29 Feb 2024 08:36:29 -0800

Dara Navaei committed 8e62ede on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 26 more in dgfirmware

DEN-16674 updated the code for mode fill calibration check command

· /firmware/App/Modes/ModeFill.c	(-0, +80)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +33)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 changed the speed of the acid concentrate pump. CD2 will be used for acid check in the Mode Fill

Dara Navaei — Fri, 23 Feb 2024 09:33:58 -0800

Dara Navaei committed b41ffef on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 26 more in dgfirmware

DEN-16682 changed the speed of the acid concentrate pump. CD2 will be used for acid check in the Mode Fill

· /firmware/App/Modes/ModeFill.c

(-6, +7)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16681 addressed the code review comment

Dara Navaei — Thu, 22 Feb 2024 10:57:31 -0800

Dara Navaei committed 3acd796 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 26 more in dgfirmware

DEN-16681 addressed the code review comment

· /firmware/App/Modes/ModeFill.c

(-4, +4)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16681 changed the tolerances of acid and bicarb check in Mdoe Fill

Dara Navaei — Thu, 22 Feb 2024 09:17:18 -0800

Dara Navaei committed 8432595 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 26 more in dgfirmware

DEN-16681 changed the tolerances of acid and bicarb check in Mdoe Fill

· /firmware/App/Modes/ModeFill.c

(-2, +4)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 15 Feb 2024 15:46:48 -0800

Dara Navaei committed 84989e1 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 26 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

Thu, 15 Feb 2024 12:16:52 -0800

Darren Cox committed 3a007e0 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 27 more in dgfirmware

DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

· /firmware/App/Modes/ModeGenIdle.c	(-19, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +24)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 fix typo.

Tue, 13 Feb 2024 16:26:29 -0800

Darren Cox committed 4366794 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 27 more in dgfirmware

DEN-16587 fix typo.

· /firmware/App/Modes/ModeGenIdle.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Only check for unwanted full in treatment mode. Pretreat has transfers from one reservoir to other.

Tue, 13 Feb 2024 15:04:49 -0800

Darren Cox committed dcb42b5 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 27 more in dgfirmware

DEN-16587 Only check for unwanted full in treatment mode. Pretreat has transfers from one reservoir to other.

· /firmware/App/Modes/ModeGenIdle.c

(-2, +5)

| History

| Source

| Diff