Fisheye on dgfirmware/firmware/App

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 16 Aug 2023 17:33:00 -0700

Dara Navaei committed 78a62db on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 78 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 17:32:53 -0700

Dara Navaei committed d0536d7 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 78 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15974 updated the state of VPo in the cleaning modes' drain to be to fill

Dara Navaei — Wed, 16 Aug 2023 17:27:14 -0700

Dara Navaei committed 213c09d on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more in dgfirmware

DEN-15974 updated the state of VPo in the cleaning modes' drain to be to fill

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-16222 updated the heat disinfect code

Dara Navaei — Wed, 16 Aug 2023 14:37:04 -0700

Dara Navaei committed 1c73626 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more in dgfirmware

DEN-16222 updated the heat disinfect code

· /firmware/App/Modes/ModeHeatDisinfect.c

(-8, +7)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-16222 fixed the heat disinfect cancel water path drain R1

Dara Navaei — Wed, 16 Aug 2023 14:32:52 -0700

Dara Navaei committed 2bb5167 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more in dgfirmware

DEN-16222 fixed the heat disinfect cancel water path drain R1

· /firmware/App/Modes/ModeHeatDisinfect.c

(-3, +5)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15974 removed the clearance time of the persistence alarms of the concentrate pumps

Dara Navaei — Wed, 16 Aug 2023 13:27:46 -0700

Dara Navaei committed af18131 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more in dgfirmware

DEN-15974 removed the clearance time of the persistence alarms of the concentrate pumps

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 16 Aug 2023 11:31:06 -0700

Dara Navaei committed 52ae429 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 11:30:57 -0700

Dara Navaei committed 7f64bdb on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16215 addressed the code review comments

Dara Navaei — Wed, 16 Aug 2023 10:28:37 -0700

Dara Navaei committed d3e1ad2 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

DEN-16215 addressed the code review comments

· /firmware/App/Modes/ModeFill.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 16 Aug 2023 10:22:14 -0700

Dara Navaei committed 1b899af on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 10:22:01 -0700

Dara Navaei committed b90c388 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16215 removed the start state from mode fill

Dara Navaei — Wed, 16 Aug 2023 10:20:10 -0700

Dara Navaei committed 6919275 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

DEN-16215 removed the start state from mode fill

· /firmware/App/Modes/ModeFill.c

(-8, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge remote-tracking branch 'origin/staging' into staging

Wed, 16 Aug 2023 10:16:56 -0700

James Walter Taylor committed 50572d2 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Merge remote-tracking branch 'origin/staging' into staging

· /firmware/App/Services/SystemComm.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge remote-tracking branch 'origin/DEN-15996-over-ride-commands-duplicates-the-id-msg_id_valves_states_publish_interva...

Wed, 16 Aug 2023 10:04:33 -0700

James Walter Taylor committed 28427a8 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Merge remote-tracking branch 'origin/DEN-15996-over-ride-commands-duplicates-the-id-msg_id_valves_states_publish_interval_override' into staging

· /firmware/App/Services/SystemComm.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 16 Aug 2023 09:44:03 -0700

Dara Navaei committed 30b4e77 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 09:43:45 -0700

Dara Navaei committed 3d8da96 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-14692: code review comments.

Michael Garthwaite — Tue, 15 Aug 2023 16:40:43 -0700

Michael Garthwaite committed 5968bdc on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 81 more in dgfirmware

DEN-14692: code review comments.

· /firmware/App/Services/SystemCommMessages.h

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-14692: Implemented message handling for DG RAM status override.

Michael Garthwaite — Tue, 15 Aug 2023 15:40:21 -0700

Michael Garthwaite committed 7408f6f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 81 more in dgfirmware

DEN-14692: Implemented message handling for DG RAM status override.

· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +33)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 15 Aug 2023 09:08:39 -0700

Dara Navaei committed e10b1cc on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 81 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 15 Aug 2023 09:08:27 -0700

Dara Navaei committed 94b2c47 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 81 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 11 Aug 2023 17:12:03 -0700

Dara Navaei committed a71b30b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 82 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 11 Aug 2023 17:11:55 -0700

Dara Navaei committed 1cdf34a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 82 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16212 fixed the concentrate pumps speed alarm

Dara Navaei — Fri, 11 Aug 2023 16:53:00 -0700

Dara Navaei committed 988ec87 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 83 more in dgfirmware

DEN-16212 fixed the concentrate pumps speed alarm

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DIAL-269: Fixed dialin's get ro only mode

Michael Garthwaite — Fri, 11 Aug 2023 14:12:08 -0700

Michael Garthwaite committed a98dd1b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 82 more in dgfirmware

DIAL-269: Fixed dialin's get ro only mode

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DIAL-269: fixes, code formatting.

Michael Garthwaite — Fri, 11 Aug 2023 11:18:54 -0700

Michael Garthwaite committed bb36d57 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 82 more in dgfirmware

DIAL-269: fixes, code formatting.

· /firmware/App/Services/SystemComm.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DIAL-269: implemented DG to handle MSG_ID_DG_RO_ONLY_MODE_STATUS_REQUEST

Michael Garthwaite — Fri, 11 Aug 2023 11:17:03 -0700

Michael Garthwaite committed c6d02ee on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 82 more in dgfirmware

DIAL-269: implemented DG to handle MSG_ID_DG_RO_ONLY_MODE_STATUS_REQUEST

· /firmware/App/Services/SystemComm.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +25)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 10 Aug 2023 08:36:49 -0700

Dara Navaei committed c2619f4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 84 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 10 Aug 2023 08:36:36 -0700

Dara Navaei committed 1a21988 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 84 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

Michael Garthwaite — Thu, 10 Aug 2023 08:15:41 -0700

Michael Garthwaite committed cfcb924 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

· /firmware/App/Modes/ModeFill.c	(-22, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 09 Aug 2023 17:36:18 -0700

Dara Navaei committed 72127a3 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff