Fisheye on dgfirmware/firmware/App/Modes

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-285: fix to ensure we see transitions of submode.

Michael Garthwaite — Mon, 18 Sep 2023 08:53:20 -0700

Michael Garthwaite committed 8a25d57 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DIAL-285: fix to ensure we see transitions of submode.

· /firmware/App/Modes/OperationModes.c

(-0, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 15 Sep 2023 16:38:36 -0700

Dara Navaei committed 8ee0169 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 15 Sep 2023 15:32:40 -0700

Dara Navaei committed becd984 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated the chemical disinfect

Dara Navaei — Fri, 15 Sep 2023 08:50:56 -0700

Dara Navaei committed 3223b2c on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 updated the chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +7)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated chem disinfect

Dara Navaei — Thu, 14 Sep 2023 18:04:08 -0700

Dara Navaei committed 3835a00 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 updated chem disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated chemical disinfect

Dara Navaei — Thu, 14 Sep 2023 17:37:21 -0700

Dara Navaei committed e6ecfc3 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 updated chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16432 fixed the heat disinfect temperature out of range trial count error

Dara Navaei — Thu, 14 Sep 2023 17:01:11 -0700

Dara Navaei committed efa2127 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-16432 fixed the heat disinfect temperature out of range trial count error

· /firmware/App/Modes/ModeHeatDisinfect.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated the chemical disinfect

Dara Navaei — Thu, 14 Sep 2023 15:35:48 -0700

Dara Navaei committed 719abb7 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 updated the chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated chemical disinfect

Dara Navaei — Thu, 14 Sep 2023 13:26:44 -0700

Dara Navaei committed ddad43b on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 updated chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 addressed the code review comments

Dara Navaei — Thu, 14 Sep 2023 10:27:29 -0700

Dara Navaei committed c47dc63 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 addressed the code review comments

· /firmware/App/Modes/ModeStandby.c

(-4, +4)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 addressed the code review comments

Dara Navaei — Thu, 14 Sep 2023 09:48:13 -0700

Dara Navaei committed 5379702 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 addressed the code review comments

· /firmware/App/Controllers/Pressures.c	(-12, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 14 Sep 2023 09:29:29 -0700

Dara Navaei committed 5459a8a on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 fixed the inlet water pressure alarm. DEN-16418 added chemical flush done after chemical disinfect prior to st...

Dara Navaei — Wed, 13 Sep 2023 16:47:43 -0700

Dara Navaei committed f5fae90 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 fixed the inlet water pressure alarm. DEN-16418 added chemical flush done after chemical disinfect prior to starting RO permeate sample mode

· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +11)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 added the inlet water pressure limit in flush drain in the cleaning modes

Dara Navaei — Wed, 13 Sep 2023 11:04:59 -0700

Dara Navaei committed 93a5ad8 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 added the inlet water pressure limit in flush drain in the cleaning modes

· /firmware/App/Controllers/Pressures.c	(-2, +24)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-0, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Wed, 13 Sep 2023 09:52:18 -0700

James Walter Taylor committed 35a1f7d on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

On Dara's advice, ifdef'ed code for fill state treatment recovery

· /firmware/App/Modes/ModeFill.c

(-17, +12)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Tue, 12 Sep 2023 10:55:09 -0700

James Walter Taylor committed 9aacc7b on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reset timers when doing a test recover state, or returning from a (reset) fault condition.

· /firmware/App/Modes/ModeFill.c

(-3, +5)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: compiler fixes.

Michael Garthwaite — Mon, 11 Sep 2023 14:00:50 -0700

Michael Garthwaite committed 3c5e5fb on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DIAL-283: compiler fixes.

· /firmware/App/Modes/ModeChemicalDisinfect.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: message handling for moving average override.

Michael Garthwaite — Mon, 11 Sep 2023 13:59:11 -0700

Michael Garthwaite committed 3fc8744 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DIAL-283: message handling for moving average override.

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-10, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: chem disinfect moving average override

Michael Garthwaite — Mon, 11 Sep 2023 12:30:02 -0700

Michael Garthwaite committed e4657f6 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DIAL-283: chem disinfect moving average override

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-6, +62)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Fri, 08 Sep 2023 17:23:49 -0700

James Walter Taylor committed 482a741 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reintroduced reservoir data structure change.

Corrected the setModeFillStateTransition semantics.

· /firmware/App/Modes/ModeFill.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-3, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Fri, 08 Sep 2023 13:27:39 -0700

James Walter Taylor committed c2684b5 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Corrected spacing in the file per CR comments

· /firmware/App/Modes/ModeFill.c

(-1, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Fri, 08 Sep 2023 10:42:12 -0700

James Walter Taylor committed 66c487d on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Follow up for changes, simplifications suggested by Sean.

· /firmware/App/Modes/ModeFill.c

(-50, +24)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 08 Sep 2023 10:30:47 -0700

Dara Navaei committed 6df79a0 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16383 updated the code

Dara Navaei — Fri, 08 Sep 2023 10:23:41 -0700

Dara Navaei committed cff57d1 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 63 more in dgfirmware

DEN-16383 updated the code

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16383 updated mode flush

Dara Navaei — Fri, 08 Sep 2023 09:12:52 -0700

Dara Navaei committed 7b5a461 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 63 more in dgfirmware

DEN-16383 updated mode flush

· /firmware/App/Modes/ModeFlush.c	(-9, +10)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-2, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16383 fixed the heat disinfect alarm 242 trigger

Dara Navaei — Thu, 07 Sep 2023 18:28:33 -0700

Dara Navaei committed e5c5360 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 63 more in dgfirmware

DEN-16383 fixed the heat disinfect alarm 242 trigger

· /firmware/App/Modes/ModeHeatDisinfect.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Thu, 07 Sep 2023 15:34:47 -0700

James Walter Taylor committed 6e76184 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Updated headers

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Thu, 07 Sep 2023 15:27:30 -0700

James Walter Taylor committed ade9db1 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

fill time allowance for time spent in pause state

Cleared fill timer on transition to generate

Added removed unused (and uninitialized) variables from broadcast data structure.

· /firmware/App/Modes/ModeFill.c	(-2, +38)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-3, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16381 updated the doxygen comment

Dara Navaei — Wed, 06 Sep 2023 21:06:54 -0700

Dara Navaei committed 49926f6 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 64 more in dgfirmware

DEN-16381 updated the doxygen comment

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16381 added code to 0 the disinfect timer prior to transitioning to disinfect R1 to R2 for the first time

Dara Navaei — Wed, 06 Sep 2023 21:03:16 -0700

Dara Navaei committed 41d68e6 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 64 more in dgfirmware

DEN-16381 added code to 0 the disinfect timer prior to transitioning to disinfect R1 to R2 for the first time

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-0, +1)

| History

| Source

| Diff