So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

I think this enum should be in a different header file. I don't think this unit uses this enum.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

Do these need to be public?
I think only the driver should have to know sector addresses and sizes.
If other units want to know these things, they should call a function in this driver to get them.

I think isSectorStartAddress is a better function name.

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thought this was bytes.

don't forget to add function headers.

// **************** private functions **************

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

Add a blank line before group end marker.

No load cells in Leahi.

I think this enum belongs to NVRecords (these are records, not jobs).

I think this enum belongs to the Q (these are Q jobs), not in driver.

What about TD record CRC errors?

Are we only doing DD messages?
And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal system messages are defined.

· /AlarmMgmt.c	(-1, +1)	| History	| Source	| Diff
· /AlarmMgmt.h	(-1, +1)	| History	| Source	| Diff
· /Comm.c	(-1, +1)	| History	| Source	| Diff
· /Comm.h	(-1, +1)	| History	| Source	| Diff
· /CommBuffers.c	(-1, +1)	| History	| Source	| Diff
· /CommBuffers.h	(-1, +1)	| History	| Source	| Diff
· /Common.h	(-1, +1)	| History	| Source	| Diff
· /FPGA.c	(-1, +1)	| History	| Source	| Diff
· /FPGA.h	(-1, +1)	| History	| Source	| Diff
· /MessagePayloads.h	(-1, +1)	| History	| Source	| Diff
· /MessageSupport.c	(-1, +1)	| History	| Source	| Diff
· /MessageSupport.h	(-1, +1)	| History	| Source	| Diff
· /PIControllers.c	(-1, +1)	| History	| Source	| Diff
· /PIControllers.h	(-1, +1)	| History	| Source	| Diff
· /PersistentAlarm.c	(-1, +1)	| History	| Source	| Diff
… 14 more files in changeset.

]]> Fri, 05 Dec 2025 13:26:37 -0800 Dara Navaei https://devapps.diality.us/changelog/leahi-fwcommon?cs=36f96b1e7a43e0947ff10e3c6947d80e37152d9c https://devapps.diality.us/changelog/leahi-fwcommon?cs=36f96b1e7a43e0947ff10e3c6947d80e37152d9c Dara Navaei committed 36f96b1 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1415-pressures-monitoring-td and 55 more in leahi-fwcommon Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /AlarmMgmt.c	(-5, +5)	| History	| Source	| Diff
· /AlarmMgmt.h	(-5, +5)	| History	| Source	| Diff
· /Comm.c	(-3, +3)	| History	| Source	| Diff
· /Comm.h	(-4, +4)	| History	| Source	| Diff
· /CommBuffers.c	(-5, +5)	| History	| Source	| Diff
· /CommBuffers.h	(-5, +5)	| History	| Source	| Diff
· /Common.h	(-5, +5)	| History	| Source	| Diff
· /FPGA.c	(-3, +3)	| History	| Source	| Diff
· /FPGA.h	(-3, +3)	| History	| Source	| Diff
· /MessagePayloads.h	(-4, +4)	| History	| Source	| Diff
· /MessageSupport.c	(-5, +5)	| History	| Source	| Diff
· /MessageSupport.h	(-5, +5)	| History	| Source	| Diff
· /PIControllers.c	(-4, +4)	| History	| Source	| Diff
· /PIControllers.h	(-4, +4)	| History	| Source	| Diff
· /PersistentAlarm.c	(-5, +5)	| History	| Source	| Diff
… 14 more files in changeset.

]]> Tue, 07 Oct 2025 09:46:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2198-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2198-1 Sean Nash Closed LEAHI-DD-FIRMWARE-LDT-2198-1 ]]> Mon, 06 Oct 2025 11:00:28 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2198-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2198-1 Raghu Kallala , Michael Garthwaite and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-2198-1 LEAHI-DD-FIRMWARE-LDT-2198_Beta 1.0 FW Integration - DD Implementation ]]> Fri, 03 Oct 2025 14:45:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2198-1/#c24516 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2198-1/#c24516 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2198-1

Done.

Why the extra leading zeroes? If you want to ensure the literal is treated like a U32, you can do 0x00000001 or simply 1U, but I suspect the compiler will default to 32 bits anyway.

I believe baro is being moved to the TD firmware. DD will have to get baro readings from TD broadcasts.

Do you want to add a space for the baro pressure sensor from which we receive from the TD?

I have removed multiple M4 valve control across in DD. IO/FP will govern the M4 valve control.

fixed. thanks

fixed. thanks

fixed. thanks

fixed. removed m4 from dd side