It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

Add doxygen comments to the right of each structure field.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

Add blank line before return statement.

Keep this blank line above group header.

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

· /PIControllers.c	(-2, +2)	| History	| Source	| Diff
· /PIControllers.h	(-1, +1)	| History	| Source	| Diff

]]> Mon, 01 Jun 2026 17:35:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3958-1 ]]> Mon, 01 Jun 2026 17:18:47 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 Sean Nash and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3958-1 LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2: ]]> Mon, 01 Jun 2026 16:01:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1/#c29590 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1/#c29590 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3958-1

Done.

Done.

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

Done.

I think we also need this to be uncommented, as we were running into an alarm because of this.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

Done.

Done.

· /PIControllers.c	(-3, +3)	| History	| Source	| Diff
· /PIControllers.h	(-2, +2)	| History	| Source	| Diff

]]> Fri, 22 May 2026 11:17:41 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-fwcommon?cs=c15efb392d97ec8ae8d75953827abfb10fc70e14 https://devapps.diality.us/changelog/leahi-fwcommon?cs=c15efb392d97ec8ae8d75953827abfb10fc70e14 Dara Navaei committed c15efb3 on branch LDT-2240-disposable-tube-set-self-test, LDT-3223-dialysate-flow-rate---dd---mode-6-5-2026 and 13 more in leahi-fwcommon Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /PIControllers.c

(-2, +2)

| History

| Source

| Diff

]]> Fri, 22 May 2026 11:11:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3963-1 ]]> Fri, 22 May 2026 10:50:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3963-1 LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3: ]]> Thu, 21 May 2026 15:24:19 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29309 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29309 Vendor - TEL - Jashwant Gantyada replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3963-1

restored

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Should be #ifndef